kindred/create
1
1
Fork 0
Code Issues 53 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

[Part] Fix Part Boolean operations Refine incorrectly set for new users (#24256)

Browse Source 
* [Part] Fix Part Boolean operations Refine incorrectly set for new users

* [Part] update tests to specify Refine to be...

...false where necessary
This commit is contained in:
Syres916
2025-09-27 06:33:57 +01:00
committed by GitHub
parent cfb1810d92
commit e77f181393
7 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
tests/src/Mod/Part/App/FeatureChamfer.cpp
View File

@@ -31,6 +31,7 @@ protected:
_fused = _doc->addObject<Part::Fuse>();
_fused->Base.setValue(_boxes[0]);
_fused->Tool.setValue(_boxes[1]);
_fused->Refine.setValue(false);
_fused->execute();
_chamfer = _doc->addObject<Part::Chamfer>();
}

1
tests/src/Mod/Part/App/FeatureFillet.cpp
View File

@@ -31,6 +31,7 @@ protected:
_fused = _doc->addObject<Part::Fuse>();
_fused->Base.setValue(_boxes[0]);
_fused->Tool.setValue(_boxes[1]);
_fused->Refine.setValue(false);
_fused->execute();
_fillet = _doc->addObject<Part::Fillet>();
}

1
tests/src/Mod/Part/App/FeatureMirroring.cpp
View File

@@ -64,6 +64,7 @@ TEST_F(FeatureMirroringTest, testYMirrorWithExistingElementMap)
_fuse = _doc->addObject<Part::Fuse>();
_fuse->Base.setValue(_boxes[0]);
_fuse->Tool.setValue(_boxes[1]);
_fuse->Refine.setValue(false);
// Act
_fuse->execute();
_mirror->Source.setValue(_fuse);

2
tests/src/Mod/Part/App/FeaturePartFuse.cpp
View File

@@ -240,7 +240,7 @@ TEST_F(FeaturePartFuseTest, testRefine)
// Arrange
_fuse->Base.setValue(_boxes[0]);
_fuse->Tool.setValue(_boxes[1]);
_fuse->Refine.setValue(false);
// Act
_fuse->execute();
Part::TopoShape ts = _fuse->Shape.getValue();

1
tests/src/Mod/Part/App/PartFeatures.cpp
View File

@@ -150,6 +150,7 @@ TEST_F(PartFeaturesTest, testRefine)
auto _fuse = _doc->addObject<Part::Fuse>();
_fuse->Base.setValue(_boxes[0]);
_fuse->Tool.setValue(_boxes[3]);
_fuse->Refine.setValue(false);
_fuse->execute();
Part::TopoShape fusedts = _fuse->Shape.getShape();
auto _refine = _doc->addObject<Refine>();

1
tests/src/Mod/Part/App/TopoShapeMakeElementRefine.cpp
View File

@@ -32,6 +32,7 @@ TEST_F(FeaturePartMakeElementRefineTest, makeElementRefineBoxes)
auto _fuse = _doc->addObject<Part::Fuse>();
_fuse->Base.setValue(_boxes[0]);
_fuse->Tool.setValue(_boxes[3]);
_fuse->Refine.setValue(false);
// Act
_fuse->execute();
Part::TopoShape ts = _fuse->Shape.getShape();