kindred/create
1
1
Fork 0
Code Issues 53 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Coverity: Using invalid iterator

Browse Source
This commit is contained in:
wmayer
2020-07-19 19:23:47 +02:00
parent 60b4918333
commit e83dd3c0ce
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/Mod/Sketcher/App/SketchObject.cpp
View File

@@ -1220,6 +1220,8 @@ int SketchObject::delConstraint(int ConstrId)
int SketchObject::delConstraints(std::vector<int> ConstrIds, bool updategeometry)
{
Base::StateLocker lock(managedoperation, true); // no need to check input data validity as this is an sketchobject managed operation.
if (ConstrIds.empty())
return 0;
const std::vector< Constraint * > &vals = this->Constraints.getValues();
@@ -1227,7 +1229,7 @@ int SketchObject::delConstraints(std::vector<int> ConstrIds, bool updategeometry
std::sort(ConstrIds.begin(),ConstrIds.end());
if (*ConstrIds.begin() < 0 || *std::prev(ConstrIds.end()) >= int(vals.size()))
if (ConstrIds.front() < 0 || ConstrIds.back() >= int(vals.size()))
return -1;
for(auto rit = ConstrIds.rbegin(); rit!=ConstrIds.rend(); rit++)