kindred/create
1
1
Fork 0
Code Issues 53 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

BIM: fix handling of BIM_Sketch view properties (#25339)

Browse Source 
* BIM: fix handling of BIM_Sketch view properties

The handling of the sketch view properties was not correct:
* AutoColor was not set to `False`.
* PointSize was missing.
* PointColor was not set to the DefaultShapeVertexColor preference.
* Grid values were never applied. Sketches do not have a GridSnap property and gridSize is not the correct Draft preference.
* Sketch grid snap is a global setting that affects all sketches, the code should not change that setting IMO.

* Remove trailing white space
This commit is contained in:
Roy-043
2025-11-21 11:12:33 +01:00
committed by GitHub
parent 3d24580646
commit eac3e7eeab
1 changed files with 15 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
src/Mod/BIM/bimcommands/BimSketch.py
View File

@@ -48,25 +48,25 @@ class BIM_Sketch:
def Activated(self):
import WorkingPlane
from draftutils import params
from draftutils import utils
from FreeCAD import Units
issnap = False
if hasattr(FreeCAD, "DraftWorkingPlane"):
FreeCAD.DraftWorkingPlane.setup()
if hasattr(FreeCADGui, "Snapper"):
FreeCADGui.Snapper.setGrid()
issnap = FreeCADGui.Snapper.isEnabled("Grid")
wp = WorkingPlane.get_working_plane() # also updates the grid
sk = FreeCAD.ActiveDocument.addObject("Sketcher::SketchObject", "Sketch")
if issnap and hasattr(sk.ViewObject, "GridSnap"):
s = FreeCAD.ParamGet("User parameter:BaseApp/Preferences/Mod/Draft").GetInt(
"gridSize", 100
)
sk.ViewObject.GridSize = s
sk.ViewObject.GridSnap = True
sk.Placement = wp.get_placement()
sk.MapMode = "Deactivated"
sk.ViewObject.LineColor = params.get_param_view("DefaultShapeLineColor")
sk.ViewObject.PointColor = params.get_param_view("DefaultShapeLineColor")
sk.ViewObject.LineWidth = params.get_param_view("DefaultShapeLineWidth")
sk.Placement = WorkingPlane.get_working_plane().get_placement()
sk.ViewObject.PointSize = params.get_param_view("DefaultShapePointSize")
sk.ViewObject.AutoColor = False
sk.ViewObject.LineColor = params.get_param_view("DefaultShapeLineColor")
sk.ViewObject.PointColor = params.get_param_view("DefaultShapeVertexColor")
sk.ViewObject.ShapeAppearance = [utils.get_view_material()]
if getattr(FreeCADGui, "Snapper", None) and FreeCADGui.Snapper.grid.Visible:
sk.ViewObject.GridSize = Units.Quantity(params.get_param("gridSpacing"))
sk.ViewObject.ShowGrid = True
FreeCADGui.ActiveDocument.setEdit(sk.Name)
FreeCADGui.activateWorkbench("SketcherWorkbench")