kindred/create
1
1
Fork 0
Code Issues 51 Pull Requests 1 Actions 1 Packages Projects 9 Releases 2 Wiki Activity

Gui: Initial save of a document doesn't have the expected thumbnail

Browse Source 
When saving the thumbnail there is a check if the 3D window is the active window. This check fails if a document is saved for the first time because
the appearing file dialog causes the 3D window to not be active any more. Thus, no snapshot of the 3D window will be created and the program logo will be
saved instead. A workaround is to save the document twice.

This PR removes the check for the active window so that the snapshot can be created. The issue might be related to #10937.
This commit is contained in:
wmayer
2023-10-06 14:11:46 +02:00
committed by wwmayer
parent 4388246c01
commit eaeec1b5d0
1 changed files with 6 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/Gui/Thumbnail.cpp
View File

@@ -86,16 +86,14 @@ void Thumbnail::SaveDocFile (Base::Writer &writer) const
if (!this->viewer)
return;
QImage img;
if (this->viewer->isActiveWindow()) {
if (this->viewer->thread() != QThread::currentThread()) {
qWarning("Cannot create a thumbnail from non-GUI thread");
return;
}
QColor invalid;
this->viewer->imageFromFramebuffer(this->size, this->size, 4, invalid, img);
if (this->viewer->thread() != QThread::currentThread()) {
qWarning("Cannot create a thumbnail from non-GUI thread");
return;
}
QColor invalid;
this->viewer->imageFromFramebuffer(this->size, this->size, 4, invalid, img);
// Get app icon and resize to half size to insert in topbottom position over the current view snapshot
QPixmap appIcon = Gui::BitmapFactory().pixmap(App::Application::Config()["AppIcon"].c_str());
QPixmap px = appIcon;