kindred/create
1
1
Fork 0
Code Issues 53 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Merge pull request #24392 from Connor9220/FixToolbitTopo

Browse Source 
CAM: Fix Topo recomputation by only updating when values change in Toolbits
This commit is contained in:
sliptonic
2025-10-03 12:20:10 -05:00
committed by GitHub
parent 10f5cb7479 4a6991b771
commit eba0450647
1 changed files with 11 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/Mod/CAM/Path/Tool/toolbit/models/base.py
View File

@@ -683,7 +683,7 @@ class ToolBit(Asset, ABC):
# Conditional to avoid unnecessary migration warning when called
# from onDocumentRestored.
if value is not None and getattr(self.obj, name) != value:
setattr(self.obj, name, value)
PathUtil.setProperty(self.obj, name, value)
# 2. Add additional properties that are part of the shape,
# but not part of the schema.
@@ -708,7 +708,8 @@ class ToolBit(Asset, ABC):
Path.Log.debug(f"Added custom shape property: {name} ({prop_type})")
# Set the property value
PathUtil.setProperty(self.obj, name, value)
if value is not None and getattr(self.obj, name) != value:
PathUtil.setProperty(self.obj, name, value)
self.obj.setEditorMode(name, 0)
# 3. Ensure SpindleDirection property exists and is set
@@ -725,8 +726,12 @@ class ToolBit(Asset, ABC):
self.obj.SpindleDirection = "Forward" # Default value
spindle_value = self._tool_bit_shape.get_parameters().get("SpindleDirection")
if spindle_value in ("Forward", "Reverse", "None"):
self.obj.SpindleDirection = spindle_value
if (
spindle_value in ("Forward", "Reverse", "None")
and self.obj.SpindleDirection != spindle_value
):
# self.obj.SpindleDirection = spindle_value
PathUtil.setProperty(self.obj, "SpindleDirection", spindle_value)
# 4. Ensure Material property exists and is set
if not hasattr(self.obj, "Material"):
@@ -740,8 +745,8 @@ class ToolBit(Asset, ABC):
self.obj.Material = "HSS" # Default value
material_value = self._tool_bit_shape.get_parameters().get("Material")
if material_value in ("HSS", "Carbide"):
self.obj.Material = material_value
if material_value in ("HSS", "Carbide") and self.obj.Material != material_value:
PathUtil.setProperty(self.obj, "Material", material_value)
def _update_visual_representation(self):
"""