kindred/create
1
1
Fork 0
Code Issues 53 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Toponaming: Remove updateElementReferences call in getLinks methods. (#23525)

Browse Source 
* remove calls to updateElementReferences in getLinks

* add description of the bug for future developers' sake
This commit is contained in:
drwho495
2025-09-07 20:40:47 -05:00
committed by GitHub
parent a62c5b1151
commit edb046d48e
1 changed files with 16 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
src/App/PropertyLinks.cpp
View File

@@ -2082,7 +2082,10 @@ void PropertyLinkSub::getLinks(std::vector<App::DocumentObject*>& objs,
{
if (all || _pcScope != LinkScope::Hidden) {
if (_pcLinkSub && _pcLinkSub->isAttachedToDocument()) {
updateElementReferences(_pcLinkSub);
// we use to run this method everytime the program needed to access the sub-elements in
// a property link, but it caused multiple issues (#23441 and #23402) so it has been
// commented out.
// updateElementReferences(_pcLinkSub);
objs.push_back(_pcLinkSub);
if (subs) {
*subs = getSubValues(newStyle);
@@ -3154,7 +3157,10 @@ void PropertyLinkSubList::getLinks(std::vector<App::DocumentObject*>& objs,
objs.reserve(objs.size() + _lValueList.size());
for (auto obj : _lValueList) {
if (obj && obj->isAttachedToDocument()) {
updateElementReferences(obj);
// we use to run this method everytime the program needed to access the sub-elements in
// a property link, but it caused multiple issues (#23441 and #23402) so it has been
// commented out.
// updateElementReferences(obj);
objs.push_back(obj);
}
}
@@ -4105,8 +4111,6 @@ void PropertyXLink::onContainerRestored()
for (size_t i = 0; i < _SubList.size(); ++i) {
_registerElementReference(_pcLink, _SubList[i], _ShadowSubList[i]);
}
// updateElementReferences(_pcLink);
}
void PropertyXLink::updateElementReference(DocumentObject* feature, bool reverse, bool notify)
@@ -4659,7 +4663,10 @@ void PropertyXLink::getLinks(std::vector<App::DocumentObject*>& objs,
bool newStyle) const
{
if ((all || _pcScope != LinkScope::Hidden) && _pcLink && _pcLink->isAttachedToDocument()) {
updateElementReferences(_pcLink, false);
// we use to run this method everytime the program needed to access the sub-elements in
// a property link, but it caused multiple issues (#23441 and #23402) so it has been
// commented out.
// updateElementReferences(_pcLink, false);
objs.push_back(_pcLink);
if (subs && _SubList.size() == _ShadowSubList.size()) {
*subs = getSubValues(newStyle);
@@ -5394,7 +5401,10 @@ void PropertyXLinkSubList::getLinks(std::vector<App::DocumentObject*>& objs,
for (auto& l : _Links) {
auto obj = l.getValue();
if (obj && obj->isAttachedToDocument()) {
updateElementReferences(obj);
// we use to run this method everytime the program needed to access the sub-elements in
// a property link, but it caused multiple issues (#23441 and #23402) so it has been
// commented out.
// updateElementReferences(obj);
auto subnames = l.getSubValues(newStyle);
if (subnames.empty()) {