Merge pull request #10146 from marioalexis84/app-string_hasher_py

App: Fix crash and undefined behavior in StringHasherPy and StringIDPy

src/Mod/Test/CMakeLists.txt

@@ -5,6 +5,7 @@ SET(Test_SRCS
     BaseTests.py
     Document.py
     Metadata.py
+    StringHasher.py
     Menu.py
     TestApp.py
     TestGui.py

src/Mod/Test/Init.py

@@ -28,5 +28,6 @@ FreeCAD.__unit_test__ += [ "BaseTests",
                            "UnitTests",
                            "Document",
                            "Metadata",
+                           "StringHasher",
                            "UnicodeTests",
                            "TestPythonSyntax" ]

src/Mod/Test/StringHasher.py

@@ -0,0 +1,47 @@
+# SPDX-License-Identifier: LGPL-2.1-or-later
+
+#***************************************************************************
+#*   Copyright (c) 2023 Mario Passaglia <mpassaglia[at]cbc.uba.ar>         *
+#*                                                                         *
+#*   This file is part of FreeCAD.                                         *
+#*                                                                         *
+#*   FreeCAD is free software: you can redistribute it and/or modify it    *
+#*   under the terms of the GNU Lesser General Public License as           *
+#*   published by the Free Software Foundation, either version 2.1 of the  *
+#*   License, or (at your option) any later version.                       *
+#*                                                                         *
+#*   FreeCAD is distributed in the hope that it will be useful, but        *
+#*   WITHOUT ANY WARRANTY; without even the implied warranty of            *
+#*   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU      *
+#*   Lesser General Public License for more details.                       *
+#*                                                                         *
+#*   You should have received a copy of the GNU Lesser General Public      *
+#*   License along with FreeCAD. If not, see                               *
+#*   <https://www.gnu.org/licenses/>.                                      *
+#*                                                                         *
+#**************************************************************************/
+
+import FreeCAD
+import unittest
+
+
+class TestStringHasher(unittest.TestCase):
+    def setUp(self):
+        self.strHash = FreeCAD.StringHasher()
+        self.strID = self.strHash.getID("A")
+
+    def testInit(self):
+        with self.assertRaises(TypeError):
+            FreeCAD.StringHasher(0)
+
+    def testGetID(self):
+        with self.assertRaises(ValueError):
+            self.strHash.getID(0)
+
+    def testStringHasherIsSame(self):
+        with self.assertRaises(TypeError):
+            self.strHash.isSame(0)
+
+    def testStringIDIsSame(self):
+        with self.assertRaises(TypeError):
+            self.strID.isSame(0)