kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Merge pull request #24333 from PaddleStroke/patch-83

Browse Source 
PartDesign: Pocket Through all: Taper should be writable and offset hidden
This commit is contained in:
Chris Hennes
2025-09-30 11:51:52 -05:00
committed by GitHub
parent 5264cb1f9e 6d238a93e1
commit efbe579e25
2 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/Mod/PartDesign/App/FeatureExtrude.cpp
View File

@@ -224,7 +224,7 @@ void FeatureExtrude::updateProperties()
localOffset = true;
}
else if (method == "ThroughAll") {
// No specific length/taper/offset for ThroughAll type
taperVisible = true;
}
};

6
src/Mod/PartDesign/Gui/TaskExtrudeParameters.cpp
View File

@@ -789,7 +789,6 @@ void TaskExtrudeParameters::updateSideUI(const SideController& s,
// Default states for all controls for this side
bool isLengthVisible = false;
bool isOffsetVisible = false;
bool isOffsetEnabled = true;
bool isTaperVisible = false;
bool isFaceVisible = false;
bool isShapeVisible = false;
@@ -804,8 +803,6 @@ void TaskExtrudeParameters::updateSideUI(const SideController& s,
}
}
else if (sideMode == Mode::ThroughAll && featureType == Type::Pocket) {
isOffsetVisible = true;
isOffsetEnabled = false; // "through all" pocket offset doesn't work
isTaperVisible = true;
}
else if (sideMode == Mode::ToLast && featureType == Type::Pad) {
@@ -844,7 +841,7 @@ void TaskExtrudeParameters::updateSideUI(const SideController& s,
const bool finalOffsetVisible = isParentVisible && isOffsetVisible;
s.labelOffset->setVisible(finalOffsetVisible);
s.offsetEdit->setVisible(finalOffsetVisible);
s.offsetEdit->setEnabled(finalOffsetVisible && isOffsetEnabled);
s.offsetEdit->setEnabled(finalOffsetVisible);
const bool finalTaperVisible = isParentVisible && isTaperVisible;
s.labelTaperAngle->setVisible(finalTaperVisible);
@@ -1456,3 +1453,4 @@ bool TaskDlgExtrudeParameters::reject()