kindred/create
1
1
Fork 0
Code Issues 53 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Sheet: Verify that UnitExpression is valid

Browse Source 
The crash happens because the UnitExpression is null and thus segfaults when trying to access the unit and scalar value.
This fixes https://github.com/FreeCAD/FreeCAD/issues/23222
This commit is contained in:
wmayer
2025-08-20 10:15:08 +02:00
parent 564e79b890
commit f5cfd3d64c
1 changed files with 11 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/Mod/Spreadsheet/Gui/PropertiesDialog.cpp
View File

@@ -221,12 +221,19 @@ void PropertiesDialog::displayUnitChanged(const QString& text)
QPalette palette = ui->displayUnit->palette();
try {
std::unique_ptr<UnitExpression> e(
std::unique_ptr<UnitExpression> expr(
App::ExpressionParser::parseUnit(sheet, text.toUtf8().constData()));
displayUnit = DisplayUnit(text.toUtf8().constData(), e->getUnit(), e->getScaler());
palette.setColor(QPalette::Text, Qt::black);
displayUnitOk = true;
if (expr) {
displayUnit = DisplayUnit(text.toStdString(), expr->getUnit(), expr->getScaler());
palette.setColor(QPalette::Text, Qt::black);
displayUnitOk = true;
}
else {
displayUnit = DisplayUnit();
palette.setColor(QPalette::Text, text.size() == 0 ? Qt::black : Qt::red);
displayUnitOk = false;
}
}
catch (...) {
displayUnit = DisplayUnit();