kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Part: Geometry and Sketcher: GeometryFacade and ExternalGeometryFacade

Browse Source 
======================================================================

Change pass-by-value to const reference.

Thanks Kunda!

https://lgtm.com/projects/g/FreeCAD/FreeCAD/alerts/?mode=tree&ruleFocus=2163210742
https://forum.freecadweb.org/viewtopic.php?p=555658#p555658
This commit is contained in:
Abdullah Tahiri
2021-12-22 18:51:45 +01:00
committed by abdullahtahiriyo
parent 6c019ac93f
commit f7dec6b601
4 changed files with 25 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/Mod/Part/App/Geometry.cpp
View File

@@ -298,7 +298,7 @@ bool Geometry::hasExtension(Base::Type type) const
return false;
}
bool Geometry::hasExtension(std::string name) const
bool Geometry::hasExtension(const std::string & name) const
{
for( auto ext : extensions) {
if(ext->getName() == name)
@@ -318,7 +318,7 @@ std::weak_ptr<GeometryExtension> Geometry::getExtension(Base::Type type)
throw Base::ValueError("No geometry extension of the requested type.");
}
std::weak_ptr<GeometryExtension> Geometry::getExtension(std::string name)
std::weak_ptr<GeometryExtension> Geometry::getExtension(const std::string & name)
{
for( auto ext : extensions) {
if(ext->getName() == name)
@@ -333,7 +333,7 @@ std::weak_ptr<const GeometryExtension> Geometry::getExtension(Base::Type type) c
return const_cast<Geometry*>(this)->getExtension(type).lock();
}
std::weak_ptr<const GeometryExtension> Geometry::getExtension(std::string name) const
std::weak_ptr<const GeometryExtension> Geometry::getExtension(const std::string & name) const
{
return const_cast<Geometry*>(this)->getExtension(name).lock();
}
@@ -371,7 +371,7 @@ void Geometry::deleteExtension(Base::Type type)
extensions.end());
}
void Geometry::deleteExtension(std::string name)
void Geometry::deleteExtension(const std::string & name)
{
extensions.erase(
std::remove_if( extensions.begin(),

8
src/Mod/Part/App/Geometry.h
View File

@@ -99,14 +99,14 @@ public:
std::vector<std::weak_ptr<const GeometryExtension>> getExtensions() const;
bool hasExtension(Base::Type type) const;
bool hasExtension(std::string name) const;
bool hasExtension(const std::string & name) const;
std::weak_ptr<const GeometryExtension> getExtension(Base::Type type) const;
std::weak_ptr<const GeometryExtension> getExtension(std::string name) const;
std::weak_ptr<const GeometryExtension> getExtension(const std::string & name) const;
std::weak_ptr<GeometryExtension> getExtension(Base::Type type);
std::weak_ptr<GeometryExtension> getExtension(std::string name);
std::weak_ptr<GeometryExtension> getExtension(const std::string & name);
void setExtension(std::unique_ptr<GeometryExtension> &&geo);
void deleteExtension(Base::Type type);
void deleteExtension(std::string name);
void deleteExtension(const std::string & name);
void mirror(const Base::Vector3d& point);
void mirror(const Base::Vector3d& point, const Base::Vector3d& dir);

18
src/Mod/Sketcher/App/ExternalGeometryFacade.h
View File

@@ -131,19 +131,19 @@ public:
std::vector<std::weak_ptr<const Part::GeometryExtension>> getExtensions() const {return getGeo()->getExtensions();};
bool hasExtension(Base::Type type) const {return getGeo()->hasExtension(type);};
bool hasExtension(std::string name) const {return getGeo()->hasExtension(name);};
bool hasExtension(const std::string & name) const {return getGeo()->hasExtension(name);};
std::weak_ptr<const Part::GeometryExtension> getExtension(Base::Type type) const {return getGeo()->getExtension(type);};
std::weak_ptr<const Part::GeometryExtension> getExtension(std::string name) const {return getGeo()->getExtension(name);};
std::weak_ptr<const Part::GeometryExtension> getExtension(const std::string & name) const {return getGeo()->getExtension(name);};
void setExtension(std::unique_ptr<Part::GeometryExtension> &&geo) {return getGeo()->setExtension(std::move(geo));};
void deleteExtension(Base::Type type) {return getGeo()->deleteExtension(type);};
void deleteExtension(std::string name) {return getGeo()->deleteExtension(name);};
void deleteExtension(const std::string & name) {return getGeo()->deleteExtension(name);};
void mirror(Base::Vector3d point) {return getGeo()->mirror(point);};
void mirror(Base::Vector3d point, Base::Vector3d dir) {return getGeo()->mirror(point, dir);};
void rotate(Base::Placement plm) {return getGeo()->rotate(plm);};
void scale(Base::Vector3d vec, double scale) {return getGeo()->scale(vec, scale);};
void transform(Base::Matrix4D mat) {return getGeo()->transform(mat);};
void translate(Base::Vector3d vec) {return getGeo()->translate(vec);};
void mirror(const Base::Vector3d & point) {return getGeo()->mirror(point);};
void mirror(const Base::Vector3d & point, Base::Vector3d dir) {return getGeo()->mirror(point, dir);};
void rotate(const Base::Placement & plm) {return getGeo()->rotate(plm);};
void scale(const Base::Vector3d & vec, double scale) {return getGeo()->scale(vec, scale);};
void transform(const Base::Matrix4D & mat) {return getGeo()->transform(mat);};
void translate(const Base::Vector3d & vec) {return getGeo()->translate(vec);};
private:
void initExtensions(void);

16
src/Mod/Sketcher/App/GeometryFacade.h
View File

@@ -189,19 +189,19 @@ public:
std::vector<std::weak_ptr<const Part::GeometryExtension>> getExtensions() const {return getGeo()->getExtensions();}
bool hasExtension(Base::Type type) const {return getGeo()->hasExtension(type);}
bool hasExtension(std::string name) const {return getGeo()->hasExtension(name);}
bool hasExtension(const std::string & name) const {return getGeo()->hasExtension(name);}
std::weak_ptr<const Part::GeometryExtension> getExtension(Base::Type type) const {return getGeo()->getExtension(type);}
std::weak_ptr<const Part::GeometryExtension> getExtension(std::string name) const {return getGeo()->getExtension(name);}
void setExtension(std::unique_ptr<Part::GeometryExtension> &&geo) {return getGeo()->setExtension(std::move(geo));}
void deleteExtension(Base::Type type) {return getGeo()->deleteExtension(type);}
void deleteExtension(std::string name) {return getGeo()->deleteExtension(name);}
void deleteExtension(const std::string & name) {return getGeo()->deleteExtension(name);}
void mirror(Base::Vector3d point) {return getGeo()->mirror(point);}
void mirror(Base::Vector3d point, Base::Vector3d dir) {return getGeo()->mirror(point, dir);}
void rotate(Base::Placement plm) {return getGeo()->rotate(plm);}
void scale(Base::Vector3d vec, double scale) {return getGeo()->scale(vec, scale);}
void transform(Base::Matrix4D mat) {return getGeo()->transform(mat);}
void translate(Base::Vector3d vec) {return getGeo()->translate(vec);}
void mirror(const Base::Vector3d & point) {return getGeo()->mirror(point);}
void mirror(const Base::Vector3d & point, Base::Vector3d dir) {return getGeo()->mirror(point, dir);}
void rotate(const Base::Placement & plm) {return getGeo()->rotate(plm);}
void scale(const Base::Vector3d & vec, double scale) {return getGeo()->scale(vec, scale);}
void transform(const Base::Matrix4D & mat) {return getGeo()->transform(mat);}
void translate(const Base::Vector3d & vec) {return getGeo()->translate(vec);}
// convenience GeometryFunctions
bool isGeoType(const Base::Type &type) const { return getGeo()->getTypeId() == type;}