[Part]code review changes for FeatureScale

This commit is contained in:
wandererfan
2023-09-07 09:42:49 -04:00
committed by wwmayer
parent 9905572116
commit fa840560c2
4 changed files with 4 additions and 13 deletions

View File

@@ -127,7 +127,7 @@ TopoShape Scale::nonuniformScale(const TopoShape& source, const Scale::ScalePara
mat.SetValue(3,4,matScale[2][3]);
// this copy step seems to eliminate Part.OCCError: gp_GTrsf::Trsf() - non-orthogonal GTrsf
// which may to be related to the tesselation of the input shape. See Github issue #9651
// which may to be related to the tessellation of the input shape. See Github issue #9651
// for more detail.
BRepBuilderAPI_Copy copier(source.getShape());
TopoShape transTopo;

View File

@@ -49,11 +49,10 @@ public:
/**
* @brief The ScaleParameters struct is supposed to be filled with final
* scale parameters, after resolving links, applying mode logic,
* reversing, etc., and be passed to scaleShape.
* scale parameters and be passed to scaleShape.
*/
struct ScaleParameters {
bool uniform;
bool uniform{true};
double uniformScale{1.0};
double XScale{1.0};
double YScale{1.0};

View File

@@ -70,14 +70,6 @@ DlgScale::DlgScale(QWidget* parent, Qt::WindowFlags fl)
findShapes();
}
/*
* Destroys the object and frees any allocated resources
*/
DlgScale::~DlgScale()
{
// no need to delete child widgets, Qt does it all for us
}
void DlgScale::setupConnections()
{
connect(ui->rbUniform, &QRadioButton::toggled,

View File

@@ -41,7 +41,7 @@ class DlgScale : public QDialog
public:
DlgScale(QWidget* parent = nullptr, Qt::WindowFlags fl = Qt::WindowFlags());
~DlgScale() override;
~DlgScale() = default;
void accept() override;
void apply();
void reject() override;