kindred/create
1
1
Fork 0
Code Issues 30 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

[Spreadsheet] dialog fixes

Browse Source 
- fixes to tooltips
- add 2 labels to make the dialog logic more clear
- remove non-functional help button
This commit is contained in:
Uwe
2022-06-06 00:46:42 +02:00
parent 928c86d42d
commit ff467f8115
2 changed files with 114 additions and 64 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/Mod/Spreadsheet/Gui/DlgBindSheet.cpp
View File

@@ -40,6 +40,8 @@ DlgBindSheet::DlgBindSheet(Sheet *sheet, const std::vector<Range> &ranges, QWidg
: QDialog(parent), sheet(sheet), range(ranges.front()), ui(new Ui::DlgBindSheet)
{
ui->setupUi(this);
// remove the automatic help button in dialog title since we don't use it
setWindowFlag(Qt::WindowContextHelpButtonHint, false);
std::string toStart,toEnd;
ExpressionPtr pStart, pEnd;

176
src/Mod/Spreadsheet/Gui/DlgBindSheet.ui
View File

@@ -6,84 +6,132 @@
<rect>
<x>0</x>
<y>0</y>
<width>387</width>
<height>176</height>
<width>257</width>
<height>167</height>
</rect>
</property>
<property name="windowTitle">
<string>Bind Spreadsheet Cells</string>
</property>
<layout class="QGridLayout" name="gridLayout">
<item row="0" column="0">
<widget class="QLabel" name="label_2">
<property name="text">
<string>From cells:</string>
</property>
</widget>
<layout class="QVBoxLayout" name="verticalLayout">
<item>
<layout class="QGridLayout" name="gridLayout">
<item row="0" column="1">
<widget class="QLabel" name="label_4">
<property name="text">
<string>First cell in range</string>
</property>
</widget>
</item>
<item row="0" column="2">
<widget class="QLabel" name="label_5">
<property name="text">
<string>Last cell in range</string>
</property>
</widget>
</item>
<item row="1" column="0">
<widget class="QLabel" name="label_2">
<property name="text">
<string>From cells:</string>
</property>
</widget>
</item>
<item row="1" column="1">
<widget class="QLineEdit" name="lineEditFromStart">
<property name="sizePolicy">
<sizepolicy hsizetype="Preferred" vsizetype="Fixed">
<horstretch>0</horstretch>
<verstretch>0</verstretch>
</sizepolicy>
</property>
<property name="toolTip">
<string>Start cell address</string>
</property>
</widget>
</item>
<item row="1" column="2">
<widget class="QLineEdit" name="lineEditFromEnd">
<property name="sizePolicy">
<sizepolicy hsizetype="Preferred" vsizetype="Fixed">
<horstretch>0</horstretch>
<verstretch>0</verstretch>
</sizepolicy>
</property>
<property name="toolTip">
<string>End cell address</string>
</property>
</widget>
</item>
<item row="2" column="0">
<widget class="QLabel" name="label_3">
<property name="text">
<string>To cells:</string>
</property>
</widget>
</item>
<item row="2" column="1">
<widget class="Gui::ExpressionLineEdit" name="lineEditToStart">
<property name="sizePolicy">
<sizepolicy hsizetype="Preferred" vsizetype="Fixed">
<horstretch>0</horstretch>
<verstretch>0</verstretch>
</sizepolicy>
</property>
<property name="toolTip">
<string>Start cell address to bind to.
Type '=' if you want to use an expression.
The expression must evaluate to a string of some cell address.</string>
</property>
</widget>
</item>
<item row="2" column="2">
<widget class="Gui::ExpressionLineEdit" name="lineEditToEnd">
<property name="sizePolicy">
<sizepolicy hsizetype="Preferred" vsizetype="Fixed">
<horstretch>0</horstretch>
<verstretch>0</verstretch>
</sizepolicy>
</property>
<property name="toolTip">
<string>End cell address to bind to.
Type '=' if you want to use an expression.
The expression must evaluate to a string of some cell address.</string>
</property>
</widget>
</item>
</layout>
</item>
<item row="0" column="1">
<widget class="QLineEdit" name="lineEditFromStart">
<property name="toolTip">
<string>Binding cell range start</string>
</property>
</widget>
<item>
<layout class="QFormLayout" name="formLayout">
<item row="0" column="1">
<widget class="QComboBox" name="comboBox">
<property name="toolTip">
<string>Which spread sheet to bind to</string>
</property>
</widget>
</item>
<item row="0" column="0">
<widget class="QLabel" name="label">
<property name="text">
<string>Sheet:</string>
</property>
</widget>
</item>
</layout>
</item>
<item row="0" column="2">
<widget class="QLineEdit" name="lineEditFromEnd">
<property name="toolTip">
<string>Binding cell range end
</string>
</property>
</widget>
</item>
<item row="1" column="0">
<widget class="QLabel" name="label_3">
<property name="text">
<string>To cells:</string>
</property>
</widget>
</item>
<item row="1" column="1">
<widget class="Gui::ExpressionLineEdit" name="lineEditToStart">
<property name="toolTip">
<string>Starting cell address to bind to. Type '=' if you want to use expression.
The expression must evaluates to a string of some cell address.</string>
</property>
</widget>
</item>
<item row="1" column="2">
<widget class="Gui::ExpressionLineEdit" name="lineEditToEnd">
<property name="toolTip">
<string>Ending cell address to bind to. Type '=' if you want to use expression.
The expression must evaluates to a string of some cell address.</string>
</property>
</widget>
</item>
<item row="2" column="0">
<widget class="QLabel" name="label">
<property name="text">
<string>Sheet:</string>
</property>
</widget>
</item>
<item row="2" column="1" colspan="2">
<widget class="QComboBox" name="comboBox">
<property name="toolTip">
<string>Select which spread sheet to bind to.</string>
</property>
</widget>
</item>
<item row="3" column="1" colspan="2">
<item>
<widget class="QCheckBox" name="checkBoxHREF">
<property name="toolTip">
<string>Use hidden reference to avoid creating a dependency with the referenced object. Use with caution!</string>
<string>Use hidden reference to avoid creating a dependency
with the referenced object. Use with caution!</string>
</property>
<property name="text">
<string>Use hidden reference</string>
</property>
</widget>
</item>
<item row="4" column="1" colspan="2">
<item>
<layout class="QHBoxLayout" name="horizontalLayout_5">
<item>
<widget class="QPushButton" name="btnDiscard">
@@ -111,7 +159,7 @@ The expression must evaluates to a string of some cell address.</string>
</item>
</layout>
</item>
</layout>
</layout>
</widget>
<customwidgets>
<customwidget>