Commit Graph

18012 Commits

Author SHA1 Message Date
wmayer
00c016a967 fix bug in Path module: str has no attribute UserString 2019-09-01 22:14:53 +02:00
Yorik van Havre
679f7e91c7 Draft: Added shortcut to toggle near snap during drawing 2019-09-01 13:00:57 -03:00
wmayer
598faf9ad2 include missing header 2019-09-01 17:25:42 +02:00
luz.paz
0641ca0d1e AddonManager: Add BCFPlugin Workbench logo to dialog 2019-08-30 15:57:12 +02:00
KeithSloan
62d85f4491 Fix OpenSCAD Frustrum 2019-08-30 15:55:15 +02:00
Zheng, Lei
70857e17e0 Sketcher: fix missing update on expression change 2019-08-30 15:52:31 +02:00
Zheng, Lei
f66e7f3332 App: remove unused variable 2019-08-30 15:52:18 +02:00
Zheng, Lei
9bf21592ce Gui: add warning to DlgExpressionInput
Warn when binding expression with unit to unit-less properties.
2019-08-30 15:52:03 +02:00
Zheng, Lei
813358da05 Gui: restore static property order in PropertyView 2019-08-30 15:51:47 +02:00
Zheng, Lei
4f383de1f5 App: ignore unit in PropertyBool/Float/Integer
In other word, those property now accept expression result with a unit,
by ignoring it.
2019-08-30 15:50:26 +02:00
Zheng, Lei
9ec86fad4e App: improve exception message in PropertyExpressionEngine 2019-08-30 15:50:13 +02:00
Zheng, Lei
f7d416d15e Gui: auto close transaction on Document resetEdit 2019-08-30 15:49:59 +02:00
Zheng, Lei
02df227c1c App: fix virtual function shadowing in PropertyXLinkSub 2019-08-30 15:49:41 +02:00
Zheng, Lei
732a2ee55a Gui: fix PythonWrapper::fromQIcon() 2019-08-30 15:47:39 +02:00
Zheng, Lei
193b9899b6 Part: fix missing signal disconnect in TaskFaceColors 2019-08-30 15:47:17 +02:00
Zheng, Lei
69268ce7f4 Base: fix pyCall() exception
This function is wildly used in FeaturePython and
ViewProviderPythonFeature, which explicitly catches Py::Exception, not
Base::Exception. So pyCall() should throw Py::Exception, too.
2019-08-30 15:47:04 +02:00
Zheng, Lei
31273bc1c6 App: more sanity check in PropertyContainerPy 2019-08-30 15:46:47 +02:00
Zheng, Lei
783d218b1d App: more sanity check in ObjectIdentifier 2019-08-30 15:46:33 +02:00
Zheng, Lei
9aaad3b1d2 Gui: fix ViewProviderLink dropObjectEx() 2019-08-30 15:46:10 +02:00
Zheng, Lei
0cb599a31c App: do not return null Shape in PropertyContainerPy 2019-08-30 15:45:58 +02:00
Zheng, Lei
04d678571c App: fix Python object leak in ObjectIdentifier 2019-08-30 15:45:44 +02:00
Zheng, Lei
88a1a9482e App: fix crash on accessing non-existent attribute in ObjectIdentifier 2019-08-30 15:45:28 +02:00
Zheng, Lei
f0cb6d5885 Gui: fix GeoFeatureGroupExtension
The change in ViewProviderGeoFeatureGroupExtension.claimChildren() is
so that GeoFeatureGroupExtension.getSubObjects() can exclude non direct
children.
2019-08-30 15:45:21 +02:00
Zheng, Lei
7bf451fc67 Gui/PartDesign: fix setActiveObject() for Part and Body 2019-08-30 15:02:48 +02:00
Zheng, Lei
be320a8733 Gui: more exception handling in tree view 2019-08-30 15:01:25 +02:00
Zheng, Lei
4efbe3c5d0 Gui: add View3DPy.hasClippingPlane() 2019-08-30 15:00:42 +02:00
Zheng, Lei
66a719773f Sketcher: fix lost of constraint in undo/redo 2019-08-30 14:57:41 +02:00
Zheng, Lei
2c2aadaa5d Draft/Arch: maintain Python 2 compatibility
In order to pass test under Python 2
2019-08-30 14:56:18 +02:00
Zheng, Lei
d16cd4f631 App: fix Document::_abortTransaction() 2019-08-30 14:55:49 +02:00
Zheng, Lei
d2c5bcb949 Part: fix VBO update on multiple gl context
Multiple OpenGL context is caused by linking some shape object from
external documents. The VBO update must be triggered for all contexts.
2019-08-30 14:55:14 +02:00
Zheng, Lei
350c5982db Show: remove debug print 2019-08-30 14:54:20 +02:00
Zheng, Lei
a06e0b7c2d Part: fix TaskAttacher external editing 2019-08-30 14:53:50 +02:00
Zheng, Lei
c7d4e240e8 PartDesign: fix datum edit through external link 2019-08-30 14:53:03 +02:00
Zheng, Lei
ec3541ae79 Gui: handle exception in tree view double click 2019-08-30 14:52:09 +02:00
Zheng, Lei
3e0cfb4ba5 Gui: fix ExpressionCompleter for property 2019-08-30 14:51:33 +02:00
Zheng, Lei
8e2a059e70 Gui: fix tree view document double click activating 2019-08-30 14:50:52 +02:00
Zheng, Lei
b39771aa84 Gui: use ExpressionLineEdit for tree view object search
Tree view is already using expression for object search. This patch
adds the expression completer feature for search result suggestion.
2019-08-30 14:50:15 +02:00
Zheng, Lei
c2c6053e71 Gui: improve expression completer
Proper support of completing an edit in the middel of an expression.

Also support 'noProperty' mode in the completer, where no completion is
offered for property names. This will be used by tree view object
search.
2019-08-30 14:49:14 +02:00
Zheng, Lei
278e933527 App: allow starting '_' in an expression identifier
It's a signle line change in the flex source, bug a big change in the
generated source.
2019-08-30 14:47:53 +02:00
Zheng, Lei
5bef136deb TechDraw: avoid touching children if possible
There are lots of dependency inversion problem in TechDraw, the ideal
organization should let a child depend on project group, instead of the
other way round, e.g. using PropertyLinkListHidden.

This patch is just a cheap fix. The problem occurs when the user uses
any expression to update properties like Scale in a projection group.
The Scale property will be changed on recomputing projection group,
which triggers children update, but since the group depends on the
children, the children has already been recomputed.
2019-08-30 14:47:05 +02:00
Zheng, Lei
2b79025ad9 Part: avoid touching in ViewProviderAttachExtension mergeOverlayIcons
ViewProviderAttachExtension::extensionMergeOverlayIcons() calls
AttachExtension::positionBySupport() which will always touch the
extended object. This may cause recomputation problems, e.g a datum
that is always touched, because normal recomputation trigger tree
view update by a timer, tree view refreshes the icon, datum gets
touched again.
2019-08-30 14:46:38 +02:00
Zheng, Lei
030f00e7cf Gui: expose link command to global toolbar 2019-08-30 14:43:32 +02:00
Zheng, Lei
848fbf6035 Gui: allow SelectionSingleton::hasSubSelection() check for sub-element
This is used by relative link command activation for sub-element
selection
2019-08-30 14:43:04 +02:00
Zheng, Lei
9d03d7caa9 App: fix LinkBaseExtension::extensionGetSubObject()
This fix obtain shape from a link to a sub element
2019-08-30 14:42:19 +02:00
Zheng, Lei
b78f1a5111 App: make recompute aborting optional 2019-08-30 14:41:46 +02:00
Zheng, Lei
75385d7f34 App: prevent recursive abort/commitTransaction 2019-08-30 14:35:23 +02:00
Zheng, Lei
c2254a64aa Gui: expose MainWindow:showStatus()
Tree view now uses this to show error on hovering over object in error.
2019-08-30 14:33:31 +02:00
Zheng, Lei
ddb17b23b0 Gui: fix property editor crash on recompute
The actual cause of crash in previous commit 80f70ff6 is
Document::recompute() allows aborting using Base::Sequence, which
uses QApplication::processEvent() to catch 'ESC' key press. This local
event loop causes premature deletion of the editor widget.

This patch moves handling of closeEditor before calling recompute().
2019-08-30 14:25:41 +02:00
Zheng, Lei
378314aafb Gui: try to fix property editor crash
Crash stack trace
https://forum.freecadweb.org/viewtopic.php?f=8&t=37757&e=1&view=unread#p327901

It appears to by caused by handling QAbstractItemDelegate::closeEditor
signal twice. Once inside PropertyItemDelegate::editorClosed via slot
connection where the editor is closed/destroyed, the other in
PropertyEditor::closeEditor() which tries to access the destroyed
editor.

This patch removes handling of closeEditor signal in
PropertyItemDelegate.
2019-08-30 13:55:24 +02:00
Zheng, Lei
24b1467a55 Draft: disable implicit property linking in LinkArray 2019-08-30 13:35:25 +02:00