Commit Graph

23018 Commits

Author SHA1 Message Date
Russell Johnson
01fa1fecd8 Path: Organize rotational code in areaOpShapes() method
Relocate the rotational analysis code into smaller independent methods to allow for easier maintenance and support.
Commented out recently added debug object creation statement.
2020-11-13 16:34:59 -06:00
Russell Johnson
c03a0bba62 Path: Fix and cleanup removal shape creation code
The `isFaceUp()` method in the PathAreaOp module was returning false results in some instances.
Rotational code has been consolidated and better organized to fix certain errors reported in the forum.
Overall, this code section has been better organized as a part of the necessary fixes.
2020-11-13 16:34:59 -06:00
Russell Johnson
7fb8f1149a Path: Improve accuracy of isFaceUp() method
This method is used in rotational operations and some standard operations to identify if a face's normal-direction Z value is +1.0
2020-11-13 16:07:18 -06:00
Russell Johnson
c357cb77a1 Path: Remove null comments and improve debugging
Added method to create a FreeCAD object when in debug mode.
2020-11-13 16:07:18 -06:00
sliptonic
9c49dc595f Merge pull request #3989 from Russ4262/Surface_fixes
Path: 3D Surface fix to apply `CutMode` when `CutPattern = Offset`; and LGTM cleanup
2020-11-13 14:25:19 -06:00
wmayer
b7d763a1c4 PartDesign: [skip ci] make cut type modes of hole feature translatable 2020-11-13 17:51:41 +01:00
donovaly
4246c902a5 [PD] fix issue 3968
https://tracker.freecadweb.org/view.php?id=3968

Don't set the tip to features that cannot hold the tip
2020-11-13 17:03:19 +01:00
wmayer
a48dd3aa2c Part: [skip ci] rearrange line page to save some vertical space 2020-11-13 15:35:07 +01:00
donovaly
f8ac3ea14a [Part] remove unnecessary vertical whitespace in dialogs
on smaller screens it is very annoying that the Part dialogs have too much vertical whitespace.

This PR gets rid of some unnecessary whitespace.
2020-11-13 13:52:31 +01:00
donovaly
a58c4736a2 [PD] add measure tools
use Part's measure tools also for PartDesign
2020-11-13 12:38:42 +01:00
donovaly
922815df57 [Part] improve tube dialog
- remove vertical whitespace
2020-11-13 12:37:57 +01:00
wmayer
64288425a2 Part: [skip ci] show dialog directly when creating a tube feature 2020-11-13 12:33:59 +01:00
marioalexis
2b2524451e Draft: Fixes #0004293: Vertical dimensions can't be created in XZ and YZ working plane 2020-11-13 10:58:34 +01:00
donovaly
e7af8b5c01 [PD] hole UTS fixes
- propose cut values also for UTS profiles
- the UTS defines coarse and fine while for ISO it is regular and fine, thus fix the name
- for the dialog: set minimum values to zero (angles etc. cannot be negative)
2020-11-13 09:07:27 +01:00
donovaly
68673c6ad1 [PD] more hole cut work
- add definitions for IS 2009, 7046 and 12474
- remove useless file for a ISO 14583 since there are no such screws on the market
- rename "coarse" to "regular" since this what it actually is according to the norms
- uniform the x1 threads (for x2.0 etc we use a trailing zero and for some we use x1, for some already x1.0, thus consistently use x1.0)
- add some ISO 10642 entries
- correct ISO 4762:
  - correct some values
  - the does does not define a size M27
  - add the two missing sizes
2020-11-12 17:41:53 +01:00
M G Berberich
04be99a2aa cut-profiles with identical names for different threads
Allow cut-profiles with identical names for different threads.
see:
https://forum.freecadweb.org/viewtopic.php?f=19&t=51491&start=60#p446854
https://forum.freecadweb.org/viewtopic.php?f=19&t=51491&start=60#p446902
2020-11-12 17:38:18 +01:00
Jean-Marie Verdun
175c870e8c Gentle exit only if gtimeout reached end of time as to fill up build cache
Signed-off-by: Jean-Marie Verdun <jmverdun3@gmail.com>
2020-11-12 17:36:26 +01:00
sliptonic
f31493153f Merge pull request #4038 from daveseff/pathworks
Pathworks
2020-11-12 10:08:48 -06:00
wmayer
812125931e Part: [skip ci] implement editor dialog for tube feature 2020-11-12 16:45:38 +01:00
wmayer
ba3106af06 Part: [skip ci] make sure to open a transaction when starting edit mode of primitives via context-menu 2020-11-12 16:35:58 +01:00
wmayer
b5608611a4 App: [skip ci] expose functions to Python to get status string of a feature and whether it's valid 2020-11-12 15:46:40 +01:00
Bernd Hahnebach
475668638a AddOn: manager, clone repos default branch instead of the master 2020-11-12 13:33:00 +01:00
wmayer
cdc8b3c777 Part: [skip ci] split classes of Shapes.py file into files for feature, view provider and command classes 2020-11-12 12:17:47 +01:00
Dave Seff
139fac133f Make the tool setup images a bit nicer. 2020-11-12 16:59:22 +10:00
Bernd Hahnebach
cdc01cb20c FEM: elmer solver, add newline in output 2020-11-11 16:52:16 +01:00
sliptonic
1c618a822c Merge pull request #4034 from dubstar-04/PathTurnRoughingSel
[Path] Update Turning Selection Gates
2020-11-11 09:21:21 -06:00
wmayer
b7f9e351c5 Win: [skip ci] check if NOMINMAX is already defined before setting it 2020-11-11 13:34:42 +01:00
Daniel Wood
0392ca9b79 [Path] rename TurnPart to TurnPartoff 2020-11-11 08:44:09 +00:00
luz paz
1b8f4747e6 femtest/test_information.md: tweaks
Tweaked the markdown
2020-11-10 23:20:29 +01:00
luz paz
484693c1d8 FEM: remove superfluous 'pass'
Fixes LGTM alert  
Per the documentation:  
```
A 'pass' statement is only necessary when it is the only statement in a block (the list of statements forming part of a compound statement). This is because the purpose of the 'pass' statement is to allow empty blocks where they would otherwise be syntactically invalid. If the block already contains other statements then the 'pass' statement is unnecessary.
```
2020-11-10 23:20:23 +01:00
wmayer
f9420c9877 Part: [skip ci] simplifications in primitives location dialog
- do not use a QSignalMapper if the slot doesn't take care of the emitting widget
- to set the placement only check for the base class GeoFeature, i.e. no need to step through all primitive types
- fix compiler warning of unused variable
2020-11-10 20:20:33 +01:00
donovaly
f0af88ecae [Part] add preview for changes to primitives location
- unset keyboardTracking for the dialog edits
- don't hide the location dialog on creation
2020-11-10 20:03:08 +01:00
wmayer
bdcbf316b9 PartDesign: [skip ci] fix whitespaces 2020-11-10 19:39:44 +01:00
donovaly
ea08a660eb [PD] hole creation
- propose valid values for the cut depth and diameter when creating new holes
- add new definitions for metric fine
- some code simplification and comments
2020-11-10 19:34:53 +01:00
Yorik van Havre
e26a9efae8 Arch: Added Awming window preset 2020-11-10 19:14:06 +01:00
Yorik van Havre
e76c857036 Merged crowdin translations 2020-11-10 14:58:06 +01:00
Yorik van Havre
f76eeddfcb Updated ts files 2020-11-10 14:47:48 +01:00
Yorik van Havre
413d315d37 Draft: Change WP button icon to reflect current state 2020-11-10 14:45:44 +01:00
Yorik van Havre
88f5fc20b1 Draft: Condensed the Draft toolbar style buttons into one with more options 2020-11-10 14:14:18 +01:00
Abdullah Tahiri
485b0b58a0 Sketcher: GeometryFacade inheritance correctness
- Make explicit private inheritance of the interface
- Correct inheritance of ExternalGeometryFacade
- Correct inheritance of ExternalGeometryExtension
- Better document the inheritance choice
2020-11-10 13:35:11 +01:00
Daniel Wood
8713916658 [Path] Add Turning Roughing Selection 2020-11-09 21:14:19 +00:00
Bernd Hahnebach
645535234a Material: fix open material editor with empty material, regression was added with commit 0f87516 2020-11-09 19:29:55 +01:00
wmayer
59c50053a6 MSVC: [skip ci] make working with C++17 compiler 2020-11-09 16:13:34 +01:00
donovaly
08efd286df [Sketch] add missing menu entry for new feature 2020-11-09 16:12:27 +01:00
wmayer
6b9178e0b3 Part: [skip ci] correctly show control points of a B-spline/Bezier curve/surface if a placement is set 2020-11-09 13:14:31 +01:00
marioalexis
3f5caddabf Draft: Enable offset for working plane aligned with current view 2020-11-09 12:42:18 +01:00
marioalexis
a36fb60653 Draft: Improve archDimTracker class 2020-11-09 12:39:19 +01:00
marioalexis
ef2d4f2989 Draft: Fixes in gui_offset 2020-11-09 12:37:56 +01:00
Roy-043
97828f0ba8 Update dxf.cpp
Fixed wrong DXF scale factor for inches. 1/25.4 was wrongly used,
2020-11-09 12:35:14 +01:00
Roy-043
5f63f3ae71 Update dxf.cpp
Fixed wrong Inch scale factor. 1/25.4 was wrongly used.
2020-11-09 12:35:14 +01:00