Commit Graph

27 Commits

Author SHA1 Message Date
Russell Johnson
022c14d75b 4th-axis fixes and improvements
Fix rotational orientation of pockets.  Need to apply same fix to ProfileFaces.
Fix final depth issue based upon error in rotational orientation fixed here.
Add property, `LimitDepthToFace` to facilitate easier pockets and face profiling on rotational-enabled operations.
Hide rotational support properties when operations do not use rotation.
Remove unnecessary property, `B_AxisErrorOverride`, and delete dead code that used it.
2020-03-14 11:36:21 -05:00
Patrick Felixberger
c094889aac Fixed broken final depth calculation for rotational axis in pocket, profile and drill; Added EnableRotation to GUI; Fix some weird gcode generation 2020-03-11 21:16:21 +01:00
Markus Lampert
81f809cfcf Removed dead code for debugging shortcut warnings. 2020-01-03 23:13:55 -08:00
Russell Johnson
f2221e8d5a ProfileFaces: fix "HandleMultipleFeatures" set to individually
Summary condition produced error and no paths; corrected subshape passed to getEnvelope().
Removed unnecessary comments.
Simplified debug level setting.
2019-07-25 14:54:22 -05:00
Markus Lampert
71994e55fa Addressed pylint warnings for PathProfileFaces 2019-07-01 15:32:54 -07:00
Markus Lampert
80e991a056 addressing pylint warnings for PathProfile family 2019-07-01 15:32:54 -07:00
Russell Johnson
3132dfbf54 ProfileFaces: Fix obj.processPerimeter feature (#2306)
https://forum.freecadweb.org/viewtopic.php?f=15&t=37368
if obj.processPerimeter: `else` block re-configured to read new property, `HandleMultipleFeatures`
Removed some excess comments
2019-06-30 09:31:30 -05:00
sliptonic
b55c210f39 remove unnecessary imports. normalize debug log levels 2019-06-21 13:01:01 -05:00
Russell Johnson
97f42a6193 Fix functionality of manual override of Final Depth
manual Final Depth settings were limited to values greater than the base face for the Op. Manual settings of Final Depth may now proceed below the face (Outside profile ops)
2019-06-20 00:02:14 -05:00
sliptonic
d4a311de19 Path: PEP8 and Proxy changes. 2019-06-17 09:17:38 -05:00
Russell Johnson
4df89e0e3d Misc. fixes
Clean up code, improve comments, improve user feedback.
Improve temp clone management.
Correct depth issue with self.finDep
Add comment descriptions for new methods
Clean up comments and contribution information
Initiate recognition of type()==SurfaceOfExtrusion
Adopt standard PathGeom.isRoughly() and .Tolerance rather than idependent precision settings
2019-06-13 10:55:32 -05:00
Russell Johnson
a160aab486 Fixes for depths and AttemptInverseAngle
Depth correction to obj.FinalDepth.Value in single feature operations
Fix AttemptInverseAngle to be uni-directional
Clean up debug and other user provided feedback
2019-06-13 10:55:31 -05:00
Russell Johnson
4c69b48dc6 Improve code structure; correct 4th-axis depth issues 2019-06-13 10:55:30 -05:00
Russell Johnson
338861f2d2 Integration of 4th-axis feature to PathProfileFaces
4th-axis integration should not affect current feature set
2019-06-13 10:55:29 -05:00
luz.paz
aedb888ae3 Path: source comment typo fixes
Found via `codespell`
2019-05-30 19:57:25 +02:00
Markus Lampert
48d058dc78 Fixed ProfileFaces for multiple base models. 2018-09-11 07:24:39 +02:00
Markus Lampert
e098c7f1f7 Fixed merge issues 2018-09-11 07:24:35 +02:00
Markus Lampert
524380cd12 Fixed unit tests to support multiple base models. 2018-09-11 07:24:31 +02:00
Markus Lampert
0824066c59 Added operation setting support to profile ops. 2018-09-02 00:32:22 -07:00
Markus Lampert
ebe76319b8 Added name parameter to operation proxy constructor. 2018-09-02 00:32:22 -07:00
Markus Lampert
070d17e4e4 Add job as parameter to opSetDefaultValues 2018-09-02 00:32:22 -07:00
Markus Lampert
8c70c3abcd Fixed retraction of tool when profiling multiple holes. 2017-08-22 10:16:58 -03:00
Markus Lampert
9f0ba77a54 Added doc strings to operations. 2017-08-22 10:16:58 -03:00
Markus Lampert
a32f527ac5 Added support for baseobject into PathOp, used by almost all ops anyway. 2017-08-22 10:16:58 -03:00
Markus Lampert
0d4bc71a65 Moved base functionality into PathOp and renamed AreaOp interface to areaOp... 2017-08-22 10:16:58 -03:00
Markus Lampert
3c3c30259e Extracted common profile functionality into base class. 2017-08-22 10:16:57 -03:00
Markus Lampert
1e76c99250 Renamed PathProfile to PathProfileFaces for consistency; moved common depth calculation for ops with BaseGeometry into PathAreaOp. 2017-08-22 10:16:57 -03:00