kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
45,322 Commits 41 Branches 6 Tags
076c5916b52a9a132943e1d7da00a5b25d27eee5
Commit Graph

3937 Commits

Author SHA1 Message Date
Chris Hennes
076c5916b5 Sketcher: Remove unneeded parameters from seekConstraintPosition 2026-02-11 19:49:31 +01:00
Chris Hennes
ecbe21ca03 Sketcher: Annotate unused parameter 2026-02-10 19:10:36 +01:00
Yash Suthar
2cd45b07f7 Sketcher: Fix snap while drag and fix drag for arc 
Signed-off-by: Yash Suthar <yashsuthar983@gmail.com>
 2026-02-10 10:20:11 -06:00
Chris Hennes
6a1da227cd Merge pull request #27346 from TomPcz/sketcher-label-offset 
Sketcher: Fix dimension label alignment and inactive strikethrough
 2026-02-09 10:58:39 -06:00
chris jones @ipatch
c4317f88f8 sketcher: fixes #27281 fix access out of bounds crash with "remove axes alignment" 2026-02-09 09:52:02 -06:00
freecad-gh-actions-translation-bot
e5d0e5316d Update translations from Crowdin 2026-02-09 05:39:43 +01:00
William Skellenger
5f952812c3 Fix tooltips on mirror checkboxes in sketcher (#27131) 2026-02-08 10:03:37 +00:00
Tomáš Pikálek
41e3cdb9a5 Sketcher: Reimplement strikethrough of inactive constraint labels 2026-02-04 21:04:06 +01:00
PaddleStroke
8a6872e69d Merge pull request #25848 from PaddleStroke/sk_scale_distances 
Sketcher: Distance constraints: scale label distance on creation.
 2026-02-03 16:34:53 -06:00
freecad-gh-actions-translation-bot
0b7da82433 Update translations from Crowdin 2026-02-02 11:49:57 +01:00
PaddleStroke
00c3422c1f Sketcher: Tooltip when hovering expression driven constraint (#25954) 2026-01-29 15:04:40 +01:00
PaddleStroke
a0847c22c7 Sketcher: fix logic flaw in ConstraintLineByAngle 2026-01-29 13:15:42 +01:00
Vassily Checkin
d3d6459484 Sketcher: fix intermittent crash on sketch exit 2026-01-29 11:42:04 +01:00
PaddleStroke
7bcaa766de Sketcher: Fix arc angle dragging distance 2026-01-27 16:33:30 +01:00
freecad-gh-actions-translation-bot
d574623a2e Update translations from Crowdin 2026-01-26 10:11:06 +01:00
PaddleStroke
c9041132f9 Sketcher: add switch between radius and diameter (#26794) 2026-01-23 21:39:46 +00:00
Amon Sha
6a0d59b0c1 Merge pull request #27077 from amon-sha/fix_sketcher_autoscale_segfault 
Sketcher: fix segfault during autoscale
 2026-01-23 15:18:25 +01:00
PaddleStroke
54d235f8a5 Sketcher: Show constraint type in the list 2026-01-22 10:36:35 +01:00
PaddleStroke
93abfc4fa4 Sketch: Forward non-default edit mode to base class. (#27063) 
Ported from Codeberg commit 66dbf277

Co-authored-by: wwmayer <wmayer@freecad.org>
 2026-01-21 22:41:44 +01:00
Yash Suthar
9beca4363a Sketcher: Switch to perpendicular based instead of "de la Hire" in setting minor axis of ellipse 
Signed-off-by: Yash Suthar <yashsuthar983@gmail.com>
 2026-01-20 22:54:07 +01:00
PaddleStroke
af053f19f5 Sketcher: Fix box selection regressions. And make addSelections Print to python (#26869) 2026-01-19 09:19:38 -06:00
freecad-gh-actions-translation-bot
10a540b1bf Update translations from Crowdin 2026-01-19 08:10:24 +01:00
Syres916
0a45527b8b [Sketcher] Fix serious integer typo 2026-01-18 13:59:12 +01:00
Yash Suthar
cf93c33359 Sketcher: Fix external geometry creation from LCS (#26946) 
* Sketcher: Fix external geometry creation from LCS

Signed-off-by: Yash Suthar <yashsuthar983@gmail.com>

* Sketcher : Refactor used freecad_cast

Signed-off-by: Yash Suthar <yashsuthar983@gmail.com>

---------

Signed-off-by: Yash Suthar <yashsuthar983@gmail.com>
 2026-01-18 00:21:45 +01:00
Syres916
c14d6f8848 [Sketcher] set vertex size for new sketches to preference otherwise … (#26908) 
* [Sketcher] set vertex size for new sketches to preference otherwise set to 4px

---------

Co-authored-by: Chris Hennes <chennes@gmail.com>
 2026-01-16 17:52:27 +00:00
Chris Hennes
cd6aa97485 Merge pull request #26886 from AjinkyaDahale/sk-fix-symmetric-after-refactor-stage-5 
Sketcher: fix `addSymmetric` after refactor stage 5
 2026-01-13 15:23:43 -06:00
PaddleStroke
fc82d71c15 Sketcher: Fix symmetry of slot redundancy false positive (#26604) 
* Sketcher: Fix symmetry of slot redundancy false positive

Perturb symmetric geometries when using the 'create symmetric constraints' option to avoid numerical singularities in the solver (Jacobian Rank).
If geometry is "perfect", the solver cannot distinguish between the derivative of a Symmetry constraint and an Equal constraint, flagging one as redundant.
 2026-01-13 13:48:41 -06:00
Ajinkya Dahale
14280cdbf7 Sketcher: Add new constraints after running addSymmetric 
Missed during refactor
 2026-01-13 03:32:15 +05:30
Ajinkya Dahale
e1a431d5ee Sketcher: Use new constraint element access in add/getSymmetric 2026-01-13 03:32:15 +05:30
freecad-gh-actions-translation-bot
7ddee25ec9 Update translations from Crowdin 2026-01-11 19:42:50 -06:00
tetektoza
887c8d3bdf Sketcher: Fix crash when applying constraints during selection batching 
Currently, the selection batching optimization introduced in #26663
stores ElementItem/ConstraintItem pointers in a buffer to be processed
on the next event loop cycle via `QTimer::singleShot`.

When a constraint is applied,
`slotElementsChanged()/slotConstraintsChanged()`
rebuilds the list widget, destroying all items. However, the selection
buffer was not cleared, leaving dangling pointers. When
`processSelectionBuffer()`
executed, it attempted to call `QListWidget::row()` on deleted items,
causing a segmentation fault.

So, this patch fixes it by clearing `selectionBuffer` when the list is
rebuilt, since the buffered pointers are invalidated anyway.
 2026-01-08 10:17:35 -06:00
Kacper Donat
8dffa07978 Merge pull request #19132 from tritao/base-remove-boost-signals 
Base: Remove Boost-based signals and switch to `FastSignals`.
 2026-01-08 12:41:29 +01:00
Saksham Malhotra
db8c90b788 Fix sketch redundancy warning (#26064) 2026-01-08 07:53:26 +00:00
tritao
69058376e6 Base: Remove Boost-based signals and switch to FastSignals. 2026-01-07 21:16:16 +00:00
Leandro Heck
d0c7ab7d62 Sketcher: Support Bezier and Offset curves as external geometry (#25144) 
* Sketcher: Support Bezier and Offset curves as external geometry

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Sketcher: Fix adding projection of external arc of circle

In processEdge() it's checked if first and last point of the projected arc of circle are almost equal. If yes then a full circle
is assumed but this conclusion is not necessarily correct because it's still possible that the external arc of circle is very
short. The better criterion is to check the parameter range of the arc of circle.

See also: https://github.com/FreeCAD/FreeCAD/pull/25144#issuecomment-3502916685

---------

Co-authored-by: wwmayer <wmayer@freecad.org>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
 2026-01-07 09:23:28 +01:00
Max Wilfinger
e9a66713ef Merge pull request #22951 from AjinkyaDahale/sk-refactor-stage-5 
[Sketcher] Stage 5 of refactors
 2026-01-07 09:23:10 +01:00
Kacper Donat
77a43c55ef Merge pull request #26703 from tetektoza/fix/25840_draw_parts_of_constraints_ontop_of_others 
Gui: Render constraint text, arrowheads and constraint icons above geometry lines
 2026-01-07 05:39:05 +01:00
tetektoza
b1fdf659d8 Sketcher: Disable depth testing for constraint icons 
Add `SoDepthBuffer` nodes around the constraint group to disable depth
testing for constraint icons. This ensures icons render on top of
geometry lines regardless of Z position, improving visibility and
selectability.
 2026-01-06 20:08:35 +01:00
pre-commit-ci[bot]
c19eb5c0e0 [pre-commit.ci] auto fixes from pre-commit.com hooks 
for more information, see https://pre-commit.ci
 2026-01-06 01:40:39 +00:00
Ajinkya Dahale
9791d3f6d5 Sketcher: Override clang-format for some readability 
See https://github.com/FreeCAD/FreeCAD/pull/22951#discussion_r2314544159.
 2026-01-06 07:08:17 +05:30
Ajinkya Dahale
e9469d93cc [Sketcher] Use replaceGeometries() in join() 2026-01-06 05:59:10 +05:30
Ajinkya Dahale
50a091c0ca [Sketcher] Use auto where possible 2026-01-06 05:59:10 +05:30
Ajinkya Dahale
c02969da9c [Sketcher] Refactor SketchObject::updateGeometryRefs() 2026-01-06 05:59:10 +05:30
Ajinkya Dahale
9993cc123c [Sketcher] Refactor SketchObject::onChanged() 
Break into pieces depending on which property has been passed.
 2026-01-06 05:59:10 +05:30
Ajinkya Dahale
e34d6604d7 [Sketcher] Refactor removeAxesAlignment() 
Use switch case for more readability, and move some if and for indentations
 2026-01-06 05:59:10 +05:30
Ajinkya Dahale
abc3c74abd [Sketcher] Refactor SketchObject::validateExpression() 2026-01-06 05:59:10 +05:30
Ajinkya Dahale
585ce5ec03 [Sketcher] Refactor SketchObject::migrateSketch() 
Manipulate some if-else statements, for loops, and possibly replace them with
std algorithms.
 2026-01-06 05:59:10 +05:30
Ajinkya Dahale
169a10c7d2 [Sketcher] Refactor some if-else statements in SketchObject 2026-01-06 05:59:10 +05:30
Ajinkya Dahale
0c2f4df8d5 [Sketcher] Refactor addSymmetric and getSymmetric 
Rearrange some if-else and use `std::find_if` instead of looping.

[Sketcher][WIP] Refactor `getSymmetric` and `addSymmetric`
 2026-01-06 05:59:10 +05:30
Ajinkya Dahale
78cdd8d59d [Sketcher] Refactor delExternalPrivate() 2026-01-06 05:59:10 +05:30