kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
22,969 Commits 41 Branches 6 Tags
08efd286df0006013154af830f14db3d640de06a
Commit Graph

22969 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
donovaly
08efd286df [Sketch] add missing menu entry for new feature 2020-11-09 16:12:27 +01:00
wmayer
6b9178e0b3 Part: [skip ci] correctly show control points of a B-spline/Bezier curve/surface if a placement is set 2020-11-09 13:14:31 +01:00
marioalexis
3f5caddabf Draft: Enable offset for working plane aligned with current view 2020-11-09 12:42:18 +01:00
marioalexis
a36fb60653 Draft: Improve archDimTracker class 2020-11-09 12:39:19 +01:00
marioalexis
ef2d4f2989 Draft: Fixes in gui_offset 2020-11-09 12:37:56 +01:00
Roy-043
97828f0ba8 Update dxf.cpp 
Fixed wrong DXF scale factor for inches. 1/25.4 was wrongly used,
 2020-11-09 12:35:14 +01:00
Roy-043
5f63f3ae71 Update dxf.cpp 
Fixed wrong Inch scale factor. 1/25.4 was wrongly used.
 2020-11-09 12:35:14 +01:00
wmayer
58be246baf Part: [skip ci] fix type of Rotations property of Spiral primitive 2020-11-09 09:31:16 +01:00
donovaly
9b5eb77480 [Sketch] remove now unused variable 
also add comment for better understanding
 2020-11-08 18:59:28 +01:00
wmayer
c5a4b01d2e Gui: [skip ci] try to avoid to truncate QuantitySpinBox at bottom margin on macOS 2020-11-08 16:07:10 +01:00
Abdullah Tahiri
975c03a206 Sketcher: Some fixes to bspline weight information layer 
- fix sign/unsign comparison warning
- show intent in for loop comparison, values inside the loop over size() are not intended and are undesirable
- do not use itw for an index, as it evokes an interator - it -
- BSpline Weight on information layer positioned one line under Knot multiplicity
 2020-11-08 15:56:58 +01:00
donovaly
65c96a3b21 [Sketch] add option to display spline weights 
When working with weights, it is a huge improvement to see the weights immediately when changing the pole circle radius.
This PR adds an option to display the weights.
 2020-11-08 15:56:21 +01:00
wmayer
7251a90f6a Part: [skip ci] implement live preview for primitives 2020-11-08 15:40:59 +01:00
wmayer
70be25752d Part: override extensionSetupContextMenu in ViewProviderSplineExtension 2020-11-08 13:37:17 +01:00
wmayer
31ff1921ce Gui: [skip ci] add method extensionSetupContextMenu to extension view provider 2020-11-08 13:36:31 +01:00
wmayer
4025405ce5 Part: make view provider for helix and spiral inherit from primitive and use spline extension 2020-11-08 12:19:57 +01:00
wmayer
98d7a0400e Part: [skip ci] implement extension ViewProviderSplineExtension 2020-11-08 12:18:44 +01:00
wmayer
694eebf126 smesh: [skip ci] comment out call of std::set_unexpected that has been removed in C++17 2020-11-08 10:47:08 +01:00
wmayer
035803e47d Part: [skip ci] properly handle transactions when editing primitives 2020-11-08 10:43:04 +01:00
wmayer
dabf65cc72 Part: [skip ci] implement live preview for box and cylinder 2020-11-08 10:26:07 +01:00
donovaly
0b9c425678 [part] remove a now misleading comment 
I added this comment when I read the dialog state fro the index of the type combobox, now we read the primitive's TypeID so the comment is misleading
 2020-11-08 06:43:16 +01:00
Abdullah Tahiri
b8376e1529 Sketcher: Fix select associated constraints when drawhandler active 2020-11-07 20:18:14 +01:00
Chris Hennes
c23e1dd7ba Release handler in commands where not needed 
Fixes #0004478: Active constraint tool blocks sidebar tasks from working.

Many commands are interrupted by the existence of a handler. Rather than having these commands silently cancel, purge the handler if a command executes that does not need it.

When right-clicking on an item in the Constraint Task sidebar, any current operation is cancelled and the FreeCAD selection is synced with the selected items in the constraints QListWidget. This allows all of the menu items in the context menu to function properly: if the selection is not synced, anything that relies on the FreeCAD selection (like Delete) will sillently fail.
 2020-11-07 20:17:19 +01:00
sgrogan
6cac6d937b set -DBUILD_ENABLE_CXX_STD='C++17' 2020-11-07 19:48:31 +01:00
sgrogan
e9531d2a7e increase osx timeout limit 2020-11-07 19:48:31 +01:00
wmayer
c11a36386b smesh: [skip ci] comment out call of std::set_unexpected that has been removed in C++17 2020-11-07 19:47:11 +01:00
wmayer
f8bd2c81c3 Part: [skip ci] add missing export macro 2020-11-07 10:17:34 +01:00
wmayer
f23187cd0e Part: allow to edit primitives via dialog 2020-11-06 23:12:40 +01:00
Daniel Wood
5807c38416 [Path] Fix Typo - Stock object requires uppercase 'S' 2020-11-06 20:01:56 +01:00
wmayer
80626d3a1f [Part] allow to edit helices via a dialog 
+ add class ViewProviderPrimitive to avoid to re-implement setEdit/unsetEdit methods for each sub-class separately
+ avoid using global variables
+ when editing a feature directly pass it to the dialogs
+ when editing a feature then do not use active document as this could point to the wrong object
+ fix undo/redo message
+ re-add '3D View' button to location dialog
 2020-11-06 19:59:14 +01:00
wmayer
5170a1564e Part: [skip ci] fix build failure due to missing class declarations 2020-11-06 13:46:38 +01:00
donovaly
6d83162783 [Part] allow to edit helices via a dialog 
fixes https://tracker.freecadweb.org/view.php?id=3857

Currently primitives of the Part WB can only be created suing a dialog. Editing is not possible that way.

This PR makes the first step in achieving this:

- Helices can now be edited using the same dialog ans when created

- New location dialog. The Gui::LocationWidget used there is not aware of the rotation angle and it treats the rotation axis as direction. To fix this, I set changed the dialog so that one can define every parameter as in the PartDesign attacher dialog (Placement, rotation axis and rotation angle separately). Another reason for this change was that one could not use the location dialog, fill it with the placement properties of the object, and close the dialog without any change. Because of the missing angle info the objects was then always rotated despite nothing was changed.

If this PR goes in, I will extend it for the other primitives.

Todo for the future: allow a preview of the changes made in the dialog. (I could not find out how this is done.)
 2020-11-06 13:27:03 +01:00
donovaly
edc5925148 [TD] change RichAnnos's linestyle to the one of other TD components 
we already use enumerations for line styles for other components of TD and also the preferences. It seems I just have overseen this occurrence.
 2020-11-06 12:14:18 +01:00
wmayer
0d27ad18ca Base: [skip ci] fix several -Wunused-parameter warnings 2020-11-06 08:15:44 +01:00
wmayer
36bece9925 Base: [skip ci] fix several -Wunused-parameter warnings 2020-11-06 08:14:00 +01:00
tomate44
1940f4e3b4 Surface: prevent GeomFillSurface to produce C0 rational BSpline surface 2020-11-06 07:52:40 +01:00
luz paz
b75cd3dd52 Path: Fix header uniformity and remove trailing whitespace 
This PR fixes header uniformity across all Path files. It also removes all trailing whitespace.
 2020-11-05 19:57:21 +01:00
sliptonic
48365ecdbb Merge pull request #3974 from glhasson/glhasson-marlin_post.py 
Path: Add marlin_post.py
 2020-11-05 09:17:56 -06:00
wmayer
c8e46ee555 PartDesign: [skip ci] do not write error but log message when reading thread definitions of hole feature 2020-11-05 15:40:49 +01:00
M G Berberich
70eb263eb3 fixes bug not enabling ui-elements 
see:
https://forum.freecadweb.org/viewtopic.php?p=445186&sid=45bd75e3ab8c4d830decf91e946f7391#p443362
 2020-11-05 15:35:05 +01:00
luz paz
a5adc3eb8b README: minor nitpick [skip ci] 
This commit didn't make it in to f33ca46076
 2020-11-05 15:21:42 +01:00
wmayer
db537b8f90 Sketcher: [skip ci] use delGeometries to delete all superfluous geometry in one go after changing multiplicity 2020-11-05 15:19:39 +01:00
wmayer
9801b36e73 Sketcher: [skip ci] add method SketchObject::delGeometries 2020-11-05 12:37:07 +01:00
wmayer
a5b338630f Sketcher: [skip ci] minor optimization in SketchObject::delGeometry 2020-11-05 10:04:42 +01:00
GaryH
75b8ff3665 Modify code format to PEP8 
Add --marlin-config argument
  Marlin requires certain configuration settings in order to work well
  with FreeCAD. Those configuration settings will be added to the
  end of the gcode file as comments, when --marlin-config is entered
  as a post processor argument.
  For PEP8 conformity:
      Change some double-quotes to single-quotes.
      Change sequence of import statements.

Modify code format to PEP8
  Indentation and line length meet PEP8 requirements.
  Other aspects of PEP8 are partially implemented.

Add code to remove embedded comments
  Also, minor tweaks throughout

Change outstring to outList for clarity
  Change format_outstring to format_outList
  Change: if PathUtil.opProperty(obj, 'Active') is False:
    To: if PathUtil.opProperty(obj, 'Active') == False:

Format file to PEP8 standard
  Format first pass using:
    autopep8 --in-place --aggressive --aggressive
  Manually adjust format for better appearance
  Recheck format using http://pep8online.com/
  Change code related to pythonopen into with open() code
  Minor refactoring
 2020-11-04 19:55:02 +01:00
GaryH
d632130831 Refactor marlin_post.py 
Change G4 P to G4 S for Marlin
  Marlin uses P for milliseconds, S for seconds.
  FreeCAD uses P for seconds, so change P to S.

Remove code for G20 inch mode and G91 relative mode
  Due to the fundamentals of the FreeCAD pre-processor,
  this post processor can only operate in the following modes:
  G90 Absolute positions
  G21 Metric units (mm)
  G17 XY plane (3 axis vertical milling only)

Expand RETURN_TO option to float values for XYZ
  The RETURN_TO option previously only accepted integer values, and
  only for X and Y.
  This change allows float values for XY and optionally Z.

Add class: "Drill" within drill_translate()
  The nested functions within drill_translate() need to modify the
  variable that was named trBuff. To allow this, trBuff was changed
  to class: "Drill" with property "gcode".
  Within drill_translate(), including within the nested functions,
  modifying "trBuff" is now replaced with modifying "Drill.gcode".

Merge in updated portions of grbl_post.py
  Prior verson was derived from an older grbl_post.py.
  Merge in the portions of the newer grbl that seem improved.
  Refactor overall after the merge.

Add options for partial comments
  Add option:  --no-finish-comments
  Add option:  --no-path-comments
 2020-11-04 19:55:02 +01:00
GaryH
0e0156a2c2 Add files via upload 2020-11-04 19:55:02 +01:00
luz paz
ff5f3799d8 Fix various typos [skip-ci] 
Found via `codespell v2.0.dev`  
```
codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,ba,beginn,behaviour,bloaded,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,orgin,orginx,orginy,ot,pard,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml
```
 2020-11-04 10:18:30 +01:00
luz paz
19a5190243 Swap comma for period 2020-11-03 15:18:34 +01:00
Allan Nordhøy
70f4e523c2 Line 38 removed. 2020-11-03 15:18:34 +01:00