Commit Graph

2794 Commits

Author SHA1 Message Date
Benjamin Nauck
1b49998f6f Merge pull request #23291 from 3x380V/measurement
Measure: Useability improvements
2025-08-26 06:51:50 +02:00
PaddleStroke
679a072a4a PartDesign: Extrude 2 sides (#21794)
* PartDesign: extrude 2 sides

* Part: OpCodes XOR

* PartDesign: Remove deprecated generatePrism functions

* PartDesign: Extrude : Update Sides combobox strings

* Change "Sides" to "Mode"

* Use OpCodes::Extrude instead of Prism.
2025-08-25 17:17:23 +00:00
wmayer
01c427d5e3 PD: Increase the tolerance to check for planar surfaces
The default tolerance to check for a planar B-spline surface is 1.0e-7 which might be too strict in some cases.
Therefore the tolerance is increased to 2.0e-7.

This fixes issue 21242
2025-08-25 09:29:29 +02:00
Max Wilfinger
3129bc9a1e Fix UI strings reported on Crowdin (#23297)
Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org>
2025-08-25 06:10:53 +00:00
Max Wilfinger
ab5e9e0ded Fix source string mistakes reported on Crowdin (#23157)
* Fix source string mistakes reported on Crowdin

* Update src/Mod/Draft/Resources/ui/TaskPanel_CircularArray.ui

Co-authored-by: Roy-043 <70520633+Roy-043@users.noreply.github.com>

* Update src/Mod/Draft/Resources/ui/TaskPanel_CircularArray.ui

Co-authored-by: Roy-043 <70520633+Roy-043@users.noreply.github.com>

* Update src/Mod/Draft/draftfunctions/upgrade.py

Co-authored-by: Roy-043 <70520633+Roy-043@users.noreply.github.com>

* Update src/Mod/Draft/draftfunctions/upgrade.py

Co-authored-by: Roy-043 <70520633+Roy-043@users.noreply.github.com>

* Update src/Mod/Draft/draftguitools/gui_downgrade.py

Co-authored-by: Roy-043 <70520633+Roy-043@users.noreply.github.com>

* Update src/Mod/Draft/Resources/ui/TaskPanel_SetStyle.ui

Co-authored-by: Roy-043 <70520633+Roy-043@users.noreply.github.com>

---------

Co-authored-by: Roy-043 <70520633+Roy-043@users.noreply.github.com>
2025-08-24 20:51:32 -05:00
Kacper Donat
3e6e66cea8 PartDesign: Prevent Hole from claiming other features as children 2025-08-24 20:37:44 -05:00
Kacper Donat
670252460f PartDesign: Unify deletion behavior
This unifies deletion behavior for all PartDesign features ensuring that
sketches that were used to create these features show after deletion and
that the tip is properly transfered.
2025-08-23 16:40:33 -05:00
Kacper Donat
61c1645d76 PartDesign: Do not copy visuals from ShapeBinder 2025-08-23 16:38:53 -05:00
Kacper Donat
e0d3b83f26 PartDesign: Properly forward BaseFeature transform edit requests to Body 2025-08-23 16:37:53 -05:00
FEA-eng
1ffd333edd PartDesign: Fix small typo in multiple solids error (#23299)
* PartDesign: Update FeatureChamfer.cpp

* Update src/Mod/PartDesign/App/FeatureChamfer.cpp

---------

Co-authored-by: Max Wilfinger <6246609+maxwxyz@users.noreply.github.com>
2025-08-22 20:47:04 +00:00
FEA-eng
80c110764c PartDesign: Update error message about multiple solids (#23286) 2025-08-22 18:29:50 +00:00
marioalexis
94d20bbc95 PartDesign: Remove use of user parameters from Body constructor 2025-08-20 15:08:47 +02:00
Roy-043
8e20557ddb Update CommandBody.cpp 2025-08-19 07:29:06 +02:00
Chris Hennes
40b1ea294c Update translations 2025-08-18 17:55:24 +02:00
Max Wilfinger
abb7007596 PartDesign: Enable compounds for PD bodies 2025-08-18 01:09:07 +02:00
Benjamin Nauck
8e774e4309 PartDesign: Use sketch as neutral plane for Draft (continuation of 20135) (#21901)
* Enabled Draft to accept sketch as neutral plane

* Resolving the last review

* Fix: tested the Feature with test file

* Fix: error with sketch pointer

* PartDesign: Simplify selection implementation

---------

Co-authored-by: Ziad <ziad.ashraf.cs@gmail.com>
2025-08-17 14:55:53 -05:00
theo-vt
270776c92f PartDesign: Hole: fallback to getProfileNormal when a non-cylindrical surface is used 2025-08-15 10:09:23 -05:00
theo-vt
7336a7fd42 PartDesign: Hole use the default PartDesign context menu items 2025-08-15 12:21:54 +02:00
Kacper Donat
2cb3e87d01 PartDesign: Use Style Parameters for theming previews 2025-08-12 22:04:23 +02:00
luzpaz
a5a59ff2e3 Fix various typos 2025-08-12 12:18:23 -05:00
Kacper Donat
b73bb45ae1 PartDesign: Implement preview for Draft 2025-08-12 11:34:26 -05:00
Alfredo Monclus
01b8382f24 PartDesign: disable final model while selecting on dressups (fillet/chamfer)
Co-authored-by: Kacper Donat <kacper@kadet.net>
2025-08-07 00:37:47 +02:00
Alfredo Monclus
6c89660c8b Gui: refactor: change Preview button label to Confirm Selection
Transparent preview can be enabled so it wasn't representative
2025-08-07 00:37:47 +02:00
Kacper Donat
f539a38389 PartDesign: Add preview TaskBox to all feature task dialogs 2025-08-07 00:37:46 +02:00
Kacper Donat
ca2b1cdf84 PartDesign: Add support for preview for transforms 2025-08-07 00:37:23 +02:00
Kacper Donat
c4b741f488 PartDesign: Add transparent previews 2025-08-07 00:37:21 +02:00
Kacper Donat
2b5a95f3d0 PartDesign: Return to previous feature after edit 2025-08-07 00:36:23 +02:00
Ryan Kembrey
9d16384d6f PartDesign: Fix regression in mirror 2025-08-05 16:29:12 +02:00
Max Wilfinger
be0c0e7a74 PartDesign: Update UI strings for consistency and correct for new fuctions and typos
Closes: #22128
2025-08-04 20:15:04 +02:00
Florian Foinant-Willig
9091048627 Try to auto-fix any invalid generated helix 2025-08-04 17:52:06 +02:00
Syres916
9dbfb949e7 Tests: Add test for two face loft 2025-08-03 19:14:09 +02:00
Ladislav Michl
a3e43d97f6 PD: Fix loft between curved faces
Fixes issue 19183 also reported in the forum:
https://forum.freecad.org/viewtopic.php?p=806495
https://forum.freecad.org/viewtopic.php?t=88234

The actual reason for the failure is that the new code uses
FaceMakerBullseye method which expects coplanar wires.
The code was using FaceMakerCheese previously which changed
in LinkStage with their commit 93ce3edfe7ff
("PD: use FaceMakerBullseye for feature Loft")
and was imported here with TNP mitigations.

As changing it back would cause different regressions, lets
try different facemakers until one succeeds.

Fixes: 301194a69682 ("Toponaming/Part: Fix all getBaseTopoShape calls...")
Co-authored-by: Benjamin Nauck <benjamin@nauck.se>
Co-authored-by: Werner Mayer <wmayer@freecad.org>
2025-08-03 19:14:09 +02:00
theo-vt
d699d38537 PartDesign: Hole: get direction from cylindrical surface rather than normal (#22393)
* PartDesign: Hole: Find direction of cylindrical face in Hole::execute instead of FeatureSketchBased::getProfileNormal

* PartDesign: Minor cleanups in guessNormalDirection

---------

Co-authored-by: Kacper Donat <kadet1090@gmail.com>
2025-07-28 02:06:50 +00:00
Pieter Hijma
f5c315d05a PartDesign: Add migration tag 2025-07-22 09:03:27 +02:00
wmayer
06eeea8cb2 PD: Fix crash in Loft::getSectionShape
The passed DocumentObject pointer can be null which is nowhere checked.
This fixes issue 19545

Fixes: 256ad7a01a ("PartDesign: Loft Intelligence - Select the whole sketch if the selected shape is ...")
2025-07-18 09:57:29 -05:00
theo-vt
a933c22dad Allow open wires in Part::getProfileNormal 2025-07-14 17:38:51 +02:00
Andrea
6f18b152ed Remove unused deprecated functions
Remove unused deprecated functions
2025-06-30 10:40:10 -05:00
Kacper Donat
46d7d8a8b4 Merge pull request #22169 from 3x380V/fix_19002
PD: Fix regression about single-solid check
2025-06-25 21:40:05 +02:00
wmayer
86359a3183 PD: Correctly handle single solid rule for loft with and without base 2025-06-25 00:14:15 +02:00
wmayer
7335c798d1 PD: Use isSingleSolidRuleSatisfied() for pipe feature
This fixes issue 18977

Fixes: 17ad40b2c9f0 ("PartDesign: Refactor single-solid rule enforcement")
2025-06-25 00:13:54 +02:00
wmayer
25e73289ae PD: Fix regression about single-solid check
For several PD features the single-solid check fails. The regression
is caused by PR 13960 and reported as issue 19002. The reason for the
failure is that the first solid of the output shape is retrieved and
then checked for a single solid. This test will always pass, of course.

The single-solid is fixed for these features:
* Pad
* Pocket (never worked there)
* Fillet
* Chamfer
* Groove (never worked there)
* Revolution (never worked there)
* Loft

Fixes: 17ad40b2c9f0 ("PartDesign: Refactor single-solid rule enforcement")
2025-06-25 00:09:33 +02:00
Bas Ruigrok
7a49335cad PartDesign: Remove use of adjustCameraPosition() 2025-06-23 19:28:56 +02:00
David Tanana
3f7438a686 PartDesign: Added 1 3/16 16 threaded drill hole diameter (#22000)
* Adding UNf 1 3/16  16 to this list
* Updating type and test params
2025-06-17 08:59:00 -05:00
wmayer
2c2ebc6ed2 Test: Do not write test files into CWD
When running the tests make sure to write the test files into the temp directory.

This fixes issue 19112
2025-06-10 17:11:25 +02:00
wmayer
2a7498c930 Helper function to get preferred delete key depending on platform 2025-06-09 18:10:52 +02:00
Chris Hennes
30aee57880 Merge pull request #21659 from 3x380V/gui_fixes
Gui: random fixes
2025-06-03 19:23:21 -05:00
Alfredo Monclus
cece88a20f PD: hole change the task panel threaded and model thread checkboxes into a combo/dropdown (#21664)
* PD: hole change threaded and modeled to combo in taskpanel

* Gui: Property editor apply review suggestions
2025-06-03 21:14:52 +02:00
Kacper Donat
df6949dcde Merge pull request #21427 from tritao/async-occt-progress
Part: Introduce `OCCTProgressIndicator` and port operations to support it.
2025-06-02 18:04:38 +02:00
Alfredo Monclus
b21cf693f1 feat(PD): ISO tyre valve threads 2025-06-02 10:50:10 -05:00
Yorik van Havre
640642eed2 Translations: Merged crowdin translations 2025-06-02 11:48:26 +02:00