Commit Graph

75 Commits

Author SHA1 Message Date
PaddleStroke
0b2268a921 Sketcher: Constraint rendering (#24534)
* Sketcher: Constraint rendering

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update EditModeConstraintCoinManager.h

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update EditModeConstraintCoinManager.cpp

* Update SoDatumLabel.cpp

* Update SoDatumLabel.cpp

* Update EditModeConstraintCoinManager.cpp

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update EditModeConstraintCoinManager.cpp

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* revert changes drawing the box around fx

* Update EditModeConstraintCoinManager.cpp

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2025-11-02 15:51:14 +01:00
Markus Reitböck
ef670e7880 Sketcher: use CMake to generate precompiled headers on all platforms
"Professional CMake" book suggest the following:

"Targets should build successfully with or without compiler support for precompiled headers. It
 should be considered an optimization, not a requirement. In particular, do not explicitly include a
 precompile header (e.g. stdafx.h) in the source code, let CMake force-include an automatically
 generated precompile header on the compiler command line instead. This is more portable across
 the major compilers and is likely to be easier to maintain. It will also avoid warnings being
 generated from certain code checking tools like iwyu (include what you use)."

Therefore, removed the "#include <PreCompiled.h>" from sources, also
there is no need for the "#ifdef _PreComp_" anymore
2025-09-23 00:51:00 +02:00
matthiasdanner
46ec53f4da Fix "Show only Visible Constraints" option (#23187)
Co-authored-by: Matthias Danner <28687794+matthiasdanner@users.noreply.github.com>
2025-09-22 10:54:24 -05:00
matthiasdanner
6d5800c862 Sketcher: Fix Assertion Crash when selecting a Constraint in a group (#23491)
* Sketcher: Fix Assertion Crash when selecting a Constraint in a group

* Update src/Mod/Sketcher/Gui/EditModeConstraintCoinManager.cpp

---------

Co-authored-by: Matthias Danner <28687794+matthiasdanner@users.noreply.github.com>
Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org>
2025-09-01 06:28:13 +00:00
matthiasdanner
19a082b63c Sketcher: Fix constraint selection in groups (#22937)
* Fix constraint selection in groups

* include paddlestrokes refactoring and fix for more than 2 constraints in a group

---------

Co-authored-by: Matthias Danner <28687794+matthiasdanner@users.noreply.github.com>
Co-authored-by: PaddleStroke <pierrelouis.boyer@gmail.com>
2025-08-24 22:08:32 -05:00
captain0xff
ed770bf849 Sketcher: fix cropping of some icons on hidpi screens 2025-08-18 01:02:13 +02:00
matthiasdanner
f38485ada2 Sketcher: Add second arc helper on diameter constraint (#22579)
* add second arc helper on diameter constraint

* fix linter warnings

---------

Co-authored-by: Matthias Danner <28687794+matthiasdanner@users.noreply.github.com>
2025-07-20 19:46:49 +02:00
tetektoza
a265fb8817 Sketcher: Remove redundant comment regarding old SoAnnotation node 2025-06-16 23:57:17 +02:00
tetektoza
02716069c2 Sketcher: Prioritize rendering geometry lines rendering over constraints
As the title says - since there is pending PR for better SoDatumLabel
constraints interactivity, this patch now prioritizes geometry lines
over constraints, so constraints will be rendered below lines.

This patch changes rendering order of constraint lines to be below
geometry lines, so now selection and rendering will be prioritized for
geometry lines instead of constraints.

This is done by changing depth buffer values and removal of SoAnnotation
node which was disabling depth buffer checks on constraints at all.
2025-06-16 23:56:47 +02:00
Céleste Wouters
90a612db29 Sketcher: remove "SecondIcon" logs on constraint icon hover
Hovering the cursor over constraint icons sometimes logs "SecondIcon"
messages to the report view, doing so for every cursor move event.
This message isn't useful outside of a development context and in fact
is a leftover from 11c76c998e.

Removes this message.

Fixes #21417
2025-05-18 16:30:22 +02:00
bofdahof
998f4e4d45 Console: rename PascalCase named methods to camelCase 2025-05-06 17:50:21 +02:00
Ladislav Michl
c293d74566 Base: rename Exception's PascalCase methods to camelCase 2025-05-05 23:50:01 +02:00
bofdahof
30fd8d6d60 Sketcher: refactor EditModeConstraintCoinManager::getPresentationString 2025-04-27 00:45:53 +02:00
Benjamin Nauck
4b589088f6 Sketcher: Add #include <limits> where used 2025-03-31 23:52:38 +02:00
Benjamin Nauck
b4eb28e50e Sketcher: Use std::numeric_limits and std::numbers instead of defines 2025-03-29 13:32:39 +01:00
Benjamin Bræstrup Sayoc
c0c6df10ec Sketcher: Use QStringLiteral 2025-02-10 18:32:45 +01:00
Ladislav Michl
2ea8a633ac Base: Quantity: return std::string 2024-12-23 17:48:42 +01:00
Ajinkya Dahale
e2664f397d [Sketcher] Use modernized geometry type checks 2024-08-25 07:33:59 +05:30
PaddleStroke
0c53340746 Sketcher: Fix distance arc helper : should appear only if constraining the edge. 2024-05-20 11:11:27 -05:00
sliptonic
75c589d355 Merge pull request #12602 from FlachyJoe/arc-distance
Sketcher : ArcLength Constraint
2024-04-01 10:43:35 -05:00
Roy-043
a7251a6c3a Sketcher: Spelling colinear -> collinear
I have not changed the name of the `areColinear` function.
2024-03-26 07:40:14 +01:00
Florian Foinant-Willig
646b4381f9 Sketcher: ArcLength GUI 2024-03-25 22:32:20 +01:00
wmayer
5d1564fec5 Sketcher: fix crash when trying to edit malformed sketch
For more details see: https://forum.freecad.org/viewtopic.php?p=745031#p745031
2024-03-05 10:34:01 -06:00
Chris Hennes
5f743aa36b Merge pull request #12012 from Ondsel-Development/radius_render_fix
[Sketcher] Improve rendering of arc-angle, line-angle, arc-distances and fix radius
2024-01-22 11:21:53 -06:00
Paddle
b140feabaf Sketcher: Edges pattern and width by type. 2024-01-22 11:12:42 -06:00
Paddle
eb91978459 Sketcher : Distance constraint : introduce arc helpers for conic distances. 2024-01-19 11:50:38 +01:00
Paddle
df867a25b2 Sketcher : arc angle render improvement. 2024-01-19 11:13:09 +01:00
Paddle
dca00ec80e Sketcher : improve single line angle rendering. 2024-01-19 11:13:09 +01:00
Paddle
64c867eb0e Sketcher Fix radius arc helpers. 2024-01-19 11:13:09 +01:00
Paddle
5ee16df6b7 Draw arc helpers for radius constraints. 2024-01-12 19:03:38 -06:00
Paddle
827781ab3f Improve angle constraint rendering. 2024-01-12 19:03:38 -06:00
Florian Foinant-Willig
5a75578308 Sketcher: fix one point distance (#11854) 2024-01-05 09:29:28 -06:00
Florian Foinant-Willig
482b45dadc Sketcher: Fix Point to Line Distance 2023-12-20 20:03:13 +01:00
Abdullah Tahiri
759930e3aa Sketcher: Move lint comment to right position 2023-12-18 10:55:16 -06:00
Florian Foinant-Willig
df32ad2d38 Fix isCircleOrArc usage 2023-12-17 16:01:29 +01:00
Abdullah Tahiri
4d860203fc Sketcher: Utils/CommandConstraints/EditModeConstraintCoinManager - refactor duplicated code 2023-12-17 16:01:29 +01:00
Florian Foinant-Willig
94eaa7db78 Sketcher: Arc to arc or circle distance constraint 2023-12-17 16:01:29 +01:00
Paddle
a2c909f329 Draw arc helpers for radius constraints. 2023-11-24 15:07:35 +01:00
Paddle
74dd736e3c Improve angle constraint rendering. 2023-11-24 15:07:35 +01:00
Chris Hennes
cf84c171e6 Merge pull request #10978 from FlachyJoe/modernize-type-check
Modernize type and derived type checking
2023-11-06 10:44:32 -06:00
Abdullah Tahiri
882262bfa8 Sketcher Gui: clang-tidy diagnostic errors 2023-11-05 07:11:57 +01:00
Florian Foinant-Willig
a32851073d Sketcher: modernize type checking 2023-10-23 18:09:23 +02:00
pre-commit-ci[bot]
222a2520b1 [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
2023-09-12 13:02:35 -04:00
bdieterm
7013ce0cbc Sketcher: fix segfault on distance constraints without SecondPos 2023-08-29 16:24:15 -05:00
Florian Foinant-Willig
ae60811fba Sketcher: Point to Circle Distance Constraints (#9559) 2023-08-28 10:58:09 -05:00
luzpaz
3d0bfa214f Fix various typos 2023-08-13 08:17:01 -07:00
andrea
6c2a5c1539 removed coin<3 references 2023-08-04 21:19:29 -06:00
Abdullah Tahiri
1d61ed187c Sketcher: Fix bug angle via point visualisation
===============================================

Issue description:
https://forum.freecad.org/viewtopic.php?f=3&t=70325
https://github.com/FreeCAD/FreeCAD/issues/7520

The general algorithm to calculate normals miserably fails when
the curve is a line segment and the point through which the normal
to a curve is to be drawn is colinear with the line segment.

The solution is to provide specific code for this corner case.

fixes #7520
2023-05-28 06:45:50 +02:00
Abdullah Tahiri
ec899d75c6 SketcherGui: apply clang-format 2023-05-25 17:08:03 +02:00
Abdullah Tahiri
fdd3525424 SketcherGui: Separate user and developer errors
===============================================

Revisiting all console calls:
- Using the Notification Framework when the user needs to be notified
- Turning them into DeveloperError/DeveloperWarnings when messages are intended only for developers
2023-05-25 14:09:06 +02:00