Commit Graph

41 Commits

Author SHA1 Message Date
bgbsww
0bddc51805 Refactor all element name pairs into clearer struct names - renames 2024-07-20 16:32:12 -04:00
bgbsww
96aa878b7e Toponaming: reformat code 2024-06-03 19:29:01 -04:00
bgbsww
45c4aefaae Rework makeElementChamfer to match current parms, and add PartDesign code for Chamfers 2024-05-12 13:28:20 -05:00
Zheng, Lei
7bc2b3688a TopoShape/Part: Bring in FeatureDressup 2024-04-11 10:22:11 -04:00
Florian Foinant-Willig
6adc675a12 PartDesign: modernize type checking 2023-10-23 18:08:16 +02:00
luz paz
c726b69d7e PD: remove trailing whitespace 2022-11-10 10:32:04 +01:00
berniev
da9ebc572f Mod: redundant void 2 2022-08-08 10:27:50 +02:00
berniev
2d4c5a4cfb Mod: use emplace_back 2022-08-05 10:36:16 +02:00
wmayer
88accdb421 PD: [skip ci] Fix several clazy issues:
* Maybe you meant to call base method instead [-Wclazy-skipped-base-method]
* Missing reference in range-for with non trivial type [-Wclazy-range-loop-reference]
* Mixing iterators with const_iterators [-Wclazy-strict-iterators]
* Unused QByteArray [-Wclazy-unused-non-trivial-variable]
* C++11 range-loop might detach Qt container (QList) [-Wclazy-range-loop-detach]
2022-07-25 13:40:19 +02:00
Uwe
c5678ef373 [PD] FeatureDressUp.cpp: add missing include 2022-07-03 21:20:01 +02:00
wmayer
3608ee7f51 PD: modernize C++11
* use nullptr
2022-03-23 19:26:14 +01:00
Uwe
7c44008e2d [PD] App: remove unused includes 2022-02-20 20:41:46 +01:00
wmayer
95f583a677 Part: fix typos in make* functions 2022-02-16 12:48:02 +01:00
Ajinkya Dahale
bc90f4480b [PD] Use compare to compare strings instead of substr
Used when finding subelements of a feature. Many of the comparisons used to also
check for string lengths, but as far as I can tell they are not strictly
necessary (see https://www.cplusplus.com/reference/string/string/substr/) and
just `substr` can be used without them. However, `compare` explicitly is for
comparing, and does not make a new object that `substr` does.
2021-11-28 22:05:46 +01:00
troyp76
1a3527c06a Improved chamfer behavior when faces are selected
Improved chamfer behavior when faces are selected and non equal chamfer types are used
2021-09-18 22:03:28 +10:00
luz paz
7fb4dd37e4 PD: Fix typo in function getContiniusEdges->getContinuousEdges
Related to PR #5029
2021-09-15 10:11:37 -04:00
luz paz
f20ab1765f Fix Crowdin typos + trim superfluous whitespace [skip-ci]
Some issues that this PR fixes (but not all listed):  
https://crowdin.com/translate/freecad/27911/en-en#6581578  
https://crowdin.com/translate/freecad/27911/en-en#6579080  
https://crowdin.com/translate/freecad/27911/en-en#6581580  
https://crowdin.com/translate/freecad/27911/en-en#6579086
2020-07-23 13:52:44 +02:00
Zheng, Lei
896e774c41 PartDesign: fix DressUp SupportTransform
Skip multiple consequtive DressUp features when SupportTransform is
enabled.
2020-07-11 13:03:44 +02:00
Zheng, Lei
7fadfd0439 PartDesign: change feature DressUp behavior when used for pattern
Repurpose DressUp.SupportTransform property to define the following
behavior,

* When disabled (default), only the dressing will be used for patterning.

* When enabled, the additive/subtractive shape of the dressed base
  feature will be used for patterning. Any dressing that is not applied
  to the based feature will be ignored.

* If the dressing is applied to non-additive/subtractive feature, then
  only the dressing will be used for patterning.

New API FreatureAddSub::getAddSubShape() is added to account for the
fact that a dressing (e.g. a fillet) can be either additive or
subtractive, which means that a DressUP feature may contain both
additive and subtractive shapes.

FeatureTransformed is modified to perform both fusion and cut if
required.
2020-07-11 13:03:21 +02:00
Zheng, Lei
4a26bd0b2f PartDesign: disable SupportTransform on legacy dressup feature
Because in order to SupportTransform, dressup must calculate its
AddSubShape, which is empty for existing legacy dressup feature.
2020-03-20 14:50:59 +01:00
Zheng, Lei
974267bc6e PartDesign: fix dressup AddSubShape transformation
AddSubShape must not have local transformation.
2020-03-20 14:50:59 +01:00
wmayer
a34cd69125 PartDesign: [skip ci] fixes #0004276: Loading a project takes much more time compared to previous versions 2020-03-02 10:06:16 +01:00
Zheng, Lei
c6bb533541 PartDesign: fix DressUp base shape checking 2020-02-23 11:04:54 +01:00
Zheng, Lei
3a9002217c PartDesign: fix FeatureDressUp base checking 2020-02-14 13:34:03 +01:00
Zheng, Lei
469614eb17 PartDesign: support transformed pattern in FeatureDressUp
Fixes #1650
2020-02-14 13:34:03 +01:00
Abdullah Tahiri
a415ad72e1 PartDesign: 3rdParty to PCH 2019-05-02 07:12:27 +02:00
wmayer
7acdb56d92 Replace Base::Exception with appropriate subclass 2018-11-14 19:28:00 +01:00
Wolfgang E. Sanyer
7f4a437cc2 This commit adds getShape and setShape to TopoShape 2016-08-06 23:42:55 +02:00
Stefan Tröger
7d30833349 PartDesign: Adopt to new property status bits 2016-04-12 18:12:22 +02:00
Alexander Golubev
55f3f52f54 PartDesign/Feature: add an optional parameter to getBaseObject() to prevent it from throwing exceptions
In most cases getBaseObject() is used with an exception handler which
only detects if it failed but not the reason. This modification allows
to use it without excess exception handlers.
Also add the same parameter to SketchBased::getVerifiedSketch().
2016-04-12 18:12:15 +02:00
Alexander Golubev
5f6f16e757 PartDesign/FeatureDressUp: implement a proper getBaseObject()
The function getBaseShape() is removed and replaced with getBaseObject()
because it doesn't make a lot of scense: getBaseShape() masked the
base's class implementation (rather than redefine a virtual) which was
better in words of code reuse.

Also BaseFeature and Base properties relations are defined now in a
little another way.
2016-04-12 18:12:15 +02:00
Alexander Golubev
0208a3667d PartDesign/FeatureDressUp: make Base and BaseFeature properties track the same feature
Also remove reseting of read-only flag on placement properties on
removing Base feature: it doesn't make any scense for dressup features.
2016-04-12 18:12:15 +02:00
Stefan Tröger
fc1e8b8d17 allow to add faces to fillet and chamfer 2016-04-12 18:12:07 +02:00
jrheinlaender
a59901ee4b Some code unification for DressUp features 2016-04-12 18:11:56 +02:00
jrheinlaender
c4fe27d093 Miscellaneous fixes 2016-04-12 18:11:51 +02:00
jrheinlaender
7330d4357e Made the rest of the PartDesign features aware of the Body 2016-04-12 18:11:49 +02:00
wmayer
50d7793442 + introduce proper enum for property status to replace plain integers 2016-01-01 15:36:24 +01:00
jrheinlaender
ded5b893a8 PartDesign: tidy up PartDesign feature dependencies 2012-09-09 10:05:43 +02:00
wmayer
1b5e834ee9 Set placement property to read-only for skecth/ dress up features 2012-04-06 12:29:18 +02:00
logari81
f6ce9caf79 + fix Placement of PartDesign/Fillet feature to the Placement of its base
git-svn-id: https://free-cad.svn.sourceforge.net/svnroot/free-cad/trunk@5289 e8eeb9e2-ec13-0410-a4a9-efa5cf37419d
2011-12-13 07:17:09 +00:00
wmayer
120ca87015 + unify DLL export defines to namespace names
git-svn-id: https://free-cad.svn.sourceforge.net/svnroot/free-cad/trunk@5000 e8eeb9e2-ec13-0410-a4a9-efa5cf37419d
2011-10-10 13:44:52 +00:00