Commit Graph

300 Commits

Author SHA1 Message Date
Yorik van Havre
966906da96 Merge pull request #4557 from luzpaz/crowdin/whitespaces-substituted-into-code
Crowdin: represent whitespace in code instead of in string
2021-05-05 17:18:35 +02:00
Roy-043
e13bf0fac7 Update gui_points.py
Gui.addModule("Draft") should be executed before committing _cmd_list irrespective of the UsePartPrimitives setting.
2021-04-29 21:07:07 +02:00
Roy-043
a3778eacd4 Update gui_arcs.py
Gui.addModule("Draft") should be executed before committing _cmd_list irrespective of the UsePartPrimitives setting.
2021-04-29 21:05:52 +02:00
Roy-043
7fa3869116 Update gui_ellipses.py
Gui.addModule("Draft") should be executed before committing _cmd_list irrespective of the UsePartPrimitives setting.
2021-04-29 21:03:44 +02:00
Yorik van Havre
c0c49ebffc Merge branch 'master' into draft-feature_name 2021-04-29 12:40:27 +02:00
Yorik van Havre
d366c38922 Merge pull request #4389 from marioalexis84/draft-close_button
[0.20] [Draft] Call finish method if Close button is pressed in dumb taskdialog
2021-04-20 11:36:03 +02:00
luz paz
6f83a4a815 Crowdin: represent whitespace in code instead of string 2021-04-19 06:23:07 -04:00
luz paz
b94ee8b275 Crowdin: represent whitespace in code instead of in string [skip ci]
Removing possible whitespace from strings lead to more accurate translations
2021-04-19 06:16:09 -04:00
marioalexis
d0c1935cbf Draft: Fix regression in trimex command 2021-04-11 16:24:02 -03:00
Yorik van Havre
433441298c Merge pull request #4410 from marioalexis84/draft-snap
Draft: Fixes #0004278: Working Plane Proxy origin hijack nearby object
2021-03-30 13:16:14 +02:00
Yorik van Havre
ac8f611fc7 Merge pull request #4546 from chennes/lgtmDraftUnusedLoopVariables
[DRAFT] Remove unused loop variable
2021-03-30 13:04:08 +02:00
Yorik van Havre
d30ecd96bd Merge pull request #4625 from marioalexis84/draft-edit
Draft: Make Edit closed wires consistent with open wires and tracker
2021-03-30 12:50:06 +02:00
marioalexis
05f290f119 Draft: Make featureName attribute translation-independent
The translation for the task panel title is done in the Ui method call
2021-03-29 10:51:53 -03:00
Yorik van Havre
7c6c0ea7bd Merge branch 'master' into draft-snap 2021-03-26 11:21:08 +01:00
Yorik van Havre
4a8319d63e Merge branch 'master' into draft-close_button 2021-03-26 11:19:09 +01:00
Yorik van Havre
94b9374b37 Merge pull request #4348 from marioalexis84/draft-coordinate_input
[0.20] [Draft] Add global mode to enter points - Fixes #0004108
2021-03-26 11:18:23 +01:00
marioalexis
b5f9a80543 Draft: Clear tracker attributes when finish method is executed in gui_stretch 2021-03-20 17:12:58 -03:00
marioalexis
6795e0d7e6 Draft: Change selectUi and makeDumbTask argument named 'callback' to 'on_close_call'
Suggested by user @carlopav
2021-03-20 17:12:58 -03:00
marioalexis
7a54edb33a Draft: Set reject method for working plane task dialog 2021-03-20 17:12:58 -03:00
marioalexis
7c00d19a28 Draft: Call finish method if pressed Close button in dumb taskdialog 2021-03-20 17:12:58 -03:00
marioalexis
b9421e2747 Draft: Make Edit closed wires consistent with open wires and tracker 2021-03-20 01:58:10 -03:00
marioalexis
4bbd75686c Draft: Fix regression in sync_snap_toolbar_button function 2021-03-14 17:14:58 -03:00
Yorik van Havre
5c30dc8ce2 Merge pull request #4544 from chennes/draftSnapSyncRefactor
[DRAFT] Refactor sync_snap_toolbar_button
2021-03-10 16:24:16 +01:00
Chris Hennes
4ebdff9d9c [Draft] Fix localize_vectors double definition
LGTM identified an instance where a function was defined twice: in this
case, one version was intended to take a list of items and the second
version just a single item. Because they share the same name and number
of arguments, the second definition overrode the first. This causes no
problems in the current code because the version that takes a list is
never used. However, for consistency with the analogous
"globalize_vectors" and "globalize_vector" functions, the "localize*"
versions are changed to match that pattern. All calls in are
converted to the singular use.
2021-03-01 09:36:21 -06:00
Chris Hennes
2d9c9accda [DRAFT] Remove unused loop variable
LGTM is concerned about the unused loop variable in this algorithm.
While there was nothing wrong here, to eliminate the alarm the loop was
removed entirely, since Python allows the use of the multiplication
operator here to achieve the same effect.
2021-02-28 23:18:53 -06:00
Chris Hennes
59ecfbe508 [Draft] Return once the button is found 2021-02-28 21:48:31 -06:00
Chris Hennes
747dc8b81a [DRAFT] Refactor sync_snap_toolbar_button
LGTM objected to the re-use of the loop variable a in the algorithm.
Upon closer inspection, the algorithm in this function could be modified
to match the algorithm in sync_snap_statusbar_button (which does the
same thing to the statusbar that this does to the toolbar). This
eliminates the double-use. This change does not affect the functionality
of the routine.
2021-02-28 21:42:46 -06:00
Chris Hennes
26ce308cf1 [DRAFT] Add call to super().__init__ where missing
Identified by LGTM. The toplevel superclass does initialize one data
member to an empty array, but this didn't appear to cause any problems.
2021-02-27 18:21:54 +01:00
marioalexis
b8dee20115 Draft: Fix snap to proxy WP and BuildingParts - fixes #0004278 2021-02-23 21:40:06 -03:00
marioalexis
edbb798184 Draft: Remove restore WP method call in draftguitools's finish method - fixes #0004562 2021-02-19 13:13:05 -03:00
Yorik van Havre
335cc13d48 Draft: Applied patch from nahshon - fixes misc errors from translation fixes 2021-02-15 15:50:45 +01:00
David Osterberg
9dd96ed107 Draft: Fix regressions in Draft array 2021-02-14 01:20:06 +01:00
wmayer
ac6d06dd84 Draft: fix syntax errors 2021-02-13 12:14:12 +01:00
Yorik van Havre
abee35f38a Draft: Fixed broken translations everywhere 2021-02-12 14:44:58 +01:00
Chris Hennes
a7522c384e [DRAFT] Catch only Exception, not BaseException 2021-02-11 11:52:45 +01:00
marioalexis
ae4ef332ff Draft: Correct the placement in scale_with_clone - fixes #0004113 2021-02-06 23:42:22 -03:00
marioalexis
6969be3881 Draft: Use function-specific icons in the taskbar 2021-02-01 01:26:15 -03:00
Roy-043
b6976b3b23 [Draft] Fix snap to center of faces of solids
The code would only find a center snap on the face with index=0 of solids.

In V0.19 Part.getShape was introduced (line 399). But not all consequences were not fully implemented.

In the '# we are snapping to an edge' section (line 411) the code could be cleaned up. There is no need to check if the index of the edge is correct for the parent object since we are no longer dealing with a parent object. That portion was effectively dead code.

The '# we are snapping to a face' section (line 429 in the revised code) has been modified accordingly, which fixes the bug.

Forum discussion:
https://forum.freecadweb.org/viewtopic.php?f=23&t=54747
2021-01-25 15:33:36 +01:00
marioalexis
875c0d8612 Draft: Prevent Draft_Wire from setting a single-edge wire as closed 2021-01-22 01:16:40 -03:00
Yorik van Havre
7b10771b7c Draft: Don't snap to ImagePlanes 2021-01-12 15:31:55 +01:00
Yorik van Havre
2cf3a15101 Draft: Added import/export buttons to Annotation styles editor dialog 2021-01-05 16:54:06 +01:00
marioalexis
739daccd8d Draft: Fix multiple crashes when using modification functions - fixes #0004243 2021-01-02 02:15:43 -03:00
luz paz
439bf8960d Fix typos [skip ci]
Found via `codespell v2.1.dev0`
2020-12-23 14:32:38 -05:00
Yorik van Havre
bdd9c23af7 Reverting files wrongly committed with 11beceea8 2020-12-23 15:21:43 +01:00
Yorik van Havre
16effcb2af Updated ts files 2020-12-23 14:51:04 +01:00
Yorik van Havre
1d83dc3007 Draft: Small wording fix 2020-12-15 16:41:35 +01:00
Yorik van Havre
481937f034 Draft: Small fixes to Draft SetStyle panel 2020-12-15 16:40:16 +01:00
luz paz
fc99ff2def Draft: fix header uniformity + trailing whitespace
[skip ci]
2020-12-11 13:19:49 +01:00
Yorik van Havre
8c15f7f84f Draft: Colored grid axes 2020-12-03 15:15:15 +01:00
marioalexis
1569b08451 Draft: Change archDimTracker text position depending on distance and scale values 2020-11-23 16:25:21 -03:00