Commit Graph

2278 Commits

Author SHA1 Message Date
Ladislav Michl
1053a7996a TD: remove unused clearLineSets()
d2ce7f8145 ("TD: Remove calls to now-empty clearLineSets() method")
removed last calls to clearLineSets(), so remove it entirely.
2025-09-01 14:12:58 +02:00
wmayer
93820d6867 TD: Fix compiler warnings 2025-09-01 14:11:52 +02:00
wmayer
b59a1f6230 TD: Fix crash on selecting 3D edge for dimension
Unlike in the bug description of issue 19654 the user doesn't have
to preselect an edge in the 3D view but first start the dimension
command and then select an edge.

This commit adds some security checks to TechDrawHandler::quit(),
TechDrawHandler::getPage() and TDHandlerDimension::onSelectionChanged()
to be on the safe side that no null pointers are dereferenced.

But the ultimative fix for this whole problem is to change
activateHandler() and immediately delete the passed TechDrawHandler if
it fails to find the appropriate QGVPage. This is needed as otherwise
the handler behaves like a ghost object that affects the selection
mechanism and disallows to select anything in the 3D view or the tree
view.

Fixes issue 19654
2025-09-01 14:11:51 +02:00
wandererfan
d288a5ee30 [TD]allow finding child view outside clip rectangle 2025-08-31 20:56:14 -05:00
luzpaz
f7f8ac1552 TechDraw: remove trailing whitespace 2025-08-30 22:10:14 -05:00
Chris Hennes
f3c675ed5b Update translations 2025-08-28 16:14:49 +02:00
xtemp09
887e7bd595 Simplify repr() function 2025-08-25 10:38:39 -05:00
wandererfan
c39ba51407 [TD]fix crash in vertex show/hide 2025-08-24 22:19:31 -05:00
WandererFan
e256ff3c3d [TD]Fix no delete of cosmetic in clip group (#22838)
* [TD]Fix no delete of cosmetic in clip group

* [TD]lint clean up
2025-08-24 20:55:55 -05:00
Max Wilfinger
ab5e9e0ded Fix source string mistakes reported on Crowdin (#23157)
* Fix source string mistakes reported on Crowdin

* Update src/Mod/Draft/Resources/ui/TaskPanel_CircularArray.ui

Co-authored-by: Roy-043 <70520633+Roy-043@users.noreply.github.com>

* Update src/Mod/Draft/Resources/ui/TaskPanel_CircularArray.ui

Co-authored-by: Roy-043 <70520633+Roy-043@users.noreply.github.com>

* Update src/Mod/Draft/draftfunctions/upgrade.py

Co-authored-by: Roy-043 <70520633+Roy-043@users.noreply.github.com>

* Update src/Mod/Draft/draftfunctions/upgrade.py

Co-authored-by: Roy-043 <70520633+Roy-043@users.noreply.github.com>

* Update src/Mod/Draft/draftguitools/gui_downgrade.py

Co-authored-by: Roy-043 <70520633+Roy-043@users.noreply.github.com>

* Update src/Mod/Draft/Resources/ui/TaskPanel_SetStyle.ui

Co-authored-by: Roy-043 <70520633+Roy-043@users.noreply.github.com>

---------

Co-authored-by: Roy-043 <70520633+Roy-043@users.noreply.github.com>
2025-08-24 20:51:32 -05:00
theo-vt
ff92789719 Techdraw: Undo/redo when dragging views and rework projection group drag (#22875)
* TechDraw: create a transaction when finished dragging a view

* TechDraw: drag projection group when dragging a subview in AutoDistribute is enabled

* TechDraw: avoid creating 'Drag View' transaction if the document is already in a transaction

* TechDraw: Apply suggestions from code review

---------

Co-authored-by: Benjamin Nauck <benjamin@nauck.se>
2025-08-24 08:36:41 +02:00
Ryan Kembrey
e0fed351b3 TechDraw: Fix frames resizing on select/hover 2025-08-22 16:36:31 +02:00
luzpaz
1906198901 TechDraw: Fix tooltip in Gui/CommandAnnotate.cpp
Typo fix
2025-08-19 07:35:23 +02:00
Chris Hennes
40b1ea294c Update translations 2025-08-18 17:55:24 +02:00
Kacper Donat
a673e6acf3 Merge pull request #22945 from ryankembrey/cosmetic-circles
TechDraw: Clarify and group cosmetic circle commands
2025-08-18 17:51:06 +02:00
theo-vt
f32ae1ca17 TechDraw: add transactions to multiple commands (#22795)
* TechDraw: add transactions to multiple commands

* Feed each 'Create Dimension' option to the translation macro

* Call fixSceneDependencies when re-adding dimensions so that it shows up at the right place
2025-08-18 11:46:15 -04:00
theo-vt
b6c96c51bb TechDraw: Fix balloon annotation unlinked after undo-redo (#22805)
* TechDraw: remove then add balloon annotation when changing the SourceView

* Use fixSceneDependencies
2025-08-18 10:37:02 -05:00
wandererfan
7c6e58fb50 [TD]fix weld symbol not attached to leader 2025-08-13 22:46:20 +02:00
wandererfan
f465729608 [TD]fix editable fields click handles
- click handles were displayed when view frames were displayed,
  and when printing or exporting.
- now, click indication is only shown on mouse over.
2025-08-11 11:05:47 -05:00
Ryan K
9fff6e905c TechDraw: Rework view frames (#22869)
Co-authored-by: Ryan Kembrey <ryan.kembrey@student.uts>
2025-08-11 11:04:58 -05:00
Chris Hennes
956f7eb38f Merge pull request #22466 from WandererFan/ComplexSection3
TechDraw: ComplexSection fixes
2025-08-11 11:01:47 -05:00
FC-FBXL5
648cefd0e6 Update TaskSectionView.ui
Tooltip related to label "Section Plane Location" deserves a better description. 
Also See Crowdin: https://crowdin.com/editor/freecad/all/en-de?view=comfortable&filter=basic&value=0&search_scope=translations&search_strict=0&search_full_match=0&case_sensitive=0#q=Abstand%20vom

This tool seems to work with one section plane (section line) only, which other object's distance/position could be addressed here?
2025-08-10 17:35:44 +02:00
Max Wilfinger
1850c5dc0f Fix missed strings for UI consistency
Fix ellipsis rendering
2025-08-08 06:37:59 -05:00
Ryan Kembrey
72cf63ae8a TechDraw: Fix default toolbar cosmetic circle name 2025-08-06 20:28:17 +10:00
Ryan Kembrey
57aa4525ee TechDraw: Fix cosmetic circle menu 2025-08-06 20:05:38 +10:00
Ryan Kembrey
f6a71b8718 TechDraw: Clarify and group cosmetic circle commands 2025-08-06 19:49:54 +10:00
Ryan Kembrey
bbfbb6e059 TechDraw: Update UI strings for consistency
Closes: #22143
2025-08-04 20:26:04 +02:00
wandererfan
8cfd7f67c6 [TD]prevent detail object deletion during task dialog 2025-07-28 18:11:12 +02:00
Kacper Donat
0270515a33 Merge pull request #22660 from chennes/fixMultResultConvertedToLargerType
Fix mult result converted to larger type
2025-07-25 10:20:03 +02:00
Chris Hennes
2aa659f2b3 TD: Fix multiplication result converted to larger type 2025-07-21 23:40:56 -05:00
jffmichi
1ad29bda6b TechDraw: fix dock/undock/fullscreen for TechDraw view 2025-07-21 00:44:18 +02:00
wandererfan
c3037ac127 [TD]ComplexSection fixes
- fix handling of non-ortho profiles
- fix profile not on same plane as section normal
- fix direction of arrows on section line
2025-07-13 12:08:15 -04:00
Kacper Donat
93a472c202 Merge pull request #22138 from chennes/compilerWarningCleanup20250622
Compiler warning cleanup
2025-07-06 16:32:08 +02:00
Ryan K
dd5cb6aa61 TechDraw: ActiveView rework (#22107)
* TechDraw: Rework ActiveView

* Update src/Mod/TechDraw/Gui/TaskActiveView.cpp

Co-authored-by: Benjamin Bræstrup Sayoc <benj5378@outlook.com>

---------

Co-authored-by: Ryan Kembrey <ryan.kembrey@student.uts>
Co-authored-by: Benjamin Bræstrup Sayoc <benj5378@outlook.com>
2025-06-30 12:04:12 -04:00
Ryan Kembrey
a3fb529bc8 TechDraw: Remove redundant apply button. (Fix #21792) 2025-06-23 11:15:03 -05:00
WandererFan
51184b99d5 [TechDraw]Detail highlight drag (fix #21828) (#22036)
* [TD]add preferences for detail highlight snapping

* [TD]fix highlight drag issues

* Update src/Mod/TechDraw/Gui/TaskDetail.cpp

minor format change from benj5378.

Co-authored-by: Benjamin Bræstrup Sayoc <benj5378@outlook.com>

---------

Co-authored-by: Benjamin Bræstrup Sayoc <benj5378@outlook.com>
2025-06-23 11:13:27 -05:00
Chris Hennes
e38af07217 TD: Remove calls to now-empty clearLineSets() method 2025-06-22 19:10:48 -05:00
Chris Hennes
c0d22febd8 TD: Add missing override 2025-06-22 19:10:48 -05:00
Ryan Kembrey
f338a779e0 TechDraw: Add spacing preview without OCCT calls 2025-06-16 10:41:21 -05:00
Syres916
39dc1e6210 [Gui] C++ preparation for deprecation of QCheckBox…
…stateChanged -> checkStateChanged
2025-06-13 10:40:48 +02:00
Luz Paz
78d995f2b8 TechDraw: fix typo in comment 2025-06-11 21:51:23 +02:00
wandererfan
ca20e8baad [TD]fix dim reference repair 2025-06-09 11:49:25 -04:00
Chris Hennes
30aee57880 Merge pull request #21659 from 3x380V/gui_fixes
Gui: random fixes
2025-06-03 19:23:21 -05:00
PaddleStroke
3fc9cac29c TechDraw: Sheet view: add property to claim sheet as child. (#21624)
* TechDraw: Sheet view: add property to claim sheet as child.

* Update ViewProviderSpreadsheet.cpp

* Fix bad scale of sheet views
2025-06-02 11:29:22 -05:00
WandererFan
935ac04995 Merge pull request #21377 from WandererFan/Removesnprintf
[TD]remove snprintf
2025-06-02 18:24:05 +02:00
Yorik van Havre
640642eed2 Translations: Merged crowdin translations 2025-06-02 11:48:26 +02:00
Yorik van Havre
26e16765b0 Translations: updated ts files 2025-06-02 11:07:28 +02:00
wmayer
b006a37010 Gui: Add Action::setBlockedChecked
Remove the second parameter of Action::setChecked and
provide Action::setBlockedChecked instead.
2025-05-30 14:21:53 +02:00
theo-vt
1a0a68ae69 PartDesign: Fix hole centered on point edge case (#21257)
* Light refactor of getTopoShape function

* Fix hole edge case

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update src/Mod/Part/App/PartFeature.cpp

Co-authored-by: Kacper Donat <kadet1090@gmail.com>

* Update src/Mod/Part/App/PartFeature.cpp

Co-authored-by: Kacper Donat <kadet1090@gmail.com>

* Update src/Mod/Part/App/PartFeature.cpp

Co-authored-by: Kacper Donat <kadet1090@gmail.com>

* Update src/Mod/Part/App/PartFeature.cpp

Co-authored-by: Kacper Donat <kadet1090@gmail.com>

* Refactor simplifyCompound()

* Use Base::Flags<GetShapeOption>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Shorten enum name and move it from class scope to namespace scope

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Kacper Donat <kadet1090@gmail.com>
2025-05-29 22:37:54 +02:00
Benjamin Bræstrup Sayoc
2438156b23 TechDraw: fix incorrect click handles of editable labels (#21131)
Fixes #20964:
- When `text` element doesn't have id
- When `text` element has transform attribute
2025-05-29 08:30:59 -04:00