kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
24,274 Commits 41 Branches 6 Tags
1667c4d9f671dee92c3d3ca57da7de46a2c5166e
Commit Graph

24274 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Chris Hennes
1667c4d9f6 [Part] Fix signature of TempoVis dummy function 
If the import of TempoVis fails, TaskAttachmentEditor creates s dummy
function to replace the real TempoVis function. That function's
signature did not match the real TempoVis. Caught by LGTM.
 2021-02-27 18:21:05 +01:00
Chris Hennes
d5779d8c9b [PD] Fix minor static analysis issues in FCGear 
LGTM has identified a number of minor issues with the FCGear Part Design
scripts. This commit addresses each of them, and also corrects two minor
spelling errors in the dialog. None of the errors or their fixes are
expected to result in changes to the functionality of the script.
 2021-02-27 18:20:32 +01:00
David Osterberg
9d24f90dd7 PartDesign: Transformded. Align the "property category" of Refine with other PD commands 2021-02-27 18:19:14 +01:00
wmayer
7530e48935 Gui: [skip ci] fix memory leak in SelectionFilter 2021-02-27 18:17:52 +01:00
wmayer
c243741296 Gui: [skip ci] re-add removed Py_INCREF of module 2021-02-27 11:13:30 +01:00
wmayer
dd4dd204d0 App/Gui: fix memory leaks: 
+ add function to cleanup units and quantities in debug build
+ fix reference leak in PropertyVector::getPyPathValue()
+ fix reference leak in PropertyPlacement::getPyPathValue()
+ in InterpreterSingleton::init() use a static std::vector<wchar_t*> instead of a C array
  to free memory at program end
+ in MainWindow::closeEvent() explicitly delete all task watchers
+ in ReportOutputObserver constructor pass parent to QObject
+ in PropertyEditor destructor explicitly delete QItemEditorFactory
 2021-02-27 10:56:19 +01:00
wmayer
6584c6e2ac App: [skip ci] AddressSanitizer: heap-use-after-free 
When removing a dynamic property its myName member must be nullified as the memory has been de-allocated
 2021-02-27 02:21:14 +01:00
wmayer
fdbd84ec39 FEM: [skip ci] fix crash in Constraint::getDirection 2021-02-26 08:11:16 +01:00
helaslo
71fe41988b [OpenSCAD] Fix colors not working correctly when polygons are extruded 2021-02-25 15:08:19 +01:00
Yorik van Havre
162d5c578f Merge branch 'master' of github.com:FreeCAD/FreeCAD 2021-02-25 13:30:09 +01:00
Yorik van Havre
fa85db61f9 Merged crowdin translations 2021-02-25 13:27:48 +01:00
Aapo
505ba2e42f [TD] DrawViewPart.cpp: Fix a crash when user sets the PropertyVector Direction to zero. 2021-02-25 12:40:59 +01:00
wmayer
3ad1d8fccc TD: [skip ci] implement DrawView::recompute to handle all OCC exception types 2021-02-25 12:39:50 +01:00
wmayer
88d49cd982 Gui: [skip ci] improve exception handling: 
* handle all exceptions in Application::onLastWindowClosed because this method can be (indirectly)  called from ~BaseView and would otherwise trigger std::terminate()
* handle exceptions in PropertyEditor::closeTransaction() because when recomputing a document while closing it leaves the editor in a bad state
 2021-02-25 12:23:13 +01:00
wmayer
2de6a80bb4 TD: [skip ci] explicitly nullify geometryObject in DrawViewPart::partExec to avoid to leave it a dangling pointer in case makeGeometryForShape raises an exception 2021-02-25 11:34:29 +01:00
luz paz
755f4cf1be Crowdin: removing obsolete strings from PartDesign.ts [skip ci] 
Uncertain to why but lupdate is not removing obsolete strings from `PartDesign.ts`. This PR manually removes obsoletes strings from it.

ref:
https://crowdin.com/translate/freecad/564/en-de?filter=basic&value=0#6500474
https://crowdin.com/translate/freecad/564/en-en?filter=basic&value=0#6500475
 2021-02-25 10:41:58 +01:00
wmayer
f36ba4c56e Crowdin: Gui: move whitespace out of translation string [skip ci] 2021-02-25 10:38:52 +01:00
luz paz
2f9ad32813 Crowdin: fix trailing whitespace [skip ci] 
ref: https://crowdin.com/translate/freecad/549/en-en?filter=basic&value=0#6577470
 2021-02-25 10:31:59 +01:00
luz paz
a522f4a240 Crowdin: Gui: fix user-facing typo in Document.cpp [skip ci] 
ref: https://crowdin.com/translate/freecad/549/en-en?filter=basic&value=0#6584664
 2021-02-25 10:31:33 +01:00
Aapo
e39ef22c1b [TD] Hotfix for Dimension label Arbitrary value regression in DrawViewDimension.cpp 2021-02-25 10:28:42 +01:00
wmayer
aa1eb6ea76 Gui: [skip ci] make Save logic of text document more intuitive 2021-02-25 10:17:51 +01:00
wmayer
46e46a1466 FEM: [skip ci] fixes #0004405: Using PartDesign axis / plane as direction for constraints 2021-02-24 23:59:10 +01:00
wmayer
ab04719372 FEM: [skip ci] support Line and Plane objects in Constraint::getDirection() 2021-02-24 23:53:15 +01:00
wmayer
ec2dbecac4 FEM: [skip ci] connect onButtonDirection() slot with clicked() signal 2021-02-24 21:55:51 +01:00
wmayer
78a9a3c2a8 PD: [skip ci] remove invalid static_cast 2021-02-24 20:12:26 +01:00
Yorik van Havre
5c12afb5b5 Merged crowdin translations 2021-02-24 18:07:59 +01:00
wmayer
145eb8ea8c PD: fixes #0004567: Pattern from a feature type UpToFace and Offset > copy whole body 2021-02-24 17:08:20 +01:00
wmayer
4c18734d2e PD: [skip ci] code refactoring 
Move adding offset to face from getUpToFace() to addOffsetToFace()
 2021-02-24 16:08:03 +01:00
sliptonic
66ef19ce1d Merge pull request #4520 from sliptonic/bug/translations 
[PATH]  Bug/translation issues
 2021-02-23 19:27:53 -06:00
sliptonic
81a3b9693b Fix whitespace error 2021-02-23 19:14:49 -06:00
sliptonic
53bd6a2d77 fix trailing whitespace 2021-02-23 19:12:25 -06:00
sliptonic
90ec044cb4 fix bad string formatting 2021-02-23 19:06:08 -06:00
sliptonic
3d83e73549 Make string less ambiguous 2021-02-23 19:03:18 -06:00
sliptonic
8ab39462b7 typo in string 2021-02-23 19:01:29 -06:00
sliptonic
5c984dff6a fix string formatting 2021-02-23 18:59:04 -06:00
Yorik van Havre
5ab70fd1b6 AddonManager: Fixed missing WB icons 2021-02-23 18:01:04 +01:00
wmayer
30ccf14117 Gui: [skip ci] fixes #0004104: Void property value defaults to 1 2021-02-23 17:32:02 +01:00
luz paz
646103113e Crowdin: Gui: fix DlgSettings3DView.ui tooltip [skip ci] 
Remove trailing whitespace  
ref: https://crowdin.com/translate/freecad/549/en-en?filter=basic&value=0#6577482
 2021-02-23 17:01:54 +01:00
wmayer
f0740edd20 App: [skip ci] AddressSanitizer: heap-use-after-free 
In Document::removeObject() do not access object after it has been possibly deleted
 2021-02-23 14:30:00 +01:00
wmayer
45079ca2ac PD: [skip ci] AddressSanitizer: stack-use-after-scope 
Axis() returns a tmp. object and thus we cannot use a const reference to get its Location() method
 2021-02-23 13:57:51 +01:00
Yorik van Havre
3b477772aa Merge pull request #4438 from paullee0/Draftutils_BugFixes_01 
[Draft.draftutils.groups]  get_windows() to support Links
 2021-02-23 11:45:41 +01:00
Yorik van Havre
74c280ae40 Merge branch 'master' into Draftutils_BugFixes_01 2021-02-23 11:45:23 +01:00
Yorik van Havre
6d9cd2f058 Merge pull request #4506 from berndhahnebach/bhbdev242 
Arch: ifc export, save guid to obj attribute
 2021-02-23 11:43:02 +01:00
Yorik van Havre
dcedcf8651 Merge pull request #4508 from donovaly/TD-BalloonHotfix 
[0.19] [TD] fix balloon dragging regression
 2021-02-23 11:41:58 +01:00
wmayer
48f56169de PD: [skip ci] fix regression caused by fdf7e6acbe120 
In the accept() method the view provider of the edited object must be made visible if it's valid as otherwise it can happen that the view is empty.

See https://forum.freecadweb.org/viewtopic.php?f=13&t=55915
 2021-02-23 11:20:45 +01:00
Abdullah Tahiri
88acd77442 Sketcher: Work-around for expression engine failure to calculate dependencies 
=============================================================================

THIS IS A WORK-AROUND NOT TO DELAY 0.19 RELEASE

depsAreTouched is not returning true in this case:
 https://forum.freecadweb.org/viewtopic.php?f=3&t=55633&p=481061#p478477

It appears related to a drastic change in how dependencies are calculated, see:
 https://forum.freecadweb.org/viewtopic.php?f=3&t=55633&p=481061#p481061

This is NOT the solution, as there is no point in systematically executing the ExpressionEngine
on every dimensional constraint change. Just a quick fix to avoid clearly unwanted behaviour in
absence of time to actually fix the root cause.
 2021-02-23 07:40:56 +01:00
Yorik van Havre
a1c6db4afa Doc: Updated offline doc for 0.19 2021-02-22 22:06:29 +01:00
Yorik van Havre
11b84ea87d Tools: Added link fix tool to offlinedoc tools 2021-02-22 22:05:51 +01:00
wmayer
d17b061fea App: [skip ci] check object status before accessing back links 2021-02-22 17:31:25 +01:00
Yorik van Havre
a01703d280 Tools: Updated offline doc scripts 2021-02-22 14:07:33 +01:00