Commit Graph

29615 Commits

Author SHA1 Message Date
Uwe
17528eb1ca .clang-format: change a style
as discussed here: https://github.com/FreeCAD/FreeCAD/pull/6918#issuecomment-1186529217
2022-07-18 00:48:46 +02:00
Uwe
b16f03ec02 [PD] add parameter enabling logic for pad/pocket
- currently all parameters are always enabled and thus can lead to errors like the one reported here:
https://forum.freecadweb.org/viewtopic.php?f=3&t=70266
2022-07-18 00:26:15 +02:00
Uwe
0eee9221f0 [PD] improve face selection for Pad/Pocket
- this PR extends PR #7191 as described in this forum thread: https://forum.freecadweb.org/viewtopic.php?f=3&t=70327
2022-07-17 18:35:34 +02:00
Uwe
16b25c5dab [PD] remove superfluous nullptr checks 2022-07-17 18:12:41 +02:00
Uwe
ac6235c577 [PD] App: remove superfluous nullptr checks
- also Body: get rid of some nasty single-letter variables
2022-07-17 18:07:00 +02:00
Uwe
48e84945ed [Part] remove superfluous nullptr checks 2022-07-17 18:06:21 +02:00
sliptonic
c0bf0f5c72 Merge pull request #7168 from sliptonic/feature/camoticstooltable
[Path] export a camotics tooltable
2022-07-17 08:42:43 -05:00
wmayer
d64963d337 Import: do not export the entire class but only its public methods.
This fixes the warning C4251 for the template classes std::string or std::vector
Forum thread: https://forum.freecadweb.org/viewtopic.php?f=10&t=70317
2022-07-17 13:49:27 +02:00
wmayer
07ccb73fe7 Partially revert "Remove unused code into GUI" 2022-07-17 12:32:03 +02:00
andrea
7886d3cbf4 Remove unused code into GUI 2022-07-17 03:53:11 +02:00
Uwe
86f9b4ec1f [PD] fix Pad/Pocket logic issue
- fixes the bug reported in https://forum.freecadweb.org/viewtopic.php?f=3&t=70266
  as Method #2
  -> When switching to two dimensions, symmetric must be unchecked if it is checked
2022-07-17 02:03:35 +02:00
Uwe
947bce371c [FEM] check if Gmsh, CCX and Mystran solver binaries exist
- adds the check like we have already for Z88 and Elmer
- also remove an unnecessary return statement
2022-07-17 01:43:58 +02:00
Uwe
e76fbe6998 [FEM] fix CCX (new framework) binary handling
- when the binary was not found, the function called the non-existing binary
- also push error message to the status info so that user gets feedback also when report view console is not shown
2022-07-17 01:28:54 +02:00
Uwe
1ba44fb1ca [FEM] fix Z88 binary handling
- when the binary was not found, the function called the non-existing binary
- also push error message for Elmer and Z88 to the status info so that user gets feedback also when report view console is not shown
- uniform wording to 'binary'
- avoid unnecessary console output
2022-07-17 01:18:21 +02:00
Uwe
22fb8ed337 [TD] fix compilation on MSVC
- CLMODE was used before its declaration, therefore it did not compile
forum thread: https://forum.freecadweb.org/viewtopic.php?f=10&t=70316
2022-07-17 00:26:13 +02:00
Benjamin Bræstrup Sayoc
f604c32c4d [TechDraw] Improve readability of DrawUtil.cpp 2022-07-16 16:00:43 -04:00
Benjamin Bræstrup Sayoc
f7c236a071 [TechDraw] Gather rotation calculations in a single function 2022-07-16 16:00:10 -04:00
Benjamin Bræstrup Sayoc
dd4e7ff159 [TechDraw] Improve readability of Cosmetic.cpp 2022-07-16 16:00:10 -04:00
Benjamin Bræstrup Sayoc
6356459ab6 [TechDraw] Refactor CosmeticEdge constructors
Use constructor delegation and default parameters for CosmeticEdge
2022-07-16 16:00:10 -04:00
Benjamin Bræstrup Sayoc
a5e10cc49b [TechDraw] Use constructor delegation for CosmeticEdge 2022-07-16 16:00:10 -04:00
Benjamin Bræstrup Sayoc
95f1c6f240 [TechDraw] Use default parameters for LineFormat constructor 2022-07-16 16:00:10 -04:00
Uwe
7346ee4073 [FEM] [skip CI] inform user about used CPU cores for Elmer
Since the number of used cores can for Elmer have the impact that a solver run converges or not, output this info prominently
2022-07-16 19:46:46 +02:00
Uwe
c4416e00ca [FEM] [skip CI] tell user when Elmer write succeeded
At the moment the user gets no feedback, while for Z88 and CCX he gets a result
2022-07-16 19:41:43 +02:00
Uwe
b39e91c26f [FEM] [skip CI] fix wording
Calculix will not be broken, but stopped. After clicking the button your will also get a message that it has been 'stopped'
2022-07-16 19:33:02 +02:00
wmayer
654de93621 Gui: implement mechanism to set a custom icon name or tooltip of a preferences group 2022-07-16 19:27:22 +02:00
Uwe
bcacab1988 [FEM] [skip CI] fix a typo 2022-07-16 19:21:25 +02:00
sliptonic
ac49ceb96f Update src/Mod/Path/PathScripts/PathToolBitLibraryGui.py
Co-authored-by: Benjamin Bræstrup Sayoc <benj5378@outlook.com>
2022-07-16 12:16:14 -05:00
sliptonic
11a48718ba Merge pull request #7127 from sliptonic/feature/chipbreak
[Path] Feature/chipbreak
2022-07-16 12:02:38 -05:00
Uwe
826a903281 [FEM] [skip CI] fix a string 2022-07-16 18:54:11 +02:00
sliptonic
b3924df2b7 GUI panel for chipbreaking 2022-07-16 11:30:16 -05:00
sliptonic
0352ddca13 Additional changes to support G73 2022-07-16 11:30:16 -05:00
sliptonic
70ad469f8b Generator can produce G73 (chipbreak) commands instead of G83.
Add tests
2022-07-16 11:30:16 -05:00
wmayer
6d4f22a970 Gui: fix crash in ExpressionCompleter::slotUpdate
Forum thread: https://forum.freecadweb.org/viewtopic.php?f=3&t=69931
2022-07-16 18:23:42 +02:00
Wanderer Fan
c25756af8a [TD]check for spline on linear Dims 2022-07-16 11:28:38 -04:00
Wanderer Fan
94dde1b9fb [TD]fix ext line gap preference 2022-07-16 11:28:38 -04:00
Uwe
0c5407b63d [Gui] preferences: clarify Part/PD page
- users are confused that we have a preferences page named "Part design" that also defines things for the Part WB. The Wiki is clear that the preferences page is for both, Part and PD, however the UI is not.
This PR makes this clear.
2022-07-16 16:20:36 +02:00
wmayer
da70aa2dc6 PD: fix ProfileBased::getSupportFace() to also handle the case where a support face is selected 2022-07-16 16:08:09 +02:00
Uwe
b0065c5827 [Gui] preferences: add button to switch gradient colors
- when finding a suitable background color gradient, it is annoying that there is no button to switch the begin/end color of the gradient. With the button one can quickly see the the changes and find a suitable gradient much quicker
2022-07-16 16:05:54 +02:00
Uwe
5bbf136174 [FEM] [skip CI] fix a typo 2022-07-16 16:01:38 +02:00
wmayer
423aaccd3f PD: rename getUpToFaceFromLinkSub to getFaceFromLinkSub 2022-07-16 15:59:54 +02:00
Uwe
eec258ab37 [FEM] enable to run Elmer multi-threaded
- this needs proper testing, especially on a non-Windows system

- note that for some tasks multi-threading requires non-standard additional solvers like MUMPS. Ideally the user should be informed about this, depending on the equations he uses. But this should not block this PR, meaning to use multi-threading in general.
2022-07-16 14:59:25 +02:00
wmayer
74e77f0191 Part: replace PyObject_Not with Base::asBoolean 2022-07-16 14:10:34 +02:00
wmayer
ab6c75fad9 Core: replace PyObject_IsTrue with Base::asBoolean 2022-07-16 14:04:05 +02:00
wmayer
9984d6bf86 Fem: replace PyObject_IsTrue with Base::asBoolean 2022-07-16 13:37:55 +02:00
wmayer
76c8dfa452 Import: replace PyObject_IsTrue with Base::asBoolean 2022-07-16 13:37:12 +02:00
wmayer
936bc03959 Mesh: replace PyObject_IsTrue with Base::asBoolean 2022-07-16 13:33:18 +02:00
wmayer
b6494085b4 Part: replace PyObject_IsTrue with Base::asBoolean 2022-07-16 13:31:10 +02:00
wmayer
9c9d053147 Path: replace PyObject_IsTrue with Base::asBoolean 2022-07-16 12:44:38 +02:00
wmayer
832bdaa7dd Sketch: replace PyObject_IsTrue with Base::asBoolean 2022-07-16 12:41:53 +02:00
wmayer
a34911605c Base: add convenience function to convert PyObject_IsTrue to a boolean 2022-07-16 12:41:01 +02:00