Commit Graph

30619 Commits

Author SHA1 Message Date
Abdullah Tahiri
1a6ed6cd76 Sketcher: command - review code improvements 2023-02-25 23:13:55 +01:00
Abdullah Tahiri
52a92e1915 Sketcher: Grid Command - Correct dependencies 2023-02-25 23:13:55 +01:00
Abdullah Tahiri
5a0e7d4ee3 Sketcher: Rewrite grid command
==============================

Fix unresolved issues:
https://github.com/FreeCAD/FreeCAD/pull/7754/files#r1025493443
https://github.com/FreeCAD/FreeCAD/pull/7754/files#r1019077589
https://github.com/FreeCAD/FreeCAD/pull/7754/files#r1025502204

Summary:
- EventFilter unnecessary in light of new implemented signal aboutToshow. The data of the drop-down action is updated only when necessary (when it is going to be shown).
- Structure of individual commands under drop-down simplified to a single action, rendering the need for groupcommands obsolete, while keeping all the grid related controls and
the logic for controlling the grid in a single action class.
- Reduce the complexity and overload of isActive to the bare minimum (determining if it is active and updating the icon to the right icon if so).

Refactor:
- Better name for utils functions, as when a DSH is active, the edit mode VPSketch is a data member of DSH, sketchgui (so this function is not really necessary when the DSH is active).
2023-02-25 23:13:55 +01:00
Abdullah Tahiri
5244e28565 Gui: ActionGroup - aboutToShow and aboutToHide
==============================================

ActionGroup may integrate a drop down menu (internally a QMenu).

QMenu has signals aboutToShow and aboutToHide, which are called just before showing/hiding the menu.

This commit extends ActionGroup by providing corresponding signals.

An ActionGroup can be added to more than one toolbar and thus creates more than one menu. So, it can theoretically
happen that you have opened a menu and click on another menu. For this reason, the menu is passed as argument:

void aboutToHideMenu(QMenu*);
void aboutToShowMenu(QMenu*);
2023-02-25 23:13:55 +01:00
Abdullah Tahiri
816fa3fe3e Sketcher: Refactor miscelaneous command isActive() 2023-02-25 23:13:55 +01:00
Paddle
78333e7eab Sketcher: Grid coin manager: fix includes 2023-02-25 23:13:55 +01:00
Paddle
2cba01586a Sketcher: Grid rework. Include:
- Adding 'auto spacing' option.
    - Drawing grid dynamically on viewer area only.
    - Moving code to coinManager.
    - Adding a 'grid tool' to sketcher-edit-mode toolbar.
2023-02-25 23:13:55 +01:00
Paddle
7f18faae7d Sketcher: Remove grid settings from Edit Control widget. 2023-02-25 23:13:55 +01:00
Paddle
0a78933685 Core: View3DInventorViewer, add 3 functions:
- getDimensions
- getMaxDimension()
- getCenterPointOnFocalPlane()
2023-02-25 23:13:55 +01:00
Uwe
faca6b2e40 [Gui] fixes for NaviCube parameters
- add missing routines to save default values

- also fix color read in (transparency was read in wrong order)
2023-02-25 18:56:27 +01:00
Uwe
4adf98e369 [Gui] add UI to change the NaviCube button size
- it was frequently requested and people now even published videos since I documented this hidden feature in the Wiki.
However, for a user it is a nightmare without a UI and users who like a bright background need to change the button color to keep the buttons visible.
2023-02-25 15:28:51 +01:00
luzpaz
e5cdd9a80e [Material] fix grammar 2023-02-25 09:59:24 +01:00
luzpaz
5c6ec58709 [Fem] fix grammar 2023-02-25 09:59:24 +01:00
Chris Hennes
543a99acd2 Addon Manager: Linter cleanup of utilities 2023-02-24 21:58:55 -06:00
Chris Hennes
97c873810b OpenSCAD: Linter cleanup 2023-02-24 21:58:39 -06:00
Uwe
77b7af3e60 [Gui] remove unused help button from preferences dialog
- is by default in the title bar of Qt dialogs, has to be removed explicitly when unused

- also fix too long code lines
2023-02-25 04:35:57 +01:00
Jolbas
6c3efbdb3b Fix create Rotation from scaled matrix
Support for creation of Rotation from matrices which is a combination of non uniform scale and a rotation
Fixes according to review
Scale -1 is Uniform, Not NoScaling
Fix hasScale() when negative scale
2023-02-24 20:33:40 -06:00
Roy-043
bdb6e1bd55 [Arch] fix Arch_Stairs stringer code (#8639) 2023-02-25 00:43:46 +01:00
Adrian Insaurralde Avalos
b15391752e Fix NaviCube default font incorrect display in pref. page 2023-02-25 00:00:56 +01:00
luzpaz
bf3f859736 OpenSCAD: lint OpenSCADUtils.py 2023-02-24 16:15:13 -06:00
Chris Hennes
f0b5cc07ae OpenSCAD: Remove old workaround code
Fixes #8621
2023-02-24 16:13:54 -06:00
0penBrain
09c1b9ce90 [BugFix] Expression: always add space char before unit when converting to string, fixes #8562 2023-02-24 19:44:44 +01:00
Uwe
9bc526c076 [Gui] attempt to fix getting NaviCube font name
- as discussed here: https://forum.freecad.org/viewtopic.php?t=76233 maybe the conversion to ".toLatin1()" is unsafe on some systems for non-ASCII characters on the font names
2023-02-24 16:58:38 +01:00
Uwe
cfc08e6dce [FEM] fixes for flow and electrodynamics examples
- define materials so that they are recognized by material handling as existing card
- use "electrodynamics" as equation because this is the common name for the physics of these examples
- fix typos
2023-02-24 16:50:42 +01:00
Uwe
d9244d5233 [Material] add heat parameters to aluminum alloys 2023-02-24 16:46:40 +01:00
Uwe
8c66538447 [FEM] fix for electrostatics examples
- define Air so that it is recognized by material handling as existing card
2023-02-24 16:44:49 +01:00
wmayer
4a390ddeb6 PD: refactor the constructor of TaskDialogPython 2023-02-24 16:35:51 +01:00
Uwe
45eff3aaed [FEM] add example for magnetostatics 2023-02-24 16:32:11 +01:00
Roy-043
63cb23d1fd [Draft] increase number spinboxes max in array task panels to 1 million (#8628)
The default max for spinboxes is 99. This PR increases it to 1 million for the number spin boxes of the array task panels.
2023-02-24 16:16:46 +01:00
Roy-043
19813124c3 [Arch] Arch_Stairs TreadDepth was based on unprojected edge (#8613) 2023-02-24 11:01:45 +01:00
0penBrain
c24f2fc09b [BugFix] Part: fix XSkew+YSkew editing not took into account for cylinders 2023-02-24 10:06:36 +01:00
0penBrain
dfe4c35600 [BugFix] Sketcher: correctly handles angle strings displayed at cursor for all locales, fixes #8611 2023-02-24 10:05:57 +01:00
Chris Hennes
311a15bc9f OpenSCAD: Modify wording of task dialog buttons
Fixes #8619
2023-02-23 22:59:13 -06:00
Chris Hennes
89e787b5a5 OpenSCAD: Translate file dialogs
Fixes #8618
2023-02-23 22:08:22 -06:00
Chris Hennes
a2674f24af OpenSCAD: Support CSG loads from Load button
Fixes #8617.
2023-02-23 21:59:40 -06:00
Uwe
ad1f9cd0c4 [Part] fix encoding bug
- fixes the regression by #7255 -> the degree sign cannot be decoded as Latin1
2023-02-24 04:07:21 +01:00
Uwe
bb6b1979f6 [Material] remove unused Help button in editor dialog 2023-02-24 03:47:19 +01:00
Uwe
a8a646f165 [FEM] improve pvtu file filtering
- catch case of only 2D objects
- use vtkDataSet as input for all filters
2023-02-24 03:46:47 +01:00
sliptonic
5f3e781dbf Merge pull request #8563 from dresco/AdaptiveOutline
[Path] Adaptive - improve 'use outline' logic
2023-02-23 12:33:50 -06:00
sliptonic
359e559320 Fixes #8517
Avoid error in test log
2023-02-23 18:42:52 +01:00
Bernd Hahnebach
65938f9bc2 Arch: building part object, use IFC standard typ as initial IfcType 2023-02-23 16:55:28 +01:00
Bernd Hahnebach
2e5c518cec Arch: IFC export, fix export break if undefined building part and IFC4 is used 2023-02-23 16:49:17 +01:00
wmayer
dd23698cf2 Gui: handle language change events in task dialogs 2023-02-23 16:38:45 +01:00
wmayer
d2741d298c Gui: enable language change by default 2023-02-23 16:38:45 +01:00
wmayer
985919c7b4 Gui: expose more methods of UiLoader to Python 2023-02-23 16:38:45 +01:00
0penBrain
569154b73f Base: introduce 'getSafeUserUnit' that fallbacks to full precision and internal unit ...
... in case unit schema would zero a non-zero quantity

 For example, using '1 mil' with UnitsSchemaImperialDecimal schema
2023-02-23 15:22:07 +01:00
0penBrain
257629f9c7 PartDesign: better quantity values handling for primitives 2023-02-23 15:22:07 +01:00
0penBrain
31ecac57af Part: better quantity values handling for primitives 2023-02-23 15:22:07 +01:00
0penBrain
5bf522ebcf [Bugfix] Gui: fix bug in expression completer tokenizing, fixes #8590 2023-02-23 13:49:03 +01:00
Chris Hennes
91d553139d Gui: Fix use of undocumented init() function 2023-02-23 13:26:26 +01:00