kindred/create
1
1
Fork 0
Code Issues 31 Pull Requests 1 Actions 3 Packages Projects 9 Releases 2 Wiki Activity
28,213 Commits 41 Branches 6 Tags
1db77d367c5485bac9b10a6b07a0478c7bd8ea0a
Commit Graph

3324 Commits

Author SHA1 Message Date
luz paz
8939e3a2eb Path: remove superfluous 'pass' per LGTM 
ref: https://lgtm.com/rules/910088/
 2022-03-19 20:06:48 -04:00
sliptonic
06959ededb Merge pull request #6575 from Russ4262/fix/rebuild_empty_job_with_gui 
Path: Extend Job integrity check to GUI side, issue #6207 [Bug]
 2022-03-19 15:44:28 -05:00
sliptonic
94c32d9a46 Merge pull request #6590 from sliptonic/feature/warnlegacy 
[Path]  Warn user if enabling legacy tools
 2022-03-18 10:46:42 -05:00
wmayer
9160f06e1c Base: rename BaseExceptionFreeCADError to PyExc_FC_GeneralError 2022-03-17 14:45:48 +01:00
wmayer
d69defaa3c Py: replace BaseExceptionFreeCADError with more suitable exception types 2022-03-17 13:54:23 +01:00
Russell Johnson
b06389edb2 Path: Change action to warning with option for action. 2022-03-16 11:47:51 -05:00
Russell Johnson
70d5a422f7 Path: Correct comment spelling 2022-03-16 11:40:24 -05:00
Russell Johnson
e4286139db Path: Extend Job integrity check to GUI side, issue #6207 [Bug] 
This commit adds a simple `_jobIntegrityCheck()` method to verify that a model and tool exists within the Job object, when interacting with the Task Panel.  If either is missing, the appropriate tab is activated in the task window, and the appropriate edit window is opened for the user, with messages printed in the report view window.

Add check for existence of `SetupSheet` property of empty Job object.

These changes improve upon fixes in PR #5008 and related bug fixes.
 2022-03-16 11:40:23 -05:00
sliptonic
de94520d9b [Path] Warn user if enabling legacy tools 
Warn user if opening job that contains legacy tools
 2022-03-15 11:05:20 -05:00
sliptonic
b640a1d106 Merge pull request #6577 from Russ4262/fix/millface_removalshapes 
Path: Fix `self.removalshapes` declaration [Bug]
 2022-03-15 09:26:39 -05:00
sliptonic
a70adce220 Merge pull request #6576 from Russ4262/fix/cancel_new_dressup_cleanup 
Path: Fix automatic `commitTransaction()` calls, issue #6149 [Bug]
 2022-03-15 09:25:43 -05:00
sliptonic
75fee12d7b Merge pull request #6571 from Russ4262/fix/tag_dressup_radius_value 
Path: Fix inconsistent float type usage, issue #6170 [Bug]
 2022-03-14 09:26:24 -05:00
Yorik van Havre
6efe74a554 Merged crowdin translations 2022-03-14 12:21:01 +01:00
Yorik van Havre
583206d47c Updated master ts files 2022-03-14 12:13:40 +01:00
wmayer
0054cbddaa Fix coverity issue: 
* CID 332682: Resource leak
* CID 350607: Resource leak
* CID 332677: Resource leak
 2022-03-14 11:35:04 +01:00
Russell Johnson
ac4c7bb954 Path: Fix self.removalshapes declaration [Bug] 
Prior to this fix, the `self.removalshapes` variable is not declared if `obj.Base` does not exist, or is empty.  This moves the declaration up in scope to the method level.
 2022-03-12 22:34:03 -06:00
Russell Johnson
20e3657125 Path: Fix automatic commitTransaction() calls, issue #6149 [Bug] 
This commit removes the automatic committal of transactions when activated with GUI command.  The committal of the transaction is executed with the `accept()` and `reject()` methods of the respective task panel.
 2022-03-12 22:05:04 -06:00
Russell Johnson
1fc468912c Path: Improve value assignment syntax for radius 2022-03-12 20:00:40 -06:00
sliptonic
b0d19d28d7 Merge pull request #6566 from Russ4262/fix/boundary_dressup_begin_safeheight_retraction 
Path: Correct beginning retraction to safe height in Boundary Dressup, issue #6279 [Bug]
 2022-03-12 19:05:39 -06:00
Russell Johnson
a2fb5b66fa Path: Fix radius type inconsistency, issue #6170 [Bug] 
Make `self.radius` a float type throughout since other methods and functions treat it as such.
 2022-03-12 18:29:21 -06:00
Matti Eiden
af8b6fba07 PathArray: Support applying PathArray on Dressups 2022-03-12 22:31:16 +02:00
Russell Johnson
dd76cabb34 Path: Correct beginning retraction to safe height feed rate, issue #6279 [Bug] 
This commit changes the feed rate of the beginning retraction from G1 at Feed to a G0 Rapid rate.  This initial command is causing a problem with the Tag Dressup due to the first move being a G1 to Safe Height.
 2022-03-12 12:18:09 -06:00
Uwe
48b2c3da12 [Path] fix a typo 2022-03-12 02:24:44 +01:00
Uwe
bc09020e8b [Path] 2nd part of the Git fix attempt 
renaming it back
 2022-03-12 02:01:29 +01:00
Uwe
6901b9cf63 [Path] next attempt to fix Git error by renaming 
use lowercase letters fro file ending like it is also in the CMake file
 2022-03-12 02:00:40 +01:00
Uwe
b6f3295201 [Path] try to silence a git error with a file 
Git has issues with this file telling me it is corrupted and its file ending is wrong (in Git lowercase, in the file uppercase).

The attempt is to just to save save it with FC 0.20.
 2022-03-12 01:55:37 +01:00
sliptonic
e1ce0c7695 Merge pull request #6552 from Russ4262/fix/leadin_leadout_simulation 
Path: Fix Leadin-Leadout dressup simulation related to arcs [Bug]
 2022-03-11 10:06:42 -06:00
sliptonic
0bc9edeb50 Merge pull request #6541 from Russ4262/fix/ramp_entry_dressup 
Path: Fix enumeration dictionary error [Bug]
 2022-03-11 10:04:53 -06:00
sliptonic
182cabcfbb Merge pull request #6530 from sliptonic/bug/6114 
[Path] Fix minor non-modal bug.  Fixes 6114
 2022-03-11 10:03:53 -06:00
sliptonic
5eb170df1a Merge pull request #6536 from J-Dunn/master 
PATH: Fix tool shapes for zero dimension bugs
 2022-03-11 09:56:52 -06:00
Russell Johnson
48e4622193 Path: Fix Leadin-Leadout dressup simulation related to arcs 
Add missing "Z" and "K" parameters for arc commands to appease Path simulator.
 2022-03-10 20:05:52 -06:00
Russell Johnson
6b8b870e21 Path: Fix enumeration dictionary error 
This commit corrects an incorrect dictionary key in the enumeration dictionary updated with recent translation fixes.
 2022-03-09 21:03:34 -06:00
wmayer
8d3c66cf18 Core/Mod: modernize C++11 
* use nullptr
 2022-03-09 21:55:31 +01:00
J-Dunn
d425a5562b Add files via upload 
Current V-bit totally hangs FC when cutting edge height is zero. Tip diameter of zero also causes errors. 
These two tool shapes add 1um offsets to various dimensions to prevent user entered parameters from inducing zero dimensions which make the solver barf.  
The rotational geometry has also been simplified. 
Some are non critical but tip diam increment is a work around. To be rigorous, the fixed value such ideally be relative to some dimension of the job, not the arbitrary constant. Hopefully 1um will be suitable for most FC applications unless someone is doing uv lithography masks ;) 
https://forum.freecadweb.org/viewtopic.php?f=15&t=54880&p=479739#p479739
This replaces earlier PR where these files were not uploaded. 
https://github.com/FreeCAD/FreeCAD/pull/4491
 2022-03-09 12:13:40 +01:00
sliptonic
faec9e36c2 fixes #5954 
Make headers less confusing and ambiguous
 2022-03-08 08:40:05 -06:00
sliptonic
51b9d40010 fixes 6114 
replaces DlgJobChooser with QInputDialog.
 2022-03-07 17:51:00 -06:00
Uwe
bda12907de [Gui] rename the Qt header list 2022-03-07 20:35:38 +01:00
wmayer
1ca7429705 Gui: Optimize includes to reduce compile time 2022-03-07 20:29:18 +01:00
Yorik van Havre
7653a9473d Merged crowdin translations 2022-03-07 14:55:22 +01:00
Yorik van Havre
5aec63d704 Updated master translation files 2022-03-07 14:49:13 +01:00
wmayer
95c70e7f4c App: use forward declarations 2022-03-04 21:09:46 +01:00
sliptonic
693315755f Merge pull request #6485 from mlampert/feature/external-thread-milling 
Path: Feature/external thread milling
 2022-03-04 12:52:31 -06:00
sliptonic
0d98056384 Merge pull request #4911 from sliptonic/feature/nopathjob 
[Path] Make Job and Operation visibility more natural
 2022-03-04 12:51:25 -06:00
Markus Lampert
c0bb11384c Split out thread milling generator into its own file 2022-03-04 10:42:34 -08:00
sliptonic
228fce273b black format 2022-03-04 10:42:34 -08:00
Markus Lampert
79779ac96f Fixed unit tests 2022-03-04 10:42:34 -08:00
Markus Lampert
d80c4ce399 Removed debugging gates 2022-03-04 10:42:34 -08:00
Markus Lampert
f082f40473 Fixed UI update upond changing the thread type 2022-03-04 10:42:34 -08:00
Markus Lampert
238bb7c2bb Fixed multi pass for external threads with proper lead in/out 2022-03-04 10:42:34 -08:00
Markus Lampert
46827df206 Changed passes for constant tool engagement 2022-03-04 10:42:34 -08:00