Commit Graph

1808 Commits

Author SHA1 Message Date
Markus Lampert
1f839e5ea1 Reuse existing QuantitySpinBox'es in order to avoid segfault on focus change. 2020-12-17 23:01:55 -08:00
Markus Lampert
b2dce8c76a Allowing QuantitySpinBox to be reused for different attribute; using properties to get values to work around build differences. 2020-12-17 22:56:42 -08:00
Markus Lampert
be221dd25d Rearranged BitTool shape update so dependent ops don't execute with invalid tool. 2020-12-17 20:27:42 -08:00
Markus Lampert
1a2249387e Make BitShape read/writeable, so the tool can be edited when shared to a different system 2020-12-17 19:59:44 -08:00
Markus Lampert
7e2f088833 Hide document when loading a ToolBit. 2020-12-17 19:55:59 -08:00
Markus Lampert
6b5a99319a Only update the shape if it has changed. 2020-12-17 19:14:44 -08:00
sliptonic
417dc2519a Merge pull request #4143 from mlampert/bugfix/vcarve-depth
Path: Bugfix/vcarve depth
2020-12-14 17:18:30 -06:00
sliptonic
98fa847820 Merge pull request #4141 from gauna85/PathToolcontroller
Path: Added missing signal-connection causing spindle speed not to be updated using ToolControllerDlg Bug 4479
2020-12-14 12:28:56 -06:00
Markus Lampert
19cb93302a Adding g0 to safety to base op so it's applied to all ops 2020-12-13 15:00:05 -08:00
Stefan Endres
9930a020c2 Path: Added missing signl-connection causing spindle speed not to be updated using ToolControllerDlg 2020-12-13 22:12:08 +01:00
Markus Lampert
1e4ba68d4b meld h and v speeds for v-carve commands depending on incline 2020-12-13 11:31:58 -08:00
Markus Lampert
202608e77b Consistent TC naming/labeling, regardless of how created. 2020-12-13 11:31:58 -08:00
Markus Lampert
c9ee75fd4c Fixed thread-milling icon reference. 2020-12-13 11:31:58 -08:00
Markus Lampert
1622a8bcaf Fixed v-carve depth calculation in the presence of a bottom diameter, added unit tests and cleaned up the v-bit parameter naming. 2020-12-13 11:31:58 -08:00
Stefan Endres
c4f3951828 Path: Sort edges before splitting at selected vertex 2020-12-13 19:27:13 +01:00
Markus Lampert
4aeac73b39 More py2 special handling for unit tests 2020-12-03 19:39:33 -08:00
Markus Lampert
371daca128 Added consistent encoding headers and fixed whitespaces 2020-12-03 18:15:36 -08:00
Markus Lampert
d098547e17 Fixed unit test breakage for py2 2020-12-03 18:15:36 -08:00
markus
deb03f678d Use new ToolBits (and only those) for thread milling. 2020-12-03 18:15:36 -08:00
markus
beb4f2e011 Filter all TCs for suitability for a given op. 2020-12-03 18:15:36 -08:00
markus
8fb1cd078b Catch exception if shape file does not include a thumbnail. 2020-12-03 18:15:36 -08:00
Markus Lampert
f0a0a9a70a Cleaned up properties 2020-12-03 18:15:36 -08:00
Markus Lampert
ac4af399c3 Added support for imperial threads to thread milling 2020-12-03 18:15:36 -08:00
Markus Lampert
885036553b Added actual thread milling path generation. 2020-12-03 18:15:36 -08:00
Markus Lampert
310f72145d Added thread milling radii calculation 2020-12-03 18:15:36 -08:00
Markus Lampert
ab9bf8c222 Add basic thread milling op 2020-12-03 18:15:36 -08:00
sliptonic
9f930af3fe Merge pull request #4097 from Russ4262/millface_fix
Path: Millface fix - Address rounding issue
2020-12-03 13:29:14 -06:00
sliptonic
1951c20f66 Add finaldepth property.
Operation now sets start/final depth more reasonably.
Will not violate the finaldepth.
2020-12-02 15:05:08 -06:00
Russell Johnson
6200f1afc0 Path: Swap list instantiation per senior devs specifications 2020-12-02 11:34:58 -06:00
Russell Johnson
361e5edc29 Path: Instate obj.removalshape property for debugging purposes 2020-12-02 11:34:58 -06:00
Russell Johnson
ffa9b78df1 Path: Address problem with rounding issue
Translate removal shape down into buffer zone to offset rounding issue.
2020-12-02 11:34:58 -06:00
sliptonic
6c3dc29194 Merge pull request #4071 from Russ4262/fix_rotational_drilling_depth
Path: Fix Drilling Op issues when using rotation feature
2020-12-02 10:22:01 -06:00
sliptonic
292a711922 Merge pull request #4096 from sliptonic/bug/toolbit
[path]  make toolbit reject invalid filenames and prompt user for valid toolbit working location
2020-12-02 08:51:49 -06:00
luzpaz
cb3326b8cb Path: Added revision suggested by @cheenes
Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org>
[skip ci]
2020-12-02 06:57:56 -05:00
luz paz
141d018781 Path: fix translation to reflect the correct context
[skip ci]
2020-12-02 06:57:28 -05:00
luz paz
10790ed701 Path: Added missing Path_Custom in previous commit 2020-12-02 06:57:28 -05:00
luz paz
aeafcec125 Path: Change filenames in the rest of the Path code
Reflects changes in 
* PathOpGui.SetupOperation()
* GetResources()
* sPIxmap
* pixmap
* *.UI files

Also contains minor translation context renames (these were edits made near to original intent of this commit)
2020-12-02 06:57:28 -05:00
sliptonic
5a0e0bada6 PR review suggestions and fixes 2020-12-01 09:43:45 -06:00
Russell Johnson
3cc32fc991 Path: Delete unnecessary comment block 2020-11-30 21:09:58 -06:00
Russell Johnson
50ad479bfb Path: Replace all-caps variable name 2020-11-30 21:09:58 -06:00
Russell Johnson
b0916dd6bc Path: Simplify ActiveDocument references 2020-11-30 21:09:58 -06:00
Russell Johnson
ad6645f492 Path: Fix rotational errors and organize/simplify some rotational code
Fix rotational alignment and drilling depth issues for rotational drilling ops.
Issues identified in forum at https://forum.freecadweb.org/viewtopic.php?style=3&f=15&t=52262.
Path:
2020-11-30 20:57:25 -06:00
Russell Johnson
ce65794a10 Path: Clean up comments and simplify one code block 2020-11-30 20:57:25 -06:00
Russell Johnson
0a59b5307c Path: Synchronize methods with same in PathAreaOp module
The affected methods exist in the PathAreaOp module.  This commit synchronizes the versions here with those.
2020-11-30 20:57:25 -06:00
Russell Johnson
6bbc56cd4b Path: Apply the user's Final Depth value 2020-11-30 20:57:25 -06:00
sliptonic
411562361b fix ui bugs 2020-11-30 15:35:30 -06:00
sliptonic
daea1f53da [path] make toolbit reject invalid filenames
help user create toolbit working location
2020-11-30 15:32:28 -06:00
sliptonic
a42355939a Merge pull request #4073 from Russ4262/fix_slot
Path: Fix arc slotting direction in Slot operation
2020-11-23 15:08:40 -06:00
sliptonic
152351e8a8 Merge pull request #4014 from sliptonic/feature/toolbitdock
[PATH] Feature/toolbitdock
2020-11-23 10:12:58 -06:00
Russell Johnson
37cd09e7ae Path: LGTM cleanup 2020-11-22 18:27:21 -06:00