kindred/create
1
1
Fork 0
Code Issues 30 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
28,169 Commits 41 Branches 6 Tags
214e716a8fd3cc49703a4815d0028efd62f8596d
Commit Graph

2844 Commits

Author SHA1 Message Date
Matthijs Kooijman
214e716a8f Draft: Simplify using getattr instead of hasattr 
Using the default argument supported by getattr makes this code a bit
simpler and probably (ever so slightly) faster.

See https://forum.freecadweb.org/viewtopic.php?f=10&t=58611 for previous
discussion.

This is not an exhaustive change, these are just a few I encounted while
working with the code.
 2022-03-22 14:46:50 +01:00
Matthijs Kooijman
be69ec5e00 Draft: Fix mixup of TextAlignment vs Justification for Labels 
TextAlignment is the vertical alignment, while Justification is the
horizontal alignment. here, get_text was passed the vertical, while it
expected the horizontal. This caused the alignment of a Label to be
wrong in the resulting SVG (e.g. in a TechDraw draft view).

This seems to have been broken since SVG support for Labels was first
introduced in commit 3391a5ea4b (Initial work, only text (no lines)).
 2022-03-22 14:46:50 +01:00
Matthijs Kooijman
fd8475b1c6 Draft: Fix SVG generation for label objects 
Label objects would produce invalid SVG XML, because the stroke-linecap
property was added as if it was a style (with : and ;), but it was
inserted in the XML tag directly, rather than inside the style attribute
value. The invalid SVG prevented for example a TechDraw draft view from
rendering when it contained a label.

This was added in commit d8c74c06fd (Draft: Using square endcaps for
lines in SVG output).

This stroke-linecap is supported both as a presentation attribute inside
the style or a XML attribute, so for consistency with the surrounding
attributes, it is made a normal attribute, rather than putting it inside
the style.

See also https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/stroke-linecap
 2022-03-22 14:38:36 +01:00
Matthijs Kooijman
f49b38a595 Draft: Fix incorrect use of in operator 
Looking at the surrounding code, this should be `==` rather than `in`.
The code does work as intended, because a string is always a substring
of itself, but better to fix it anyway.

Seems this was broken since this code was first introduced in commit
94b0fe1599 (Draft: clean up ViewProviderLabel class)
 2022-03-20 14:45:52 +01:00
Yorik van Havre
f636ff9df4 Merge pull request #6544 from Roy-043/Draft-Fix-Angle-Lock-for-non-XY-workingplane 
Draft: Fix Angle Lock for non-XY workingplane
 2022-03-17 15:46:52 +01:00
flachyjoe
e6f3f4ba57 Don't take grid into account when View_FitAll 2022-03-16 17:30:25 +01:00
Yorik van Havre
6efe74a554 Merged crowdin translations 2022-03-14 12:21:01 +01:00
Yorik van Havre
583206d47c Updated master ts files 2022-03-14 12:13:40 +01:00
wmayer
0054cbddaa Fix coverity issue: 
* CID 332682: Resource leak
* CID 350607: Resource leak
* CID 332677: Resource leak
 2022-03-14 11:35:04 +01:00
Civil Guy
6a00ef0ed1 Minor spelling fixes 2022-03-11 13:57:03 +01:00
Roy-043
3844c7296b Draft: Fix Angle Lock for non-XY workingplane 2022-03-10 17:44:38 +01:00
Yorik van Havre
dd1b0e0a3d Draft: Fixed error in SVG rendering of LinkedArrays - fixes #6516 2022-03-10 13:34:18 +01:00
Yorik van Havre
7653a9473d Merged crowdin translations 2022-03-07 14:55:22 +01:00
Yorik van Havre
5aec63d704 Updated master translation files 2022-03-07 14:49:13 +01:00
wmayer
2dc1a4c412 Mod: add string header to dxf.h 2022-03-01 15:13:34 +01:00
wmayer
831d569f52 Draft, Import, area: include iosfwd instead of iostream if forward declarations are sufficient 2022-03-01 12:37:00 +01:00
Roy-043
039457bdd6 Draft: Fix Draft_Line Length is zero bug 
When changing the Length of a Draft_Line to f.e. 0.5 the input of the zero resulted in a zero length line.
 2022-02-24 12:26:42 +01:00
Yorik van Havre
c9ea59df60 Merge pull request #6406 from marioalexis84/draft-drawing_techdraw 
Draft: Replace Drawing functions with TechDraw functions
 2022-02-21 11:10:36 +01:00
Roy
fae36b2da0 Draft: Housekeeping: call 'make' functions with new name (4) 2022-02-20 22:31:08 -06:00
marioalexis
3f67ee78f7 Draft: Replace Drawing functions with TechDraw functions 2022-02-20 16:34:29 -03:00
Yorik van Havre
18ab2c80fb Merge pull request #6355 from Roy-043/Draft-Housekeeping-call-'make'-functions-with-new-name-(3) 
Draft: Housekeeping: call 'make' functions with new name (3)
 2022-02-17 11:40:59 +01:00
wmayer
a5e561b31d Base: fix Matrix4D::hasScale 
* If all column vectors of the 3x3 sub-matrix are equal the function incorrectly claims that it's uniform scaling.
* Detect also non-uniform scaling and if was applied from the left or right side
* Replace the int with an enum and expose it to Python
* Add several new unit tests
 2022-02-15 21:05:11 +01:00
Yorik van Havre
19b89b1085 Merged crowdin translations 2022-02-14 12:31:57 +01:00
Yorik van Havre
67dcb21efd Updated ts files 2022-02-14 12:31:47 +01:00
Roy
effd40ec99 Draft: Housekeeping: call 'make' functions with new name (3) 2022-02-13 11:01:15 +01:00
Roy
5bbf59141e Draft: Housekeeping: call 'make' functions with new name, continued 2022-02-12 19:34:57 +01:00
wmayer
09a05a9cd0 Part: Circle variable name change to create consistency 
Change variable names of the Circle from Angle0 to Angle1 to create consistency with all other named angle variables
 2022-02-11 18:28:58 +01:00
Yorik van Havre
1e33533539 Merge pull request #6337 from Roy-043/Draft-Housekeeping-call-'make'-functions-with-new-name 
Draft: Housekeeping: call 'make' functions with new name
 2022-02-11 12:00:23 +01:00
Yorik van Havre
206cc71308 Merge pull request #5496 from Roy-043/Draft-fix-isClosed-bug-in-offsets.py 
Draft: fix isClosed bug in offsets.py
 2022-02-11 11:42:11 +01:00
Roy
6b808987ad Draft: Housekeeping: call 'make' functions with new name 2022-02-10 16:44:37 +01:00
marioalexis
4160588fc6 Draft: Fix SoSeparator not deleted 2022-02-09 19:07:10 -03:00
Roy
455adec471 Fixed an error in the connect function. Point v2 could be undefined. 2022-02-09 22:06:36 +01:00
Roy-043
c236649595 Draft: fix isClosed bug in offsets.py 
Use built-in isClosed() function instead of isReallyClosed which is buggy.
 2022-02-04 15:03:04 +01:00
Yorik van Havre
8492cfb9eb Draft: Upgrade: make compound when unable to turn edges to wire - fixes #3483 2022-02-03 16:13:01 +01:00
0penBrain
9db4f613c9 [Draft] Fix widget property in preference UI 2022-02-02 15:46:33 +01:00
Yorik van Havre
bcfcd0a337 Merge pull request #5449 from mwganson/pointarray 
Draft: pointarray set Count property during execute
 2022-02-01 13:14:06 +01:00
Yorik van Havre
d0aacbd064 Merge pull request #5427 from 0penBrain/draftGrid 
[Draft] Grid size as quantity rather than double
 2022-02-01 13:13:40 +01:00
Yorik van Havre
0d1f76d53a Merge pull request #5476 from Roy-043/Draft-Fix-gui_edit.py-Y-is-zero-input-bug 
Draft: Fix-gui_edit.py Y is zero input bug
 2022-02-01 13:09:56 +01:00
Yorik van Havre
b0b1c0afbb Merged crowdin translations 2022-02-01 12:59:42 +01:00
Yorik van Havre
dc9e3e5326 Updated ts files 2022-02-01 12:54:40 +01:00
Roy-043
89cf2f74be Draft: Fix-gui_edit.py Y is zero input bug 
Entering a Y=0 coordinate when editing points caused an error.
 2022-01-31 22:15:38 +01:00
Roy-043
45ef3ed2fb Update gui_orthoarray.py 2022-01-28 14:01:42 -06:00
Roy-043
acf88af89e Update gui_beziers.py 
Oops copy-paste error... Fixed.
 2022-01-28 14:01:42 -06:00
Roy-043
fd2f964b6b Update gui_beziers.py 2022-01-28 14:01:42 -06:00
Roy
d5615fc6a6 Draft: Fix several translation issues 2022-01-28 14:01:42 -06:00
mwganson
43c0ef43e6 Draft: pointarray set Count property during execute 2022-01-26 20:32:31 -06:00
Yorik van Havre
b3e2c87530 Merged crowdin translations 2022-01-26 14:15:14 +01:00
Yorik van Havre
630215c721 Regenerated ts files 2022-01-26 13:59:39 +01:00
Yorik van Havre
e6b7c0e5f9 Draft: fixed tstroke error in get_svg 2022-01-25 11:16:44 +01:00
luz paz
4fb91e4f02 Fix various typos 
Found via `codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,anormal,apoints,ba,beginn,behaviour,bloaded,bottome,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childrens,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,inout,ist,itsel,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oce,oder,ontop,orgin,orginx,orginy,ot,pard,parm,parms,pres,programm,que,rady,recurrance,ro,rougly,seperator,serie,sinc,strack,substraction,te,technic,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml,./build/doc/SourceDocu`
 2022-01-24 14:45:49 -06:00