Commit Graph

75 Commits

Author SHA1 Message Date
Kacper Donat
216166d853 TechDraw: Replace dynamic_cast with qobject_cast 2025-04-26 14:23:25 +02:00
Chris Hennes
72d8a7be71 Merge pull request #19411 from benj5378/enums2
TechDraw: hard type enums, part 2
2025-03-03 10:37:21 -06:00
Chris Hennes
7f1c43a335 Merge pull request #19636 from kadet1090/color-in-base
Base: Move App::Color to Base
2025-03-02 16:36:40 -06:00
Benjamin Bræstrup Sayoc
e60c800a0b Remove magic number and hard type enums in ArrowPropEnum.h
- Remove currently present magic numbers
- Hard type enums, so magic numbers can no longer be introduced. We don't want people to introduce magic numbers.
2025-03-02 17:14:24 +01:00
wandererfan
d5317ead9e [TD]fix bad formatting 2025-02-23 09:14:23 -05:00
wandererfan
ae38fb51e2 [TD]lint removal 2025-02-23 09:14:23 -05:00
wandererfan
9ee3bd5629 {TD]Set Arrow end property at Dimension level. 2025-02-23 09:14:23 -05:00
Kacper Donat
a72a63232a Base: Move App::Color to Base
Every basic data type is stored in Base module, color is standing out as
one that does not. Moving it to Base opens possibilities to integrate it
better with the rest of FreeCAD.
2025-02-17 21:10:26 +01:00
Benjamin Nauck
dd6aa9f3c7 Prefer to use BaseClass's isDerivedFrom<T> over non template or Base::Type's
Regex based changes, manually verified
2025-01-27 16:08:18 +01:00
WandererFan
93aa3b312f [TD]Fix RichText parent in scene (fix #18283) (#18768)
* [TD]allow DrawViewAnno to be attached to another view

* [TD]allow image and spreadsheet attach to view

* [TD]ensure correct parent in scene

* [TD]refactor command helpers to separate file

- gathering the helpers in one place
- helper redundancy to be address in another change

* [TD]create symbol, spreadsheet, image with parent

* [TD]fix claimChildren for some views

- also includes many lint fixes
2025-01-06 18:11:25 +01:00
Roy-043
d6e9be45bb Correct tree icon for TechDraw_AreaDimension 2024-09-22 16:58:52 -05:00
PaddleStroke
e33c983614 TechDraw: Implement 'Area' dimension. 2024-05-06 18:42:28 +02:00
wandererfan
29cfe6db51 [TD]prevent fail on delete with open dialog 2024-03-14 21:45:16 -04:00
wandererfan
762e1b53ff [TD]Standard Line Styles - Gui components 2023-12-01 11:27:29 -05:00
wmayer
d150fa7164 modernize C++: avoid bind
In many cases std::bind() is kept because the code is much simpler
2023-08-08 21:10:16 +02:00
grubertechnic
46882287f2 [TechDraw] let arrow size of a dimension change due property task panel 2023-06-07 12:38:26 -04:00
Benjamin Bræstrup Sayoc
098cd44f21 [TechDraw] Add customizability for dimension line spacing 2023-04-15 10:20:38 -04:00
Benjamin Bræstrup Sayoc
411122dbb6 [TD]resolve merge conflicts re Preference retrieval #2 2023-04-10 23:34:05 -04:00
Benjamin Bræstrup Sayoc
ef5fc4f237 [TechDraw] Simplify return logic 2023-04-10 23:34:05 -04:00
Benjamin Bræstrup Sayoc
15fe52a04b [TechDraw] Simplify retrievement of user preferences
for all TechDraw files
2023-04-10 23:34:05 -04:00
wandererfan
1b547dff72 [TD]Refactor Dimensions for 3d upgrade
- separate validation, geometry and reference handling into
  individual files
- improve 3d reference geometry handling
- eliminate duplicate dim creation code

- add Dimension reference repair dialog

- Refactor formatting out of DrawViewDimension

- move dimension repaint control to ViewProvider
2023-01-07 16:32:03 -05:00
wandererfan
23dc64365b [TD]move makeAlignedPieces to separate thread
- correct ComplexSection rotation

- fix fail to load CS for some profiles and directions
2022-12-18 09:42:42 -05:00
wandererfan
74c1fed8a6 [TD]fix StackTop and StackBottom 2022-09-24 08:18:38 -04:00
wandererfan
fcef1cb174 [TD]implement view stacking 2022-09-07 16:06:54 -04:00
wandererfan
acf17905ed [TD]CI clang warnings 2022-09-05 17:48:38 -04:00
berniev
da9ebc572f Mod: redundant void 2 2022-08-08 10:27:50 +02:00
Benjamin Bræstrup Sayoc
fda3fd731f [TechDraw] Use inherited unsetEdit
Remove uneeded redefinitions of inherited functions
2022-08-04 10:02:47 -04:00
Benjamin Bræstrup Sayoc
23966513c7 [TechDraw] Remove uneeded redefinitions of inherited functions 2022-08-04 10:02:47 -04:00
Benjamin Bræstrup Sayoc
86dfd0a862 [TechDraw] Simplify code getting default line weights 2022-08-02 16:13:01 -04:00
Uwe
2e5e4dced8 [TD] Gui: remove some superfluous nullptr checks 2022-07-19 02:49:46 +02:00
Wanderer Fan
5d93fbe0bb [TD]fix ext line gap preference 2022-07-16 11:28:38 -04:00
Benjamin Bræstrup Sayoc
886f4fe1b9 [TechDraw] Improve readability of ViewProviderGeomHatch.cpp 2022-07-15 11:31:11 -04:00
Wanderer Fan
b6c20202cd [TD]adjustable extension line gap 2022-07-04 20:43:49 -04:00
wmayer
9b2b0e0acf modernize C++: replace boost::function with std::function 2022-06-30 20:31:55 +02:00
Wanderer Fan
56d289997c [TD]fix Dimension/Balloon movement 2022-06-02 16:33:25 -04:00
wmayer
fd8719c85c TD: [skip ci] activate PCH of TechDraw (Gui) and use forward declarations
For MSVC this reduces compile time by ~20%
2022-03-25 13:54:47 +01:00
wmayer
a99be14233 TD: modernize C++11
* use nullptr
2022-03-23 19:26:14 +01:00
Uwe
7daff0960f [TD] ViewProviders: remove unused includes
- also sort the includes
2022-02-18 04:43:32 +01:00
wmayer
8df497b08e Gui: move methods startDefaultEditMode() and addDefaultAction() to ViewProviderDocumentObject 2021-12-06 19:24:26 +01:00
Roy-043
5fd21f80da TechDraw housekeeping: TechDraw_LandmarkDimension icon fix (#5033)
TechDraw housekeeping: TechDraw_LandmarkDimension icon fix
2021-09-16 18:42:11 -05:00
wmayer
4327cd5ccb Mod: make sure to call the base class' handleChangedPropertyType 2021-09-15 14:07:32 +02:00
wmayer
3288c02eba TechDraw: fixes for dimension feature:
* reimplement ViewProviderDimension::setupContextMenu() to show menu item to start editing it
* fix TaskDimension::accept() and TaskDimension::reject()
2021-02-12 15:55:26 +01:00
donovaly
fc91b251ee [TD] add dialog to modify some dimension settings
also fix issue that tolerance could be set despite theoretically exact is true under some circumstances

also some wording improvements

also a minor fix to use 0.0 instead of DBL_MIN
2021-01-15 05:21:49 +01:00
donovaly
e8d76d49bf [TD] some fixes
- the setting "Standard and Style" only affects new dimensions, thus it must be italic

- fix bug that the Property 'LockPosition' appears for dimensions -> this is an option for views and thus must be hidden for dimensions

- since tolerances are in the vast majority fractions of a millimeter/inch, set its stepsize to 0.1
(I hope I did it right in handleChangedPropertyType.)

- fix inconsistent newlines in TaskBalloon.h

- improve wording for a heading
2021-01-10 00:29:34 +01:00
donovaly
a1915d313a [TD] make LineGroup selectable
At the moment one has to specify the LineGroup as string. But one doesn't know what groups exist. So one has to check the Wiki, learn there where the groups are defined and then open the definition file with a text editor.

This PR simplifies this by reading the existing groups out of the definition file and fill the combobox accordingly.
It also give the user info what the selected LineGroup defines via the tooltip.

A nice side effect is that no typos can occur since you don't have to enter the LineGroup name as text.
2020-12-03 17:24:49 +01:00
wandererfan
e80c576241 [TD]Centralize preference getters 2020-04-24 11:13:49 -04:00
donovaly
941ce9c43c CanDelete is necessary for dimensions
- therefore revert commit bd0bf690b53f8355400278a127524029d225dffb.
- handle balloons the same way
- fix line ending in ViewProviderProjGroupItem.cpp
2020-03-04 08:24:17 -05:00
donovaly
dc94f25fd4 ViewProviderDimension: remove unused function 2020-03-04 08:24:17 -05:00
donovaly
5a61baf07c [TD] handle object deletions better
see https://forum.freecadweb.org/viewtopic.php?p=366902#p366902
2020-03-04 08:24:17 -05:00
wandererfan
96e8f752be [TD]Landmark Dims initial impl 2020-02-25 17:21:00 -05:00