kindred/create
1
1
Fork 0
Code Issues 44 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
39,299 Commits 40 Branches 6 Tags
223877873b30c8387dfd50e111bbe009940d07e1
Commit Graph

524 Commits

Author SHA1 Message Date
PaddleStroke
d0da5f7969 Assembly: Pressing Esc while a task is active will not escape edit mode 2024-11-22 12:15:57 -05:00
haruka tsubota
cabdea2764 Add help message about customizing BOM export file format in Assembly workbench 2024-11-22 11:35:00 -05:00
Jiří Mácha
2eec246e95 Assembly: fixed defect in the migrationScript4 function 
The old CAD model created by the development version of FreeCAD
(in which the Assembly workbench was used) contained joints that,
for some reason, had an empty Joint Connector 1 reference (Reference1).

This was causing an exception and a crash of the Python function
called migrationScript4. The FreeCAD Report view contained:

23:28:29  pyException: Traceback (most recent call last):
  File "/FreeCAD/Mod/Assembly/JointObject.py", line 175, in onDocumentRestored
    self.createProperties(joint)
  File "/FreeCAD/Mod/Assembly/JointObject.py", line 181, in createProperties
    self.migrationScript4(joint)
  File "/FreeCAD/Mod/Assembly/JointObject.py", line 514, in migrationScript4
    if hasattr(joint, "Reference1") and joint.Reference1[0] is not None:
                                        ~~~~~~~~~~~~~~~~^^^
<class 'TypeError'>: 'NoneType' object is not subscriptable

This patch attempts to avoid such exceptions by validating the type of
the property variable before accessing it.
 2024-11-18 17:46:44 +01:00
PaddleStroke
a174d87fac Assembly: Store DocumentObject instead of mbdPart for the dragged parts. Fixing the bug where doDragStep was 50% of time failing to find the correct DocumentObject due to bundling. 2024-11-18 17:43:53 +01:00
Max Wilfinger
fc3996b53f Merge pull request #17637 from furgo16/patch-3 
Reword rigid/flexible sub-assemblies tooltip.
 2024-11-16 10:03:52 +01:00
Furgo
2577cc9cf0 Re-add the note about right click, with more context 2024-11-16 07:15:05 +01:00
Furgo
a5c7fc98ca Reword error log to be more verbose 2024-11-15 18:53:00 +01:00
wmayer
dbc9615308 Coverity scan: Uninitialized scalar variable 
* CID 350633
* CID 512344
* CID 514343
 2024-11-13 18:58:16 -05:00
Yorik van Havre
04f0e7a330 Merge pull request #17782 from wwmayer/issue_17770 
Unhandled std exception dragging Cylindrical joint
 2024-11-11 17:56:04 +01:00
Yorik van Havre
56a897cc96 Translations (#17725) 
* Translations: updated ts files

* Translations: merged crowdin translations

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
 2024-11-11 17:01:52 +01:00
wmayer
3db95989d3 Assembly: Handle thrown Base::Exception in ViewProviderAssembly 2024-11-11 01:11:56 +01:00
PaddleStroke
dfdd9cd286 Assembly: Fix problem with App::Link to AssemblyObject : they would not go back to position. 2024-11-09 10:16:47 -05:00
PaddleStroke
035e863592 Assembly: Fix regressions of https://github.com/FreeCAD/FreeCAD/pull/16671 2024-11-09 10:16:47 -05:00
PaddleStroke
4f2bd32048 Assembly: JointObject refactor adaptUi 2024-11-09 10:10:57 -05:00
PaddleStroke
458c2f96b1 Assembly: Improve joint taskbox offset ui. 2024-11-09 10:10:57 -05:00
PaddleStroke
6453bb578e Update CommandExportASMT.py 2024-11-09 10:09:52 -05:00
PaddleStroke
d7ea8dbe8b Update CommandSolveAssembly.py 2024-11-09 10:09:52 -05:00
PaddleStroke
38ea260fef Assembly: Fix reverse button in joint task (#17663) 2024-11-04 18:23:17 +01:00
PaddleStroke
ea334d2504 Update JointObject.py 2024-11-04 18:18:21 +01:00
PaddleStroke
f0e0f92424 Assembly: Joint creation: add expression support to spinboxes 2024-11-04 18:07:12 +01:00
Furgo
db9fbc5ff8 Reword rigid/flexible sub-assembiles tooltip. Fixes: #17636 2024-11-03 09:07:59 +01:00
Yorik van Havre
7e12ce34e7 Merge pull request #15629 from Ondsel-Development/asm_assembly_link 
Assembly: Flexible sub-assemblies.
 2024-10-28 17:07:26 +01:00
PaddleStroke
5ab2f3ea7e Assembly: CommandInsertLink: Hide hidden objects 2024-10-24 23:07:54 -05:00
PaddleStroke
4bd750db82 Assembly: Fix limits disappearing on edit (#17289) 2024-10-17 20:19:21 -05:00
PaddleStroke
3a7139dc39 Fix regressions of #16726 2024-10-17 20:13:23 -05:00
PaddleStroke
127d5dd840 Assembly: AssemblyLinks. 2024-10-16 15:39:23 +02:00
PaddleStroke
e0471f580d Assembly: Create SoSwitchMarker.py to externalize the coin stuff that draw the joint's markers(JCS) 2024-10-16 15:39:23 +02:00
PaddleStroke
0a4d965baf Assembly: Joint creation UI : add advanced offset handling. 2024-10-16 15:39:23 +02:00
pre-commit-ci[bot]
754f2011a0 [pre-commit.ci] auto fixes from pre-commit.com hooks 
for more information, see https://pre-commit.ci
 2024-10-14 17:56:08 +02:00
Yorik van Havre
d79015a908 crowdin translations 2024-10-14 17:56:08 +02:00
Yorik van Havre
a698c75581 updated ts files 2024-10-14 17:56:08 +02:00
Furgo
6266e1c96a Assembly: make "Solve failed" error more verbose (#17117) 
* Add FC_ERR macro for the 'Solve failed' Assembly error

* Handle standard exceptions during assembly solve

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
 2024-10-14 10:43:15 -05:00
PaddleStroke
55b9ed8882 AssemblyObject.cpp : add failsafe checks 2024-10-14 08:58:35 -05:00
PaddleStroke
ed7f1b02f8 AssemblyObjectPyImp.cpp : make sure PyObjects are valid 2024-10-14 08:58:35 -05:00
PaddleStroke
fd432f2bdc JointObject: fix flip one part 2024-10-14 08:58:35 -05:00
PaddleStroke
292b4c22ad Assembly: Fix context menu 'Activate object' not working and causing crash (#17092) 
* Assembly: Add setupContextMenu to ViewProviderAssembly.h

* Assembly: Fix right click 'activate object' menu not setting edit

* add QMenu header

* Add NOLINT

* Add one more space before //NOLINT or clang cries...

* Fix isInEditMode

* add isInEditMode to ViewProviderAssemblyPy.xml

* add isInEditMode to ViewProviderAssemblyPyImp.cpp

* update activeAssembly() in Utils to make sure isInEditMode
 2024-10-14 08:29:49 -05:00
PaddleStroke
70142112f9 Assembly: Remove JointObject camera callbacks. And fix lock highlight. 2024-10-14 08:27:36 -05:00
PaddleStroke
ab4b95a459 Assembly: Joint: add support to non ascii characters. 2024-10-10 20:36:54 -05:00
PaddleStroke
c6c4e8cc25 Assembly: Fix joint labels bad auto-rename issue. 2024-10-10 20:36:54 -05:00
PaddleStroke
5ce79a760b Assembly: Fix gear/belt switch on checkbox toggle 2024-10-10 20:26:18 -05:00
PaddleStroke
29b719664b Assembly: Fix migrationScript2 error with bad joints (#17010) 
* Fix migrationScript2 to handle bad joints
 2024-10-07 18:48:38 -05:00
Furgo
57df44b03d Create the assembly object inside the list of commands 2024-10-07 17:48:00 +02:00
Furgo
07e801be86 Prepend a single quote to BOM index to be interpreted as a string in generated spreadsheets 2024-10-04 08:53:02 -05:00
Chris Hennes
d1cdcd18bf Merge pull request #16726 from bgbsww/bgbsww-AssemblySubNames 
Assembly: Correctly build reference from selection subname
 2024-10-03 13:46:35 -05:00
PaddleStroke
ced8869b49 Assembly: Use cpp getGlobalPlacement python binding rather than reimplementing it. 2024-10-03 09:59:15 -05:00
PaddleStroke
1b44435e98 Assembly: Fix lag during dragging of large assemblies. Bundle fix joints together. Show only the movingJoint during dragging. Do not recompute joints during dragging. 2024-09-30 17:38:54 +02:00
bgbsww
d14ca595bd Refine further 2024-09-27 13:00:19 -04:00
bgbsww
d51f0f0f2a Return to python; simplify to work with only classic names, provide migration 2024-09-26 00:01:10 -04:00
bgbsww
e0e1cb565a Correctly build reference from selection subname 2024-09-24 22:01:14 -04:00
bgbsww
48c65aed76 Support macros and console logs in Assembly 2024-09-23 14:10:55 -05:00