luz paz
773bd041e9
Path: remove superfluous 'pass' per LGTM
...
ref: https://lgtm.com/rules/910088/
2022-03-19 20:06:48 -04:00
sliptonic
b25eaec2e5
Merge pull request #6575 from Russ4262/fix/rebuild_empty_job_with_gui
...
Path: Extend Job integrity check to GUI side, issue #6207 [Bug]
2022-03-19 15:44:28 -05:00
Russell Johnson
61888959e2
Path: Change action to warning with option for action.
2022-03-16 11:47:51 -05:00
Russell Johnson
b2ab3d7c48
Path: Correct comment spelling
2022-03-16 11:40:24 -05:00
Russell Johnson
4e8d93ee72
Path: Extend Job integrity check to GUI side, issue #6207 [Bug]
...
This commit adds a simple `_jobIntegrityCheck()` method to verify that a model and tool exists within the Job object, when interacting with the Task Panel. If either is missing, the appropriate tab is activated in the task window, and the appropriate edit window is opened for the user, with messages printed in the report view window.
Add check for existence of `SetupSheet` property of empty Job object.
These changes improve upon fixes in PR #5008 and related bug fixes.
2022-03-16 11:40:23 -05:00
sliptonic
6309575591
[Path] Warn user if enabling legacy tools
...
Warn user if opening job that contains legacy tools
2022-03-15 11:05:20 -05:00
sliptonic
4b49c87650
Merge pull request #6577 from Russ4262/fix/millface_removalshapes
...
Path: Fix `self.removalshapes` declaration [Bug]
2022-03-15 09:26:39 -05:00
sliptonic
da2b77d611
Merge pull request #6576 from Russ4262/fix/cancel_new_dressup_cleanup
...
Path: Fix automatic `commitTransaction()` calls, issue #6149 [Bug]
2022-03-15 09:25:43 -05:00
sliptonic
86539bf6db
Merge pull request #6571 from Russ4262/fix/tag_dressup_radius_value
...
Path: Fix inconsistent float type usage, issue #6170 [Bug]
2022-03-14 09:26:24 -05:00
Russell Johnson
4e9f7b0b62
Path: Fix self.removalshapes declaration [Bug]
...
Prior to this fix, the `self.removalshapes` variable is not declared if `obj.Base` does not exist, or is empty. This moves the declaration up in scope to the method level.
2022-03-12 22:34:03 -06:00
Russell Johnson
2bc14f84aa
Path: Fix automatic commitTransaction() calls, issue #6149 [Bug]
...
This commit removes the automatic committal of transactions when activated with GUI command. The committal of the transaction is executed with the `accept()` and `reject()` methods of the respective task panel.
2022-03-12 22:05:04 -06:00
Russell Johnson
68d20e7e90
Path: Improve value assignment syntax for radius
2022-03-12 20:00:40 -06:00
sliptonic
73e995a0f7
Merge pull request #6566 from Russ4262/fix/boundary_dressup_begin_safeheight_retraction
...
Path: Correct beginning retraction to safe height in Boundary Dressup, issue #6279 [Bug]
2022-03-12 19:05:39 -06:00
Russell Johnson
ba4611a260
Path: Fix radius type inconsistency, issue #6170 [Bug]
...
Make `self.radius` a float type throughout since other methods and functions treat it as such.
2022-03-12 18:29:21 -06:00
Matti Eiden
34ed7bc123
PathArray: Support applying PathArray on Dressups
2022-03-12 22:31:16 +02:00
Russell Johnson
4ae4e7be1a
Path: Correct beginning retraction to safe height feed rate, issue #6279 [Bug]
...
This commit changes the feed rate of the beginning retraction from G1 at Feed to a G0 Rapid rate. This initial command is causing a problem with the Tag Dressup due to the first move being a G1 to Safe Height.
2022-03-12 12:18:09 -06:00
sliptonic
da2dcaa7f4
Merge pull request #6552 from Russ4262/fix/leadin_leadout_simulation
...
Path: Fix Leadin-Leadout dressup simulation related to arcs [Bug]
2022-03-11 10:06:42 -06:00
sliptonic
14949faf06
Merge pull request #6541 from Russ4262/fix/ramp_entry_dressup
...
Path: Fix enumeration dictionary error [Bug]
2022-03-11 10:04:53 -06:00
Russell Johnson
a52e63b934
Path: Fix Leadin-Leadout dressup simulation related to arcs
...
Add missing "Z" and "K" parameters for arc commands to appease Path simulator.
2022-03-10 20:05:52 -06:00
Russell Johnson
c1529aba40
Path: Fix enumeration dictionary error
...
This commit corrects an incorrect dictionary key in the enumeration dictionary updated with recent translation fixes.
2022-03-09 21:03:34 -06:00
sliptonic
e0c0590631
fixes #5954
...
Make headers less confusing and ambiguous
2022-03-08 08:40:05 -06:00
sliptonic
714cab8f6f
fixes 6114
...
replaces DlgJobChooser with QInputDialog.
2022-03-07 17:51:00 -06:00
sliptonic
ee8193322c
Merge pull request #6485 from mlampert/feature/external-thread-milling
...
Path: Feature/external thread milling
2022-03-04 12:52:31 -06:00
sliptonic
9028976d16
Merge pull request #4911 from sliptonic/feature/nopathjob
...
[Path] Make Job and Operation visibility more natural
2022-03-04 12:51:25 -06:00
Markus Lampert
c02dedbb3c
Split out thread milling generator into its own file
2022-03-04 10:42:34 -08:00
sliptonic
69a17578d3
black format
2022-03-04 10:42:34 -08:00
Markus Lampert
2baca43e17
Removed debugging gates
2022-03-04 10:42:34 -08:00
Markus Lampert
2df74990eb
Fixed UI update upond changing the thread type
2022-03-04 10:42:34 -08:00
Markus Lampert
eef8fd4f48
Fixed multi pass for external threads with proper lead in/out
2022-03-04 10:42:34 -08:00
Markus Lampert
a1117040b3
Changed passes for constant tool engagement
2022-03-04 10:42:34 -08:00
Markus Lampert
00d2341748
Disabled debugging comments
2022-03-04 10:42:34 -08:00
Markus Lampert
263eeffd71
Fixed lead in/out with elevator location.
2022-03-04 10:42:34 -08:00
Markus Lampert
c12748d8c4
Added thread generation unit tests and fixed finishing the thread
2022-03-04 10:42:34 -08:00
Markus Lampert
67dbb8675a
Some code cleanup
2022-03-04 10:42:34 -08:00
Markus Lampert
8e38a80aa8
Added imperial external and split data files according to tolerance classes
2022-03-04 10:42:34 -08:00
Markus Lampert
bdeb5776b0
First shot at external thread milling
2022-03-04 10:42:34 -08:00
sliptonic
b08cb1f7b7
Merge pull request #6480 from sliptonic/bug/velocitywarn
...
[Path] Fix bug with velocity warning.
2022-03-01 08:18:10 -06:00
Markus Lampert
37095fbf78
Consistent black formatting of all Path python files
2022-02-28 21:06:16 -08:00
Markus Lampert
122fd49b37
Remove pylint annotations and script
2022-02-28 21:02:45 -08:00
sliptonic
9b71f089ca
Fix bug with velocity warning.
...
Add button to suppress
2022-02-28 17:55:19 -06:00
sliptonic
efbba14254
Merge pull request #5512 from luzpaz/Path-PathSelection-bug
...
Path: Fix class 'KeyError' in PathSelection.py
2022-02-23 08:40:45 -06:00
luz paz
958a1c67d5
[Path] mark deprecated selections
...
...and fix typos
2022-02-22 19:07:54 -05:00
sliptonic
ce70ee11f9
Update PathSelection.py
...
The Opname changed as part of the translation cleanup. Adding both names to the dictionary will support both existing operations and newly created ones.
2022-02-22 14:56:00 -06:00
sliptonic
dc94ff8b6f
Merge pull request #5424 from Russ4262/fix/3D_pocket_overcut
...
Path: Fixes 3D Pocket overcut on underside of selected faces
2022-02-22 08:52:12 -06:00
sliptonic
de75035ece
Make job work more naturally
...
Operations Group as document group
Make job claim children
[Path] Make Operations into a document group
2022-02-19 09:12:41 -06:00
sliptonic
67c0336fa2
[Path] Fix Path generation for forking wires
2022-02-18 17:05:42 -06:00
sliptonic
87a93d5dff
Merge pull request #6373 from Russ4262/fix/3d_surface_property_enumerations
...
Path: Correct restoration of 3D Surface property enumerations
2022-02-18 10:57:11 -06:00
Russell Johnson
480eff20d3
Path: Remove waterline, outline, and avoid extensions
2022-02-17 23:39:44 -06:00
sliptonic
16a2c559aa
Merge pull request #5343 from Russ4262/fix/open_edge_zero_start
...
[Path] Fix open edge zero value start point
2022-02-17 12:36:38 -06:00
sliptonic
21e77bc4cd
Merge pull request #6387 from SamuelMayer/kinetic_nc_pp
...
Path: Added KineticNC Postprocessor 2nd try
2022-02-17 10:01:32 -06:00