Commit Graph

2416 Commits

Author SHA1 Message Date
Chris Hennes
a7522c384e [DRAFT] Catch only Exception, not BaseException 2021-02-11 11:52:45 +01:00
Yorik van Havre
97379e035a merged crowdin translations 2021-02-09 16:12:18 +01:00
Yorik van Havre
5d18625677 Updated master TS files 2021-02-08 16:35:41 +01:00
Yorik van Havre
96dc265f5b Merge pull request #4341 from hyarion/feature-error-handling-get_svg
[0.19] [Draft] Add better error message in get_svg for direction
2021-02-08 16:08:18 +01:00
marioalexis
ae4ef332ff Draft: Correct the placement in scale_with_clone - fixes #0004113 2021-02-06 23:42:22 -03:00
Amritpal Singh
7d5ce50fdd Draft: Fix bug in getCubicDimensions function 2021-02-04 22:57:31 +05:30
luz paz
19d0e1123f Draft: fix LGTM 'Testing for None should use the 'is' operator' alerrts
https://lgtm.com/projects/g/FreeCAD/FreeCAD/alerts/?mode=tree&ruleFocus=7900090
2021-02-03 21:58:47 +01:00
Yorik van Havre
85f9d82937 Merge pull request #4331 from chennes/openSCADFix
[Draft] OpenSCAD/DXF error: fix DXF import with no layers
2021-02-02 14:01:43 +01:00
Benjamin Nauck
ce7856d51f [Draft] Add better error message in get_svg for direction
An AttributeError is raised when `direction=Vector(0,0,0)` and obj is
an Arch::Space on line: a3fb3cc804/src/Mod/Draft/draftfunctions/svg.py (L799)

This patch checks if early on if the direction vector and raises a
ValueError with a description of what has gone wrong.

A caveat with this solution is that this new behaviour might break old
code which depends on that invalid directions can be used.
2021-01-31 20:24:59 +01:00
Stefan Tröger
ec5ac30756 Remove ExtensionProxy and rely on default Python proxy for extensions. fixes #0004534 2021-01-30 16:00:48 +01:00
Chris Hennes
cbceb87d95 Fix DXF import with no layers
As discussed in https://forum.freecadweb.org/viewtopic.php?f=3&t=54842, if OpenSCAD creates a DXF with no layers in it, the code that is supposed to handle that in FreeCAD has a minor type error in it that prevents the import from working.
2021-01-29 17:01:22 -06:00
Roy-043
b6976b3b23 [Draft] Fix snap to center of faces of solids
The code would only find a center snap on the face with index=0 of solids.

In V0.19 Part.getShape was introduced (line 399). But not all consequences were not fully implemented.

In the '# we are snapping to an edge' section (line 411) the code could be cleaned up. There is no need to check if the index of the edge is correct for the parent object since we are no longer dealing with a parent object. That portion was effectively dead code.

The '# we are snapping to a face' section (line 429 in the revised code) has been modified accordingly, which fixes the bug.

Forum discussion:
https://forum.freecadweb.org/viewtopic.php?f=23&t=54747
2021-01-25 15:33:36 +01:00
marioalexis
875c0d8612 Draft: Prevent Draft_Wire from setting a single-edge wire as closed 2021-01-22 01:16:40 -03:00
Yorik van Havre
7b10771b7c Draft: Don't snap to ImagePlanes 2021-01-12 15:31:55 +01:00
Yorik van Havre
2cf3a15101 Draft: Added import/export buttons to Annotation styles editor dialog 2021-01-05 16:54:06 +01:00
Yorik van Havre
4da2b5b273 Merge pull request #4216 from marioalexis84/draft-draftify
Draft: Replace Part.getSortedClusters by Part.sortEdges in draftify function
2021-01-04 12:33:55 +01:00
Yorik van Havre
c7a0eb6724 Merge pull request #4235 from marioalexis84/draft-facebinder
Draft: Fix multiple crashes when using modification functions - fixes #0004243, #0003971
2021-01-04 12:30:56 +01:00
carlopav
f97e7aec3c Draft: change in default Draft.makeCopy
always copy with dependencies when copying App::Part and PartDesign::Body
.
2021-01-03 15:10:29 +01:00
marioalexis
739daccd8d Draft: Fix multiple crashes when using modification functions - fixes #0004243 2021-01-02 02:15:43 -03:00
marioalexis
045accd3f2 Draft: Replace Part.getSortedClusters by Part.sortEdges in draftify function 2020-12-29 23:21:33 -03:00
luz paz
439bf8960d Fix typos [skip ci]
Found via `codespell v2.1.dev0`
2020-12-23 14:32:38 -05:00
Yorik van Havre
bdd9c23af7 Reverting files wrongly committed with 11beceea8 2020-12-23 15:21:43 +01:00
Yorik van Havre
22f7d5f3bc Merged crowdin translations 2020-12-23 15:13:05 +01:00
Yorik van Havre
16effcb2af Updated ts files 2020-12-23 14:51:04 +01:00
Yorik van Havre
ee07d63ef7 Merge pull request #4142 from DinoMesina/master
Draft: Correct placementFromDXFOCS()
2020-12-23 14:24:21 +01:00
luz paz
abd502ac53 Fix typo found via Crowdin [skip ci]
https://crowdin.com/translate/freecad/548/en-eu?filter=basic&value=3#6585264
2020-12-21 13:18:13 +01:00
Dino del Favero
81af227868 Merge branch 'master' into master 2020-12-15 21:41:59 +01:00
Yorik van Havre
5bccc5c588 Draft: Small layer improvements
- Added 'Print Line Color' property
- Added 'Add new layer' context menu action to layers group
2020-12-15 16:43:33 +01:00
Yorik van Havre
1d83dc3007 Draft: Small wording fix 2020-12-15 16:41:35 +01:00
Yorik van Havre
481937f034 Draft: Small fixes to Draft SetStyle panel 2020-12-15 16:40:16 +01:00
Dino del Favero
cabb1f81b4 Merge branch 'master' into master 2020-12-14 22:24:50 +01:00
Yorik van Havre
f54b452327 Draft: Hide undo button from modify operations 2020-12-14 15:21:25 +01:00
Yorik van Havre
d74e4c09d6 Merge pull request #4116 from chennes/fixAirfoilImportNumberRegex
[Draft] Fix airfoil data detection regex
2020-12-14 12:29:50 +01:00
Yorik van Havre
578c8f967f Merge pull request #4115 from JAndersM/patch-1
[Draft] Update task_scale.py
2020-12-14 12:21:47 +01:00
Yorik van Havre
b168dfaec9 Merge pull request #4100 from marioalexis84/draft-upgrade
Draft: Improve makeWires in upgrade function
2020-12-14 11:59:21 +01:00
Chris Hennes
371af865a9 Merge branch 'master' into fixAirfoilImportNumberRegex 2020-12-13 23:02:36 -06:00
Dino del Favero
c4851a1bb3 Updated links
Added links in english
2020-12-14 00:29:21 +01:00
Dino del Favero
a8f0d9e68a Correct placementFromDXFOCS()
Corrected placementFromDXFOCS() function with the indications provided by Autodesk (TM)
http://docs.autodesk.com/ACD/2011/ITA/filesDXF/WS1a9193826455f5ff18cb41610ec0a2e719-7941.htm
http://docs.autodesk.com/ACD/2011/ITA/filesDXF/WS1a9193826455f5ff18cb41610ec0a2e719-793d.htm#WSc30cd3d5faa8f6d81cb25f1ffb755717d-7ff5
2020-12-13 23:59:47 +01:00
luz paz
fc99ff2def Draft: fix header uniformity + trailing whitespace
[skip ci]
2020-12-11 13:19:49 +01:00
marioalexis
7c20483c12 Draft: Improve makeWires in upgrade function 2020-12-09 15:21:33 -03:00
Chris Hennes
d0cafe34fb Merge branch 'master' into fixAirfoilImportNumberRegex 2020-12-09 08:35:24 -06:00
Chris Hennes
8556885f14 Add support for integer values. 2020-12-09 08:32:43 -06:00
Yorik van Havre
2fb2e1a5a8 Draft: Better layout of the Draft SetStyle task panel 2020-12-09 14:42:50 +01:00
Chris Hennes
9e9e1b5b54 [Draft] Fix airfoil data detection regex
The regular expression that Draft's airfoil data importer uses did not allow for lowercase "e" when using scientific notation. This corrects that, and silences Python Developer Mode warnings about deprecated escape sequences by converting most of the regex to use raw strings.
2020-12-07 13:13:34 -06:00
JAndersM
bd913d1dd5 Update task_scale.py
The changes solves the Ticket #3691 - Bug in draft scale. Only integers work
2020-12-07 19:51:29 +01:00
Yorik van Havre
728cf3ca11 Draft: Fixed Annotation style dialog's arrow types - fixes #4505 2020-12-03 16:30:05 +01:00
Yorik van Havre
8c15f7f84f Draft: Colored grid axes 2020-12-03 15:15:15 +01:00
Yorik van Havre
9c0f6eb2d5 Merge pull request #4067 from marioalexis84/draft-upgrade
Draft: Some fixes in upgrade function
2020-11-25 11:07:01 +01:00
marioalexis
a11b457121 Draft: Some fixes in upgrade function. bug #0004460, fixes #0004462, #0004080 2020-11-24 22:08:06 -03:00
marioalexis
1569b08451 Draft: Change archDimTracker text position depending on distance and scale values 2020-11-23 16:25:21 -03:00