Commit Graph

51 Commits

Author SHA1 Message Date
Uwe
023a37b92c [TD] Task*, part 1: remove unused includes
- also some sorting
2022-12-07 16:15:40 +01:00
Uwe
753c8e3423 [TD] TaskRichAnno.cpp: add missing include
- also some sorting and removal of unused includes
2022-10-08 04:05:17 +02:00
Uwe
e3bf7027a6 [TD] remove redundant nullptr checks 2022-10-03 04:25:33 +02:00
wmayer
6d7d154c0e TD: remove unused member variables to fix -Wunused-private-field 2022-09-08 08:15:19 +02:00
wandererfan
acf17905ed [TD]CI clang warnings 2022-09-05 17:48:38 -04:00
Wanderer Fan
6677cd4d8f [TD]clazy warnings and duplicate setter/getter
- clazy warning re missing Q_OBJECT

- include TechDrawGlobal.h in headers

- resolve duplicate setter/getters
2022-08-18 09:34:32 -04:00
Wanderer Fan
bdf4cea14e [TD]refactor scene/view/mdi
- move scene related functions out of mdiViewPage
  and QGVPage.
- route requests for scene/view/mdi through
  ViewProviderPage
2022-08-18 09:34:32 -04:00
berniev
da9ebc572f Mod: redundant void 2 2022-08-08 10:27:50 +02:00
Benjamin Bræstrup Sayoc
86dfd0a862 [TechDraw] Simplify code getting default line weights 2022-08-02 16:13:01 -04:00
Uwe
31bc9f3913 [TD] remove some more superfluous nullptr checks 2022-07-20 02:53:48 +02:00
Uwe
af18a97913 [TD] Gui: remove more superfluous nullptr checks 2022-07-19 03:40:32 +02:00
Uwe
2e5e4dced8 [TD] Gui: remove some superfluous nullptr checks 2022-07-19 02:49:46 +02:00
Benjamin Bræstrup Sayoc
93700c81e4 [TechDraw] Improve readability of TaskRichAnno.cpp 2022-07-15 11:31:11 -04:00
Wanderer Fan
9894964eb6 [TD]implement navigation styles 2022-06-24 10:03:02 -04:00
Chris Hennes
c44ccc0ff2 TD: PR6497 move return statement to new line 2022-03-29 13:26:01 -05:00
wmayer
fd8719c85c TD: [skip ci] activate PCH of TechDraw (Gui) and use forward declarations
For MSVC this reduces compile time by ~20%
2022-03-25 13:54:47 +01:00
Uwe
2e7cb2c3fb [TD] remove a single-header file 2022-03-25 04:11:53 +01:00
wmayer
a99be14233 TD: modernize C++11
* use nullptr
2022-03-23 19:26:14 +01:00
andrea reale
13e09b36f8 remove QT4 references 2022-03-19 23:07:38 +01:00
wmayer
1ca7429705 Gui: Optimize includes to reduce compile time 2022-03-07 20:29:18 +01:00
Wanderer Fan
cb280afbc4 [TD]remove redundant edits from 9 Task dialogs 2022-01-22 14:51:20 -05:00
luz paz
d703d9a89c [TD] Renamed SpreadsheetView, RichTextAnnotation, SectionView...
`Quadrants`, `DetailView`, `ShowAll`
2021-04-17 11:38:10 +02:00
Chris Hennes
cbdc2ac48e [TD] Remove deprecated Qt < 5.9 code 2021-04-02 12:02:54 +02:00
wmayer
e728c3590e TD: [skip ci] Fix coverity warning
Coverity warnings fixed:

CID 316559 (#1 of 1): Uninitialized scalar variable (UNINIT)
3. uninit_use_in_call: Using uninitialized value we. Field we.idx is uninitialized when calling push_back

CID 316549 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
4. uninit_member: Non-static class member pageheight is not initialized in this constructor nor in any functions that it calls.

CID 186161 (#1 of 1): Uninitialized pointer field (UNINIT_CTOR)
2. uninit_member: Non-static class member parent is not initialized in this constructor nor in any functions that it calls.

CID 305170 (#1 of 1): Dereference before null check (REVERSE_INULL)
check_after_deref: Null-checking this->m_baseFeat suggests that it may be null, but it has already been dereferenced on all paths leading to the check.

CID 186152 (#2 of 2): Uninitialized pointer field (UNINIT_CTOR)
3. uninit_member: Non-static class member m_mdi is not initialized in this constructor nor in any functions that it calls.

CID 192588 (#1 of 1): Same on both sides (CONSTANT_EXPRESSION_RESULT)
pointless_expression
2021-02-21 16:30:30 +01:00
donovaly
b5f57ed2f0 [TD] make pointers to the UI std::unique_ptr
as noted in https://github.com/FreeCAD/FreeCAD/pull/4271#discussion_r554673632
the pointer to the UI should be a unique pointer.

This PR does this for all TD dialogs that don't already use a unique_ptr.
2021-01-19 19:24:27 +01:00
donovaly
a1915d313a [TD] make LineGroup selectable
At the moment one has to specify the LineGroup as string. But one doesn't know what groups exist. So one has to check the Wiki, learn there where the groups are defined and then open the definition file with a text editor.

This PR simplifies this by reading the existing groups out of the definition file and fill the combobox accordingly.
It also give the user info what the selected LineGroup defines via the tooltip.

A nice side effect is that no typos can occur since you don't have to enter the LineGroup name as text.
2020-12-03 17:24:49 +01:00
luz paz
2befcd9502 TD: Issue #0004473: Expose openCommand() to translation
Continuing the work to expose the undo/redo functionality to translation. This commit does so for the TechDraw Wb.  
Ticket: https://tracker.freecadweb.org/view.php?id=4473
2020-12-01 14:53:35 +01:00
luz paz
a3cb87b117 TechDraw: Header uniformity and whitespace fixes 2020-11-14 16:59:51 +01:00
wmayer
5584c36c1b Coverity: [skip ci] Dereference before null check 2020-07-21 14:31:09 +02:00
wmayer
b25dee58d5 Coverity: Uninitialized scalar/pointer field 2020-07-20 17:34:30 +02:00
wmayer
4a494fec69 Coverity: Dereference null return value 2020-07-20 17:34:26 +02:00
wmayer
e9bc970c28 PVS: V522 There might be dereferencing of a potential null pointer 2020-07-18 10:59:27 +02:00
wandererfan
e80c576241 [TD]Centralize preference getters 2020-04-24 11:13:49 -04:00
donovaly
d9e65c7780 [TD] use Gui::QuantitySpinBox in dialogs
as recently discussed

- also add lost alignment properties
2020-03-28 08:51:12 -04:00
wandererfan
3988824b67 [TD]fix RTA edit when no MDI 2020-02-16 14:24:14 -05:00
Zheng, Lei
1024344bb6 TechDraw: remove duplicated fix 2020-02-11 15:40:27 -05:00
Zheng, Lei
3cd84fc2d0 TechDraw: fix build for qt4 2020-02-11 15:40:27 -05:00
wmayer
e4be9e43d6 TechDraw: [skip ci] user visible text should be translated 2020-02-03 13:41:35 +01:00
donovaly
61005608ca [TD] TaskRichAnno tr to fix Qt4 build 2020-02-03 07:20:52 -05:00
donovaly
99baface06 [TD] set default text size for RichAnno dialog
see https://forum.freecadweb.org/viewtopic.php?f=35&t=42414&p=364965#p364965
2020-01-31 08:35:38 -05:00
wandererfan
ebf0f9da0d [TD]Default color and weight for markup lines 2020-01-29 15:26:06 -05:00
donovaly
b758b22171 [TD] fix regression with line width I introduced today 2020-01-28 21:07:49 -05:00
donovaly
42e6aeb14e [TD] improve RichAnno and LeaderLine dialog
see: https://forum.freecadweb.org/viewtopic.php?f=35&t=42746&p=364126#p364126
2020-01-28 12:40:56 -05:00
donovaly
a3622ee49f [TD] rename some Draw* elements - try 2
as discussed here: https://forum.freecadweb.org/viewtopic.php?p=360042#p360042
2020-01-18 06:57:29 -05:00
wandererfan
8b2e318f15 [TD]fix parenting in Tree 2020-01-15 15:46:37 -05:00
wandererfan
6cb31ac91f [TD]Cleanup dead code in TaskRichAnno 2020-01-15 07:17:18 -05:00
wandererfan
afc2da43a8 [TD]fix jumping Rich Text Annotation 2019-12-04 10:16:19 -05:00
donovaly
15e5b29c22 TD renaming tools, part 2/2
as discussed in https://forum.freecadweb.org/viewtopic.php?p=344899#p344800
we need a more consistent naming for the Wiki
2019-11-17 08:22:09 -05:00
wandererfan
249d7f2e9e Remove Surplus VP properties
- color, size and font info are embedded in the rich text
2019-05-17 19:35:25 -04:00
wandererfan
d078f901c7 Pass font/fontsize to RT editor 2019-05-05 21:01:31 -04:00