Commit Graph

238 Commits

Author SHA1 Message Date
Yorik van Havre
b5a3d28fee Doxygen tweaks 2019-07-17 18:01:56 -03:00
wmayer
0dde354716 Document::breakDependency should handle exceptions to avoid to leave document in an inconsistent state 2019-03-15 14:41:43 +01:00
wmayer
7778f25584 copyObject should return the clone of the passed object for recursive copies, not an arbitrary object 2019-02-12 19:40:29 +01:00
Abdullah Tahiri
c1fdc42fd6 Improve debug info 2018-12-19 10:27:30 -02:00
wmayer
1647eee92c add specialized exception type for bad graphs 2018-11-26 14:15:19 +01:00
wmayer
b7bfb06cea fix crash if origin feature doesn't exist when trying to create dependency graph 2018-11-26 13:09:11 +01:00
wmayer
a41a130704 some additions to pR 1794:
add a special XMLAttributeError class to indicate an error when accessing a missing attribute
in PropertyContainer::Restore make error handling more flexible
2018-11-19 19:07:56 +01:00
Abdullah Tahiri
6bffbf801c remove forgoten exception 2018-11-19 11:31:10 +01:00
Abdullah Tahiri
36d748c29e Example implementation 2018-11-19 11:31:10 +01:00
Abdullah Tahiri
a7e0b93dd1 Example code of propagating the result of the partial restore 2018-11-19 11:31:08 +01:00
wmayer
31963f16c1 Fix scan coverity issues:
CID 184294: Uncaught exception
CID 183597: Unchecked return value
CID 175809: Dereference before null check
CID 175810: Logically dead code
CID 133000: Uninitialized scalar variable
CID 133001: Uninitialized scalar variable
CID 183591: Explicit null dereferenced
2018-11-13 16:47:58 +01:00
wmayer
06fa64a00d add method to check if an open transaction is empty
This is needed to avoid to incorrectly abort a transaction if a recompute was done between opening and closing an editor in the property view
2018-11-10 14:50:58 +01:00
wmayer
ccbf7a6c3a fixes 0003627: Hole fails to restore from file 2018-11-10 01:13:42 +01:00
wmayer
cacab69204 fix crash with Py3 when releasing memory buffer 2018-10-27 19:58:54 +02:00
ickby
d5cbee5543 Persistence: Test cases for content dump
It turned our that the document could not be dumped as the xml specifier was used as first element. As the dumping added the <content> element around it was invalid. However, content is required to read properties. Hence the xml element generation was moved.
2018-10-27 16:15:30 +02:00
wmayer
c290b9fe6e add option to save document directly to target file 2018-10-15 20:09:43 +02:00
wmayer
bf4dd7920e emit signal when starting and finishing to save a document 2018-10-08 14:03:00 +02:00
wmayer
addb742b3c minor fixes 2018-10-08 12:27:03 +02:00
ickby
b08738c15b Expose document property changes to python document observer 2018-10-08 11:01:07 +02:00
ickby
617114a072 Fix and test the new signals 2018-10-08 10:58:39 +02:00
ickby
65d6d5cc33 Expose onBeforeChange to python document observer 2018-10-08 10:52:52 +02:00
Stefan Tröger
e338fe6b70 Expose transaction events to document observer 2018-10-08 10:49:39 +02:00
Stefan Tröger
e571a6e07a Add signals for recomputed objects 2018-10-08 10:43:32 +02:00
wmayer
18b8a66bc8 print warning also in release mode if an object is still touched after recompute 2018-10-07 22:09:44 +02:00
wmayer
25c7b1e9be in topologicalSort check for valid iterator 2018-10-04 00:33:19 +02:00
wmayer
7bf4c9d96f fixes 0003410: 0.17 Regression: recompute will make parts lose color and take a longer delay compared to FC0.16 2018-10-02 19:04:44 +02:00
wmayer
822421ddd9 fix infinite recursion when creating dependency graph with loops 2018-09-30 14:56:47 +02:00
wmayer
4181e1c2a7 fixes 0003465: Groups breaking dependency graph 2018-09-26 22:21:52 +02:00
wmayer
1c28e4b883 fixes 0003373: 'Save a copy' of a document with a spreadsheet mark the document as touched 2018-09-26 15:22:21 +02:00
Zheng, Lei
3f924c0cbe App::Document: enable saving with binary brep 2018-08-06 19:01:21 +02:00
wmayer
b0e869174d fix possible crash when reverting a document 2018-06-09 23:22:56 +02:00
luz.paz
9167064fc1 Misc. typos
Found via `codespell`
2018-04-25 09:41:33 -03:00
Abdullah Tahiri
74375f6623 Dependency graph crash minimum fix 2018-03-11 21:31:28 +01:00
wmayer
5e16cb9792 fixes #0003323: Crash when clearing transaction list 2018-01-31 23:39:13 +01:00
wmayer
004206aa0b 0003279: Error 'invalid DAG' after deleting sketch using expressions 2018-01-31 00:27:38 +01:00
wmayer
eabfffe72a fix automatic update of dependency graph 2018-01-15 22:19:05 +01:00
wmayer
9fd18ee8c3 verify iterators in partialTopologicalSort to be on the safe side
currently this can cause a crash because issue 3214 is not fixed yet
See also: https://forum.freecadweb.org/viewtopic.php?f=19&t=26295
2018-01-10 22:16:39 +01:00
luz.paz
831bf31817 Misc. typos
+ stepcode typo submitted upsream https://github.com/stepcode/stepcode/pull/372
2018-01-07 18:41:29 -02:00
Unknown
e3eca59173 Misc. typo fixes
Various workbenches
2017-12-23 14:30:30 +01:00
wmayer
bea4b2c163 fixes #0003185: Recompute should work if only subgraph is cyclic 2017-12-10 17:47:09 +01:00
wmayer
b0bbbe9421 move implementation of topologicalSort to private class DocumentP and add a parameter 2017-12-10 11:04:25 +01:00
wmayer
4e74ef0cf7 move global function to private class DocumentP 2017-12-10 10:53:34 +01:00
Eivind Kvedalen
76d3d96071 When we are restoring, don't set the Label on object creation as it will be restored later.
This is to avoid potential duplicate label conflicts.

This fixes issue #3280.
2017-11-30 16:28:41 +01:00
Eivind Kvedalen
8b4adfa513 Moved ObjectStatusLocker template class to Base/Tools.h 2017-11-30 16:28:41 +01:00
Eivind Kvedalen
dd6757bbb8 Spreadsheet: Fix for issue #3225.
Done by adding a selector function to Document::renameObjectIdentifiers(...) to ensure
that the Spreadsheet document object is not rewritten twice.
2017-11-08 23:15:16 +01:00
wmayer
d7caea2cba fix crashes in dependency walker 2017-11-08 12:12:46 +01:00
wmayer
bed779a530 method to get paths between two objects 2017-10-20 18:26:18 +02:00
wmayer
f4a25522a7 fix possible dangling pointers in function to create dependency graph 2017-10-11 13:24:32 +02:00
luzpaz
f3bf8fe919 Misc. typos
+ some are doxy others are just comment code.  
+ some minor whitespace and grammatical tweaks. 
+ app/SCL/* typos have also been submitted upstream (https://github.com/stepcode/stepcode/pull/366). So it's ok to merge them in to master.
2017-10-04 17:59:11 +02:00
wmayer
712966ff50 rename method from remObject to removeObject to be more readable 2017-09-13 18:57:38 +02:00