Commit Graph

29324 Commits

Author SHA1 Message Date
Mikael Ågren
25242430f4 Restore drilling op retract value to user supplied Retract Height
Restores the retract behaviour to pre 5b23af3. After 5b23af3 Retract
Height is no longer used.
2022-06-26 19:43:00 +02:00
wmayer
8acfd5bce7 TD: minor fixes:
* remove superfluous semi-colons
* if a method is declared override then the keyword virtual should be dropped
2022-06-26 15:51:43 +02:00
wmayer
175ecbc50f Draft: handle the absence of the Drawing module in the unit tests 2022-06-26 12:07:48 +02:00
Abdullah Tahiri
8ee773362e Sketcher: Fix warning not all enum handled in switch 2022-06-26 06:39:10 +02:00
Abdullah Tahiri
073bf3215c Sketcher: Constraints - add ability to generate constraint type string 2022-06-25 19:18:15 +02:00
sliptonic
1f07083d4a Merge pull request #6760 from Russ4262/fix/dressup_leadinout
Path: Fixes #6693 - Add Z and K values to arc commands
2022-06-25 12:10:48 -05:00
Abdullah Tahiri
cd208c5477 Part: Geometry - Add Ellipse minor radio convenience function 2022-06-25 19:03:11 +02:00
Abdullah Tahiri
6a06f60ee3 Part: Geometry - function to get the conic axis direction 2022-06-25 19:03:11 +02:00
wmayer
7db925d991 App: fix memory leaks in Enumeration class and simplify code 2022-06-25 18:18:57 +02:00
wmayer
d7313598aa CMake: disable Drawing module by default 2022-06-25 18:10:06 +02:00
wmayer
02bc430fac Draft: handle the absence of the Drawing module in the unit tests 2022-06-25 18:05:23 +02:00
wmayer
2b04b01edc cppcoreguidelines-special-member-functions
* disable move constructor and move assignment for several core classes
2022-06-25 17:46:48 +02:00
wmayer
6b6df27df8 C++ core guidelines:
* ES.87: Don’t add redundant == or != to conditions
2022-06-25 17:38:57 +02:00
wmayer
7de296b60e cppcoreguidelines-pro-type-union-access
According to https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#Ru-pun using union for type-punning is undefined behaviour.
  See also https://en.wikipedia.org/wiki/Type_punning#Use_of_union. Replace it with std::memcpy.
2022-06-25 17:17:04 +02:00
marioalexis
14668197d1 Base: Minor changes in some Python docstrings 2022-06-25 17:12:06 +02:00
Uwe
999f3b85ee [PD] re-add accidentally removed code in commit 93525ff7 2022-06-25 16:44:44 +02:00
Uwe
1b2f0063a1 [PD] Hole initialization bugfix
- by default there is no hole head cut and therefore its parameter must be initialized as read-only (will be enably when user sets a head cut)

- also fix a typo

- also fix a UI file issue (automatically done by Qt Designer)
2022-06-25 16:36:50 +02:00
Wanderer Fan
175d2cf2dd [TD]remove build depend on DrawingWB 2022-06-25 10:22:30 -04:00
wmayer
4ec9c381d4 Part: re-add dropped parameter (93525ff7eb) 2022-06-25 16:14:14 +02:00
Kuzemko Alexsandr
0cd8fb12f3 [Part] Fix display "labelfillet" name for Chamfer and Fillet (#7083)
* Fix display "labelfillet" name for Chamfer and Fillet
* Synchronize options name with PartDesign_Chamfer. Proposed by  @Roy-043
@Roy-043 https://github.com/FreeCAD/FreeCAD/pull/7074#issuecomment-1165303970
2022-06-25 15:04:15 +02:00
andrea
93525ff7eb removed references to OCC<7 2022-06-25 14:29:24 +02:00
wmayer
e9890c0798 Gui/Mod: replace several reinterpret_cast with static_cast 2022-06-25 11:36:55 +02:00
Uwe
360b4282f7 [PD] Hole dialog fixes
- when there is no profile the change of the hole cut type was not handled
- for the deprecated hole cut types it must also be possible to use custom values
2022-06-25 03:31:27 +02:00
wmayer
1aa897d450 Fem: remove some superfluous const_cast 2022-06-24 19:43:33 +02:00
wmayer
8573d9f8b2 TD: fix possible dangling pointer in QGIHighlight 2022-06-24 17:39:33 +02:00
wmayer
5234d9bc67 App: add pure virtual methods to PropertyGeometry to delegate it to the geometry of sub-classes
Following the law of Demeter add some wrapper methods to PropertyGeometry and implement them in sub-classes. As a side-effect this makes some const_cast obsolete
2022-06-24 16:15:02 +02:00
wmayer
f87d9bd626 Part: [skip ci] remove superfluous const_cast 2022-06-24 16:10:09 +02:00
Wanderer Fan
9894964eb6 [TD]implement navigation styles 2022-06-24 10:03:02 -04:00
wmayer
e53e231677 Gui: remove some superfluous const_cast 2022-06-24 14:48:52 +02:00
wmayer
c955372ecf cppcoreguidelines-pro-type-union-access
According to https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md using union for type-punning is undefined behaviour.
 Replace it with std::memcpy
2022-06-24 14:29:50 +02:00
Yorik van Havre
393352387d Merge pull request #7071 from Roy-043/Draft-Fix-Placement-in-make_sketch
Draft: Fix Sketch Placement in make_sketch (issue #7058)
2022-06-24 13:53:33 +02:00
Yorik van Havre
830b3944db Merge pull request #7067 from Kuzma30/add_ts
Crowdin Add "new" WB to translations.
2022-06-24 13:50:43 +02:00
Uwe
15e3e86c5a [.github] next try to make bug reporting rule clear 2022-06-24 03:03:53 +02:00
Uwe
b12e7a8ad6 [.github] make bug reporting rule clear 2022-06-24 03:00:42 +02:00
Benjamin Alterauge
ad8bb4dc69 GeomBSplineCurve: Add interpolate without tangents
Now with description

Periodic selectable
2022-06-24 02:25:55 +02:00
mosfet80
620c273c4e Boost version <=1.60 is never used in freecad 0.20 (#7038)
* Boost version 1.60 is never used in freecad 0.20
2022-06-24 02:20:26 +02:00
0penBrain
b308da5387 [BUGFIX] Gui: fix mouse Gesture navigation mode
Regression introduced by commit c23a30b
2022-06-24 01:03:53 +02:00
Ajinkya Dahale
00e7eae6f8 [Sketcher] Use more segments while drawing splines
B-Splines can have an arbitrary number of pieces. Using the same number of
segments to draw a multi-piece spline can make the curve blocky.

This commit only changes the behavior in edit-mode.
2022-06-23 14:35:33 +02:00
marioalexis
ad0f1147f7 Part: Use PyObject_IsTrue in combination with conditional ternary operator 2022-06-22 19:50:03 -04:00
marioalexis
ea79771afd Import: Use PyObject_IsTrue in combination with conditional ternary operator 2022-06-22 19:50:03 -04:00
marioalexis
a91e32a6f4 Mesh: Use PyObject_IsTrue in combination with conditional ternary operator 2022-06-22 19:50:03 -04:00
marioalexis
37511553f7 PartDesign: Use PyObject_IsTrue in combination with conditional ternary operator 2022-06-22 19:50:03 -04:00
marioalexis
d298a7101c Path: Use PyObject_IsTrue in combination with conditional ternary operator 2022-06-22 19:50:03 -04:00
marioalexis
51f3727d3c Sketcher: Use PyObject_IsTrue in combination with conditional ternary operator 2022-06-22 19:50:03 -04:00
marioalexis
f78412c75b Gui: Use PyObject_IsTrue in combination with conditional ternary operator 2022-06-22 19:50:03 -04:00
marioalexis
ccfa6cd9e5 Main: Use PyObject_IsTrue in combination with conditional ternary operator 2022-06-22 19:50:03 -04:00
marioalexis
89803987a1 Base: Use PyObject_IsTrue in combination with conditional ternary operator 2022-06-22 19:50:03 -04:00
marioalexis
22763c9e4f App: Use PyObject_IsTrue in combination with conditional ternary operator 2022-06-22 19:50:03 -04:00
Adrian Insaurralde Avalos
69932742d2 Rename FindOpenCasCade.cmake to FindOCC.cmake
To fix a warning 'name passed to `find_package_handle_standard_args` (OCC) does not match'
2022-06-22 19:19:37 -04:00
ShuffleWire
4de0e8244e Base: add Const attribute to many MatrixPy methods
multiply(), determinant(), isOrthogonal(),
submatrix(), analyze() also get the const attribute
2022-06-22 19:16:38 -04:00