Chris Hennes
25aa4d247c
FEM: Eliminate unused proxy member
2025-06-22 19:10:48 -05:00
Chris Hennes
e38af07217
TD: Remove calls to now-empty clearLineSets() method
2025-06-22 19:10:48 -05:00
Chris Hennes
c0d22febd8
TD: Add missing override
2025-06-22 19:10:48 -05:00
Chris Hennes
0b0f3cedac
CAM: Add missing initializers
...
Also switch to designated initializers to give context.
2025-06-22 19:10:48 -05:00
Chris Hennes
757ea2db61
CAM: Add initializer for retract_mode
...
Also explicitly list fields for clarity.
2025-06-22 19:10:39 -05:00
Chris Hennes
33dda885bc
Gui: Drop name of unused parameter in PropertyBoolItem
2025-06-22 17:40:25 -05:00
Chris Hennes
93a9b87c59
Gui: Make narrowing conversion float->int explicit
2025-06-22 17:11:22 -05:00
Chris Hennes
cb34546d4c
Gui: Mark widget as [[maybe_unused]]
2025-06-22 17:06:51 -05:00
Chris Hennes
2b03016cae
Gui: Implicit capture of this is deprecated
2025-06-22 17:03:55 -05:00
Balazs Nagy
661d2052b7
find job in parent chain ( #21742 )
2025-06-22 09:18:07 -05:00
jffmichi
b74a3b5270
CAM: simplify Order Output By Tool logic and fix #21969 ( #21970 )
...
Co-authored-by: jffmichi <>
2025-06-21 12:49:49 -05:00
jffmichi
7b1775bc4c
CAM: improve Job toggleVisibility ( #21802 )
...
Co-authored-by: jffmichi <>
2025-06-21 12:49:32 -05:00
xtemp09
be542053e1
[Spreadsheet] Replace override cursor with QGraphicsItem::setCursor ( #22097 )
...
* [Spreadsheet] Replace the risky use of override cursor with
QGraphicsItem::setCursor
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
---------
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2025-06-21 12:57:07 +02:00
Chris Hennes
7619b638e7
Measure: Remove redundant check for edges > 0
2025-06-20 22:49:34 +02:00
Chris Hennes
eb69381f89
CI: Eliminate 3rd party and generated code from analysis
2025-06-20 22:49:00 +02:00
Chris Hennes
ec86e2a440
Sketcher: Remove redundant checks
...
Also cleanup missing curly braces.
2025-06-20 22:48:31 +02:00
Chris Hennes
bb1760546b
Sketcher: Remove dead code
2025-06-20 22:41:59 +02:00
Chris Hennes
f0b53af32f
Part: Remove remnants of code from TNP merge
2025-06-20 22:41:24 +02:00
Chris Hennes
965bb6d2c8
Tools: Use a safer hostname detection
2025-06-20 22:40:55 +02:00
Kacper Donat
273a84c822
Merge pull request #22015 from 3x380V/matrix4d_fixes
...
Matrix4D fixes
2025-06-20 22:39:44 +02:00
Benjamin Nauck
a6485d1ae1
Gui: Use middle elide for text in model tree
2025-06-20 22:37:37 +02:00
Max Wilfinger
45ee397b43
Gui: Add toggle overlay icons
2025-06-20 22:36:40 +02:00
Chris Hennes
b8e46288cd
Merge pull request #22094 from oursland/lint-on-pr-only
2025-06-20 14:30:40 -06:00
Benjamin Nauck
079a81c59d
Merge pull request #22025 from tetektoza/sketcher_regression_1
2025-06-20 19:21:14 +02:00
Jacob Oursland
11eaa8dc60
CI: only lint on PRs.
2025-06-20 09:57:11 -07:00
tetektoza
c8d2ae494b
Sketcher: Handle additional characters for OVP in regexp
...
Co-authored-by: Benjamin Nauck <benjamin@nauck.se >
2025-06-20 00:33:48 +02:00
Chris Hennes
5ab8e2ef17
Merge pull request #22033 from oursland/limit-lint
...
Limit lint to changed lines
2025-06-19 12:01:58 -05:00
Alfredo Monclus
acdfdd5d1b
Gui: Tasks: fix in place close and ok buttons
2025-06-19 18:42:24 +02:00
Kris
0b6a451790
Gui: Move Submenu Commands in Tool Menu ( #20864 )
...
* Moved tools submenu commands and title case
* Apply suggestions from code review
Co-authored-by: Max Wilfinger <6246609+maxwxyz@users.noreply.github.com >
---------
Co-authored-by: Kacper Donat <kadet1090@gmail.com >
Co-authored-by: Max Wilfinger <6246609+maxwxyz@users.noreply.github.com >
2025-06-19 08:33:36 +02:00
Jacob Oursland
7e8a9238fe
CI: limit C++ lint to changed lines.
2025-06-18 22:14:35 -07:00
Jacob Oursland
f23d4c8e7e
CI: determine modified lines in a clang-tidy compatible way.
2025-06-18 22:14:34 -07:00
Kacper Donat
89504d89d6
Merge pull request #21982 from tetektoza/feature/11603_render_constraints_below_geom
...
Sketcher: Prioritize rendering geometry lines rendering over constraints
2025-06-19 00:03:50 +02:00
tetektoza
0662b8c0bb
Gui: Change ordering of names in Link property
...
As the title says, currently it is:
ObjName (Label), this patch changes it to Label (ObjName) to be more
user friendly.
2025-06-18 23:38:52 +02:00
dependabot[bot]
a90a8f1fac
Bump github/issue-metrics from 3.20.1 to 3.21.0
...
Bumps [github/issue-metrics](https://github.com/github/issue-metrics ) from 3.20.1 to 3.21.0.
- [Release notes](https://github.com/github/issue-metrics/releases )
- [Commits](119b5237f4...346541fd00 )
---
updated-dependencies:
- dependency-name: github/issue-metrics
dependency-version: 3.21.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-06-18 08:32:44 -05:00
Syres916
8844319d33
[BIM][Draft][CAM] preparation for deprecation of QCheckBox… ( #21939 )
...
* [BIM][Draft]{CAM] preparation for deprecation of QCheckBox stateChanged -> checkStateChanged
2025-06-18 11:24:21 +02:00
David Tanana
3f7438a686
PartDesign: Added 1 3/16 16 threaded drill hole diameter ( #22000 )
...
* Adding UNf 1 3/16 16 to this list
* Updating type and test params
2025-06-17 08:59:00 -05:00
Chris Hennes
21b607a110
Draft: Eliminate redundant assignment to self ( #22006 )
...
* Draft: Eliminate redundant assignment to self
* Removed confusing comment.
---------
Co-authored-by: Roy-043 <70520633+Roy-043@users.noreply.github.com >
2025-06-17 09:40:01 +02:00
Furgo
38499d4470
DXF: rename "Group layers into blocks" setting ( #21896 )
...
* DXF: rename "Group layers into blocks" setting
* DXF: apply suggested improvement children => contents
* Import: DXF, change tooltip to reflect the reality of the current code
https://github.com/FreeCAD/FreeCAD/pull/21896#issuecomment-2958611607
2025-06-17 09:38:38 +02:00
tetektoza
24851dbae9
BIM: Allow user to skip dialog during type conversion
...
As the title says - this adds a new option to the dialog to `never ask
again` as well user can customize both settings through preferences.
2025-06-17 09:35:38 +02:00
tetektoza
ea006aba10
BIM: Fix IFC type assignment not being saved to file
...
As the title says, this is simple fix - basically right now anytime user
changed Link property to point to proper IFC type, we weren't writing to
the IFC file buffer to finally write it to the file if user would save
it.
So this patch makes sure we write to this buffer by calling appropriate
function, and making ifc object have proper pointer to IFC type.
2025-06-17 09:33:57 +02:00
pre-commit-ci[bot]
99da2e07c4
[pre-commit.ci] pre-commit autoupdate
...
updates:
- [github.com/pre-commit/mirrors-clang-format: c8ab0f80399e63a4fabbf5313c0606831f09742e → 64827eb3528d4dc019b01153e9fb79107241405f](c8ab0f8039...64827eb352 )
2025-06-16 18:55:48 -05:00
Kacper Donat
a0d1bb7602
Merge pull request #21965 from tetektoza/fix/21861_crashes_selection_during_deletion
...
Core: Fix crashes during item deletion in specific selection order
2025-06-17 00:39:17 +02:00
tetektoza
f5e26f2fda
Gui: Emit signal to EditableDatumLabel only if there's no digits
...
Small regression of mine, basically this signal to remove set/locked
state of EditableDatumLabel should be only sent out if current text in
the label is empty or it doesn't contain digits.
Previously it was emitted every intermediate wrong state, so stuff like
"71." was also being matched, and it resulted in resetting the locked
state of the label, which in turn resulted in keeping user from entering
float values.
2025-06-17 00:34:21 +02:00
tetektoza
4c1e7835bd
Core: Add guard in Tree to ensure we don't process items during deletion
2025-06-17 00:15:49 +02:00
tetektoza
9a9242817d
Core: Fix crashes during item deletion in specific selection order
...
This patch fixes crashes that we've noticed during migration from Qt5 to
Qt6 in recent months.
If you select items in a tree in a specific direction or range (all, or
from bottom to top) and delete them, there is a high change user will
experience a crash in `testStatus` function. This problem arises because
we're getting into use-after-free situation.
Looking at the callstack there are a lot of calls to
`itemSelectionChanged` during deletion, which takes over item creation
after deletion in `TreeWidget::_slotDeleteObject`. This in turn causes
`DocumentObjectItem::testStatus` to be called prematurely when we have
dangling pointers in object map still. `itemSelectionChanged` signal is
being transmitted because the selection range is changing as we're
constantly deleting and readding certain items.
Previously there was `blockSelection` call during deletion, but it turns
out the signals can still be emitted even AFTER we delete the item. This
had to somehow change between Qt5 and Qt6. So, to be safe, move the
signal block for selection before the obj deletion loop to be sure we
won't retransmit this signal during an uncertain state.
2025-06-17 00:01:24 +02:00
tetektoza
c13d6c8d47
Sketcher: Remove redundant comment regarding old SoAnnotation node
2025-06-16 23:57:17 +02:00
tetektoza
9c2df53f5b
Sketcher: Prioritize rendering geometry lines rendering over constraints
...
As the title says - since there is pending PR for better SoDatumLabel
constraints interactivity, this patch now prioritizes geometry lines
over constraints, so constraints will be rendered below lines.
This patch changes rendering order of constraint lines to be below
geometry lines, so now selection and rendering will be prioritized for
geometry lines instead of constraints.
This is done by changing depth buffer values and removal of SoAnnotation
node which was disabling depth buffer checks on constraints at all.
2025-06-16 23:56:47 +02:00
Roy-043
e6408f41af
Rebase and minor adjustments
2025-06-16 18:25:59 +02:00
dependabot[bot]
28a61222c4
Bump step-security/harden-runner from 2.12.0 to 2.12.1
...
Bumps [step-security/harden-runner](https://github.com/step-security/harden-runner ) from 2.12.0 to 2.12.1.
- [Release notes](https://github.com/step-security/harden-runner/releases )
- [Commits](0634a2670c...002fdce3c6 )
---
updated-dependencies:
- dependency-name: step-security/harden-runner
dependency-version: 2.12.1
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-06-16 11:18:56 -05:00
dependabot[bot]
a9f95f2b88
Bump github/codeql-action from 3.28.19 to 3.29.0
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.28.19 to 3.29.0.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](fca7ace96b...ce28f5bb42 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-version: 3.29.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-06-16 11:18:46 -05:00