Commit Graph

24861 Commits

Author SHA1 Message Date
wmayer
2a970b3045 clang: fix -Wunused-but-set-variable 2023-03-12 15:05:21 +01:00
mosfet80
4cd350d2d0 Removal of unused code due to old <5.2 Qt library (#8842) 2023-03-12 11:08:58 +01:00
Abdullah Tahiri
340ccb8ed6 Sketcher: SketchObject using the new notification system
========================================================

- CriticalMessage old signal is reconverted to new notification system. This enables to remove the obsolete old system.

- An example of how common errors can be provided with translation support is added, so that App notifications appear
translated in the NotificationArea.
2023-03-12 06:06:29 +01:00
Daniel-Khodabakhsh
827af464e3 Add various matrix related expression functions (#8603)
Adds a few new Expression functions with the goal to:

- Simplify Placement, Rotation, Vector and Matrix object creation.
- Add new matrix functions for rotation and translation.
2023-03-11 20:13:23 -06:00
Hannu Koivisto
57aac275c7 [Draft] Mitigate crash in Draft_Edit (#8749) (#8750)
This mitigates the crash reported in issue #8749.  The crash happens when
using Draft_Edit and using keyboard to enter a coordinate in Edit node
dialog.  This change partially restores behaviour before commit fc14567,
after which FreeCADGui.Control.closeDialog and showDialog calls during
execution of DraftToolBar.editUi are no longer made using the todo.delay
mechanism.  The crash can still be triggered by artificially slowing down key
event processing, so this is not a proper fix, just a mitigation.
2023-03-11 17:44:04 +01:00
Uwe
adb972319f [Sketch] reverse commit 944c02f12b
- as discussed in #8838 (the PR will be improved after the weekend)
2023-03-11 17:26:42 +01:00
Paddle
944c02f12b Sketcher: Solver Message Widget simplification. 2023-03-11 16:08:16 +01:00
BHennen
0f4acc55be Add offset options to Draft PathArray (#8295)
* Add offset options to Draft PathArray

Allows user to specify a starting and ending offset to items in Draft PathArrays.

* [Draft] path array offset

---------

Co-authored-by: Roy-043 <info@b-k-g.nl>
2023-03-11 15:54:25 +01:00
wandererfan
d0c5b7c045 [TD]remove unused override methods 2023-03-11 08:08:58 -05:00
Uwe
3c31007e58 [FEM] BoxWidget: fix duplicate names
- as reported: https://github.com/FreeCAD/FreeCAD/pull/8825#issuecomment-1464876840
2023-03-11 13:55:14 +01:00
Uwe
1e702cdca2 [FEM] adjust initial position of new box filter
- as discussed in #8825
2023-03-11 13:55:14 +01:00
Roy-043
87b63d186e [Draft] fix regression introduced with #8433 (#8840) 2023-03-11 13:35:24 +01:00
mosfet80
218269bdaf Update json (#8830)
* Update json from 3.9.1 to 3.11.2
2023-03-11 13:30:27 +01:00
marioalexis
191879b2c6 Fem: Remove property name comparison 2023-03-11 10:29:29 +01:00
Uwe
1dc9f5484f [FEM] [skip ci] BoxWidget.ui fix
- was reported and automatically fixed by Qt's Designer that the size in the file is incorrect, (the sum of the widget's widths is wider than the main widget's specified size)
2023-03-11 03:19:03 +01:00
marioalexis
a9b167ccbc Fem: Add box filter function 2023-03-11 03:13:57 +01:00
Chris Hennes
f1ffaf3ba9 Addon Manager: Handle icons with query strings 2023-03-10 17:30:51 -06:00
Chris Hennes
1f6c364fa6 Addon Manager: Refactor Metadata
Create a Python-native metadata class. Includes unit tests, and some PyLint cleanup.
2023-03-10 14:25:50 -06:00
wmayer
8532c96c20 PD: add unit test for PR #8763 2023-03-10 19:23:03 +01:00
wmayer
eb01e31174 PD: add unit test for issue #6156 or PR #8748 2023-03-10 19:05:50 +01:00
Abdullah Tahiri
f99e76056e Sketcher: Remove "Show Edit Section" from preferences
=====================================================

In a previous commit the Edit Section and its preferences where removed, however
Adrián Insaurralde realised that the setting for showing or not this section had been left behind:
https://github.com/FreeCAD/FreeCAD/pull/8716#issuecomment-1462364487

This commit just removes that settings.
2023-03-10 18:19:28 +01:00
Abdullah Tahiri
8569a4fb30 Sketcher: Remove references to non-existing icons
=================================================

User Syres realised that some commands that are in use by the solver messages url referenced non-existing icons, which
triggers errors in the report view while customising:
https://forum.freecad.org/viewtopic.php?p=666167&sid=16ac6777c440d632e5f60083fb4327ca#p666167

This commit removes them.
2023-03-10 18:18:58 +01:00
Uwe
ab327114c3 [TD] fix compiler warning about code duplication and unused variable 2023-03-10 11:25:16 -05:00
Andrew
f00b668bac remove unnecessary include 2023-03-10 16:35:13 +01:00
luzpaz
6802bed99d Fix various typos and whitespace 2023-03-10 14:40:46 +01:00
Uwe
d27e69bdc9 [PD] add tooltip for Hole feature
- tooltip makes clear what the depth means for countersinks
- add comment why a calculation cannot be performed
- shorten some long lines
2023-03-10 05:14:24 +01:00
Zheng, Lei
fac0a1740f PartDesign: do not include transform for sub-object in Feature 2023-03-10 02:06:24 +01:00
wandererfan
0adc473d53 [TD]fix error from BSpline.asCircle 2023-03-09 13:40:16 -05:00
wmayer
45e3d0be96 Sketch: export GeoListModel::getGeoListModel to fix linking error with MinGW 2023-03-09 19:38:40 +01:00
Uwe
1bfaa6965b [FEM] improve cylinder function
- set better initial position and size
- add misting triggering of ViewProvider
- some code style improvements (fix too long lines, consistency etc.)
2023-03-09 17:25:46 +01:00
Uwe
bedfd8f743 [MeshPart] fix unwrap feature
- fixes #8741
- in commit d62d41a53b the pybind headers were accidentally removed
2023-03-09 16:57:21 +01:00
Uwe
0d77da1c81 [FEM] [skip ci] fine-tune FEM function filter
- just for consistency use always the form "x.0"
2023-03-09 02:40:32 +01:00
Alexander Golubev
088f51632b PD: Fix Loft's Closed option
Closes: https://github.com/FreeCAD/FreeCAD/issues/6156
2023-03-09 01:48:32 +01:00
Uwe
fe9ebfc4c5 [FEM] [skip ci] CylinderWidget.ui fix
- was reported and automatically fixed by Qt's Designer that the size in the file is incorrect, (the sum of the widget's widths is wider than the main widget's specified size)
2023-03-08 18:02:10 +01:00
Uwe
453b244b55 [FEM] fox compilation of new Cylinder function
- vector must be initialized and vector size requires a const int

- also some sorting
- also some formatting changes to be consistent (either always "x." or "x.0")
2023-03-08 18:02:10 +01:00
marioalexis
b1e8de58ea FEM: Add cylinder filter function 2023-03-08 17:16:41 +01:00
xtemp09
61f1310aa5 [Mesh] Minor code update
Removal of unnecessary comparison.
`QThread::idealThreadCount()` returns the ideal number of threads that the process can run in parallel or 1 if it fails to determine it.
2023-03-08 13:20:45 +01:00
xtemp09
27c4b52688 [FEM] Replacement of hardware_concurrency() with idealThreadCount()
I encountered problems with std::thread::hardware_concurrency() with mingw-w64 < v8.1.

QThread::idealThreadCount() is a better alternative.
2023-03-07 17:41:35 +01:00
Abdullah Tahiri
c604d1741d Console/ILogger: Refactor and extension
=======================================

Refactor:
 - Substitute the use of variadic templates with parameter packs.
 - Use recently incorporated external library "fmt" to handle printf like formating.
 - Extensive cleaning of pragmas and unnecessary forward declarations.
 - Parameter packs and libfmt provide a much stronger type checking now, so
   conversions that are by standard implicit as bool to int need an explicit static_cast
   to avoid compilation warnings.

Extension:
 - Include a notifier field, so that the originator of the message can be provided. E.g. Document#DocumentObject
 - Include a new type of message called CriticalMessage, this message is intended to have
   special behaviour in the future. Namely, it will be used to notify forward compatilibity issues.
   It will be used to substitute the current signal/slot mechanism.
 - Include two new types of messages for user notifications (Notification and TranslatedNotification). This messages
   will be use to convey UI notifications intended for the user (such as non-intrusive message about the usage of a tool). There
   are two versions to mark whether the string provided as a message is already translated or not. When using the console system for
   notifications, these notifications may originate from the App or the Gui. In the former, it is generally the case that the strings
   of messages are not (yet) translated (but they can be marked with QT_TRANSLATE_NOOP). In the latter, often the messages to be provided
   are already translated.

Python support for CriticalMessage, Notification and TranslatedNofification, including shortcuts:

    Crt = FreeCAD.Console.PrintCritical
    Ntf = FreeCAD.Console.PrintNotification
    Tnf = FreeCAD.Console.PrintTranslatedNotification
2023-03-07 16:13:23 +01:00
wmayer
76623ad0a5 Part: set minimum angular deflection to 1 deg
See also forum: https://forum.freecad.org/viewtopic.php?t=76614
2023-03-07 10:41:38 +01:00
edi271
7dbceaffe6 [TD] Solve two issues in CmdHoleShaftFit 2023-03-06 20:02:21 -05:00
wmayer
1a0801a23f Qt6: port template and Cloud module to Qt6 2023-03-06 12:25:55 +01:00
Jonas Bähr
fb6fffa69f PD: Retranslate InvoluteGear's Task Panel on language change
This makes use of the recent additions to `TaskPanelPython` and
`UiLoader`, cf. #8602, to retranslate the UI without having to close and
reopen it again.
Retranslation of the part from the UI file is now handled by FreeCAD
internally, but the tool tips from the property descriptions still need
to be reassigned with the translated versions.
2023-03-06 00:19:04 +01:00
mosfet80
f51b2156f3 fix commit 2023-03-04 17:51:43 -06:00
mosfet80
b0831f994d Revert addonManager 2023-03-04 17:51:43 -06:00
mosfet80
3137dea940 remove Python2 code 2023-03-04 17:51:43 -06:00
xtemp09
323476a9a4 [TechDraw] Improved readability of DrawViewSpreadsheet.cpp
I was stretching my fingers
2023-03-04 09:59:02 -05:00
wmayer
599b14b430 Part: extend command Part_PointsFromMesh to support any geometric type 2023-03-04 14:44:58 +01:00
wmayer
afd59cbe82 FEM: implement interface of ComplexGeoData 2023-03-03 18:17:54 +01:00
Chris Hennes
6e7e94e342 OpenSCAD: Improve shape-checking in group action 2023-03-03 10:11:20 -06:00