Commit Graph

13086 Commits

Author SHA1 Message Date
Abdullah Tahiri
2ad1653a3f PartDesign: OnDelete basefeature fixing and visualization
=========================================================

fixes #3084
fixes #3061 (at least what it is understood in the analysis as being a bug, the visualization left).

Basically when deleting a feature, if it is the base feature (feature with which it will merge or cutout), the dependent objects'
base feature is made to be the base feature of the object being deleted. This code pre-existed at body level, but was not being called (see below).

Additionally, if the visible object is not the one being deleted, we leave that one visible. If the visible object is the one
being deleted, we make the previous object visible.

Deletion from the tree of a feature is handled by Document.removeObject, which has no clue about what a body is. Therefore, Bodies, although an
'activable' container, know nothing about what happens at Document level with the features they contain.

The Deletion command StdCmdDelete::activated, however does notify the viewprovider corresponding to the feature (not body) of the imminent deletion
(before actually doing it). Consequently, the only way of notifying a body of the imminent deletion of one of its features so as to do the clean up
required (moving basefeature references, tip management) is from the viewprovider of the feature being deleted.
2018-01-22 22:03:18 +01:00
wmayer
b863d1df75 improve whitespaces 2018-01-22 20:06:12 +01:00
Abdullah Tahiri
90cd417fe4 PartDesign: Fix bug of mirror transformation of multiple features
fixes #3317

This code ensures that an individual transformation or a multi-transformation have a proper
base feature and next feature.
2018-01-22 19:56:58 +01:00
Markus Lampert
0e11e83c68 Fixed 2885, dogbone maintaining F parameter. 2018-01-22 19:40:50 +01:00
Markus Lampert
c3dbeba4d9 Fixed recursion problem 2018-01-22 19:40:50 +01:00
Markus Lampert
0d063d91f1 Fixed path unit test setup for new PathDressup 2018-01-22 19:40:50 +01:00
Markus Lampert
50529d33e4 Changed lead-in-out dressup to use PathDressup.baseOp() instead of relying that it is dressing up an op directly. 2018-01-22 19:40:50 +01:00
Markus Lampert
8ecf31feff Removed ToolController from all dressups and replaced with recursive search for the base op's ToolController. 2018-01-22 19:40:50 +01:00
Markus Lampert
d538e88815 Prevent adding an entry method dressup to an op that's already has one. 2018-01-22 19:40:50 +01:00
Markus Lampert
d1fa0d1d37 Made dogbone resilient to all dressups and profiles. 2018-01-22 19:40:50 +01:00
Markus Lampert
0b48c98792 Fixed import of PathGeom - might want to refactor that one day. 2018-01-22 19:40:50 +01:00
Markus Lampert
e96e32580e Fixed template-export menu activation. 2018-01-22 19:40:50 +01:00
TeroK
61b202992c TechDraw: Add option to use polygonal HLR algorithm
Now on property panel there is option 'Coarse View' which allows to set
selected drawing view's Hidden Line Removal to utilize polygonal algorithm.
This should be faster on same cases (complex models).

When this option is set for a view there is known limitation with dimensions not
working on this experimental mode. At least currently this is best utilized on
view with no dimensions.

Also the vertices' 'black dots' are not drawn on this mode view to avoid
cluttering.  Face hilite is avoided, to gain speed. All curves are represented
by short linesegments in this mode.

Previously TechDraw always used OCC's exact HLR algorithm to generate views,
which produces good quality and continous shape lines but is sometimes
slower to generate than with polygonal approach.

Additionally now there is bool 'CoarseView' Parameter Editor setting, if anyone
wants to set this as their default.
2018-01-22 19:31:30 +01:00
Yorik van Havre
2a2414f2e2 Arch: Fixed wrong orientation and shape of window louvres 2018-01-21 20:57:35 -02:00
Yorik van Havre
6bd5523987 Path: Fixed possible bug in last commit 2018-01-21 17:48:16 -02:00
Sammel Lothar LTS
a23f891420 BUGFix PATH Dressup Sim FreeCADBreakdown 2018-01-21 17:43:27 -02:00
wmayer
9b28d1e226 remove SetMinTolerance as suggested by PR 1240 2018-01-21 18:17:45 +01:00
tomate44
fa85b1e76d typo 2018-01-21 17:29:17 +01:00
tomate44
e0ee9bf9ce indentation fix 2018-01-21 12:30:29 +01:00
tomate44
31ce28aa0d tolerance fix in TopoFace.validate() 2018-01-21 12:25:14 +01:00
tomate44
ecce5eea6d fix some TopoShape documentation 2018-01-21 12:03:53 +01:00
Yorik van Havre
3c679c13ca AddonManager: Download biggest code block from macro pages in case there is more than one code block 2018-01-20 22:34:53 -02:00
Abdullah Tahiri
4bfa12d86d Sketcher: Correction of B spline normals
========================================

When writting solver implementations it has to be taken into account that the normal is not to be provided in the sense of the curvature, but to
the left when walking a curve from start to end.

https://forum.freecadweb.org/viewtopic.php?f=10&t=26312#p209486

This commit has impact on all the previous files using bspline and endpoint to endpoint tangency.

A work-around is to delete the tangency and do it again.
2018-01-20 17:21:26 +01:00
Abdullah Tahiri
fd7d75b309 PartDesign: Extension of Pocket Feature to have two dimensions
fixes #2915
2018-01-20 16:15:38 +01:00
sliptonic
2375a95afd Path: changed --output-doubles to --axis-modal and reversed the default behavior
Explicit gcode is better than implicit so it is the default.  additional flags compress the size of the output and make it less explicity
2018-01-20 14:09:58 +01:00
sliptonic
d1f194c7ab Path: typo in command name 2018-01-20 14:09:58 +01:00
sliptonic
37aa7d6b81 rename command and PEP8 2018-01-20 14:09:58 +01:00
sliptonic
7559c8f57c Path New Dressup LeadInOut to perform Tool Roll towards shape including G41-42 2018-01-20 14:09:58 +01:00
sliptonic
4ae2cf53c7 path: cleanup linuxcnc post and fix vertical feed problem 2018-01-20 14:09:58 +01:00
WandererFan
c58a7d9785 Remove NewViewMulti from toolbars/menu 2018-01-20 14:07:31 +01:00
WandererFan
4f2fe1d1a5 Allow GroupExtension as Source for Views
- DrawViewPart had special case logic for App::Part.
  It now handles DocumentObjectGroup and any other
  GroupExtensions as Source.
2018-01-20 14:07:31 +01:00
luz.paz
d31f2e25b0 Misc. comment typos
[skip ci]
2018-01-20 14:04:22 +01:00
luz.paz
f0af9770b7 FEM: crowdin fix
ref: https://crowdin.com/translate/freecad/559/en-eu#6503606
[skip ci]
2018-01-20 14:02:22 +01:00
DeepSOIC
3955146bdb Part: add Refine property to BOPs
followup to PartDesign
2018-01-20 13:58:39 +01:00
DeepSOIC
1cb2d52dc2 PartDesign: #2683 add Refine property
resolves #2683

Adds Refine property to sketch-based and transformation features. The
property is initialized according to preferences, and can be altered in
property editor on per-feature basis.
2018-01-20 13:58:39 +01:00
wmayer
4d8026762c avoid division by zero when discretizing a shape 2018-01-20 00:02:08 +01:00
wmayer
fd8562bce2 raise exception in PropertyLinkSubList::setPyObject for wrong type 2018-01-18 15:53:51 +01:00
Yorik van Havre
a332feb2c6 Merge pull request #1229 from sliptonic/master
Renaming Path Commands to comply with standard.  Typos and PEP8 cleanup.
2018-01-17 22:13:27 -02:00
sliptonic
ea82c8f379 Merge branch 'master' into master 2018-01-17 13:28:35 -06:00
Yorik van Havre
b451ba87fe Draft: Fixed wrong wire point position - closes #3063 2018-01-17 10:49:24 -02:00
sliptonic
99d6fac187 Merge pull request #7 from luzpaz/path-source-typo
Path: source typo fix
2018-01-16 00:35:28 -06:00
sliptonic
2814b4600a Path: rename Set_StartPoint to conform to command name standard
PEP8
2018-01-16 00:32:35 -06:00
sliptonic
15c62d3685 Path: rename dressup commands to conform to standard
PEP8 cleanup
2018-01-16 00:32:35 -06:00
luz.paz
c53f8bbc15 Path: source typo fix 2018-01-15 21:05:03 -05:00
wmayer
67f364c859 fix automatic update of dependency graph for Qt5 2018-01-15 23:54:31 +01:00
wmayer
eabfffe72a fix automatic update of dependency graph 2018-01-15 22:19:05 +01:00
looooo
1e1348ae2f update circle-ci 2018-01-14 22:29:25 +01:00
looooo
4ec69262e2 update conda dependency versions:
boost 1.66
xerces-c 3.2.0
2018-01-14 22:29:25 +01:00
looooo
71072b0738 PathScripts: py3 print
Draft: typo in importDXF.py
2018-01-14 22:29:25 +01:00
luz.paz
6781df5ec4 Fixed source typo
Fixed for better search quality through the code.
2018-01-14 22:27:17 +01:00