kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
42,871 Commits 41 Branches 6 Tags
2c5d8bce3e173707794a513c6ec320144c3ffbf2
Commit Graph

3684 Commits

Author SHA1 Message Date
Max Wilfinger
8233dde058 Sketcher: Fix UI strings 
Closes: #22770
 2025-08-04 20:13:04 +02:00
luzpaz
2d39b21517 Fix various typos (#22836) 
* Fix various typos
Found via codespell

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
 2025-08-04 11:14:15 -05:00
Johannes Wüller
1e42193ca6 Sketcher: Fix external geometry out-of-bounds vector access (#22181) 
* Sketcher: Fix external geometry out-of-bounds vector access

---------

Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org>
Co-authored-by: Ajinkya Dahale <AjinkyaDahale@users.noreply.github.com>
Co-authored-by: Benjamin Bræstrup Sayoc <benj5378@outlook.com>
 2025-07-29 18:36:17 +00:00
theo-vt
30ce2ef619 Sketcher: Change the style of the curves in creation to match the construction/defining flag (#22407) 
* Sketcher: Change EditCurvesDrawStyle to match either CurvesDrawStyle or CurvesConstructionDrawStyle in editDraw()

* Match color as well

* Match pattern scale as well

* Use enum instead of boolean flag

* Update src/Mod/Sketcher/Gui/Utils.h

---------

Co-authored-by: Kacper Donat <kadet1090@gmail.com>
 2025-07-28 02:33:25 +00:00
Kacper Donat
17381534a7 Merge pull request #22736 from chennes/sketcherCodeQLCleanup 
Sketcher CodeQL cleanup
 2025-07-26 11:21:53 +02:00
Chris Hennes
71a9a3af25 Sketcher: Clean up some old commented out code 2025-07-25 19:12:30 -05:00
Chris Hennes
34c0a1760e Sketcher: Fix increment of parabola constraint tag 
It is an invisible and unstated assumption of the redundant-constraint
removal code that the "tag" of a constraint can be used as the index
into the SketchObject's Constraint list. This is true for all objects
except a parabola, which, when creating its internal alignment focus
constraints, incremented the ConstraintCounter for *each* of the
internal constraints, instead of only once.
 2025-07-25 22:03:10 +02:00
Luz Paz
ece1235f6c Fix various source comment typos 
Found via codespell
 2025-07-25 10:25:54 -05:00
Chris Hennes
359542df67 Sketcher: Extract "processFace" function 
Tool-aided refactor, no functional changes.
 2025-07-25 10:08:29 -05:00
Chris Hennes
06a8685990 Sketcher: Resolve "Declaration hides variable" 
Reduce some code duplication via helper method.
 2025-07-25 09:48:34 -05:00
Chris Hennes
70811ee630 Sketcher: Resolve "Type confusion" CodeQL critical warning 2025-07-25 09:21:43 -05:00
matthiasdanner
57f251d742 Sketcher: Display arc angle and length constraints beyond center point (#22651) 
* Allow arc segment length and angle constraints to go past the center point

* fix angle helper lines

* fix linter warning

* fix arc length calculation

---------

Co-authored-by: Matthias Danner <28687794+matthiasdanner@users.noreply.github.com>
 2025-07-25 13:57:21 +02:00
Kacper Donat
0270515a33 Merge pull request #22660 from chennes/fixMultResultConvertedToLargerType 
Fix mult result converted to larger type
 2025-07-25 10:20:03 +02:00
Kacper Donat
4e8b4151d9 Merge pull request #22577 from AjinkyaDahale/sk-fix-22352 
Sketcher: Avoid crash when using trim as described in #22352
 2025-07-25 00:16:28 +02:00
Syres916
3ac0ab3abd [Sketcher] Ensure All Reference Constraints are Read Only in the Property Editor 2025-07-24 08:40:09 -05:00
Chris Hennes
c1bc10f4d6 Sketcher: Fix multiplication result converted to larger type 2025-07-21 23:40:56 -05:00
Benjamin Nauck
fb48707ef3 Sketcher: Add support for more than 3 points 
While this adds a new way, it keeps the old to make it easier to merge.
This will allow other work to be merge before without rebase issues
 2025-07-21 18:02:23 +02:00
Benjamin Nauck
7e8a65b82b Sketcher: Initialize constraint members in class declaration 2025-07-21 18:02:23 +02:00
wmayer
9cc45f5efe Sketcher: fix for issue 12925 2025-07-21 10:55:06 -05:00
PaddleStroke
64c8ec77f8 Sketcher: Dimension: Offset the label when moving mouse (#22387) 
* Sketcher: Dimension: Offset the label when moving mouse

* Sketcher: Create dedicated enum for offset boolean

This improves readability because the intent must be stated explicitly.

---------

Co-authored-by: Kacper Donat <kadet1090@gmail.com>
 2025-07-20 19:47:21 +02:00
matthiasdanner
d3887d09a4 Sketcher: Add second arc helper on diameter constraint (#22579) 
* add second arc helper on diameter constraint

* fix linter warnings

---------

Co-authored-by: Matthias Danner <28687794+matthiasdanner@users.noreply.github.com>
 2025-07-20 19:46:49 +02:00
Chris Hennes
fd14f657e6 Merge pull request #22227 from kadet1090/refactor-tool-hints 
Sketcher: Refactor Tool Hints
 2025-07-20 12:05:15 -05:00
PaddleStroke
15f2bb741e Sketcher: Fix random gray icon (#22502) 
* Sketcher Fix #10027
 2025-07-20 00:17:58 +02:00
Kacper Donat
139871dad9 Sketcher: Declare tr function for DrawSketchHandler 2025-07-19 10:05:09 +02:00
Kacper Donat
919ca877bc Sketcher: Use generic tool hints table for DrawSketchHandlerBSpline 2025-07-19 10:05:09 +02:00
Kacper Donat
403540ce66 Sketcher: Use generic tool hints table for DrawSketchHandlerTranslate 2025-07-19 10:05:09 +02:00
Kacper Donat
dc77ed7830 Sketcher: Use generic tool hints table for DrawSketchHandlerSlot 2025-07-19 10:05:09 +02:00
Kacper Donat
a019ae871d Sketcher: Use generic tool hints table for DrawSketchHandlerScale 2025-07-19 10:05:08 +02:00
Kacper Donat
ee3261482c Sketcher: Use generic tool hints table for DrawSketchHandlerRotate 2025-07-19 10:05:08 +02:00
Kacper Donat
f1eb315f20 Sketcher: Use generic tool hints table for DrawSketchHandlerRectangle 2025-07-19 10:05:08 +02:00
Kacper Donat
ec6ef0c43a Sketcher: Use generic tool hints table for DrawSketchHandlerPolygon 2025-07-19 10:05:08 +02:00
Kacper Donat
14f25dc4b3 Sketcher: Use generic tool hints table for DrawSketchHandlerLineSet 2025-07-19 10:05:08 +02:00
Kacper Donat
8824646d27 Sketcher: Use generic tool hints table for DrawSketchHandlerLine 2025-07-19 10:05:08 +02:00
Kacper Donat
fd6c654561 Sketcher: Use generic tool hints table for DrawSketchHandlerFillet 2025-07-19 10:05:08 +02:00
Kacper Donat
d3e823d5e0 Sketcher: Use generic tool hints table for DrawSketchHandlerExtend 2025-07-19 10:05:08 +02:00
Kacper Donat
817fd9e638 Sketcher: Use generic tool hints table for DrawSketchHandlerEllipse 2025-07-19 10:05:08 +02:00
Kacper Donat
f595ee5e07 Sketcher: Use generic tool hints table for DrawSketchHandlerCircle 2025-07-19 10:05:08 +02:00
Kacper Donat
bfb9d47ec6 Sketcher: Use generic tool hints table for DrawSketchHandlerBSpline 2025-07-19 10:05:08 +02:00
Kacper Donat
c4f4f89100 Sketcher: Use generic tool hints table for DrawSketchHandlerArcSlot 2025-07-19 10:05:08 +02:00
Kacper Donat
dea79014ef Sketcher: Use generic tool hints table for DrawSketchHandlerArcOfParabola 2025-07-19 10:05:08 +02:00
Kacper Donat
43208d2d2e Sketcher: Use generic tool hints table for DrawSketchHandlerArcOfHyperbola 2025-07-19 10:05:08 +02:00
Kacper Donat
5184c1008c Sketcher: Use generic tool hints table for DrawSketchHandlerArcOfEllipse 2025-07-19 10:05:08 +02:00
Kacper Donat
d385a21847 Sketcher: Use generic tool hints table for DrawSketchHandlerArc 2025-07-19 10:05:08 +02:00
Ajinkya Dahale
1ff83fcf23 Sketcher: Improve constraint transfer in SketchObject::trim() 
Provide new geos to `deriveConstraintsForPieces` manually, since they are
not (and likely cannot be at time of calling) added to the sketch. This will
make sure that the method has sufficient information to properly transfer/create
new constraints.
 2025-07-19 03:25:38 +05:30
Ajinkya Dahale
095d905a86 Sketcher: Skip checks in deriveConstraintsForPieces when risky 
Possibly fixes #22352.

It is possible to call the method when new geos are not yet created or added to
the sketch. In such cases, the values obtained can be "dirty", and is likely a
seg-fault.
 2025-07-19 03:25:38 +05:30
theo-vt
41f539dbaf Sketcher: Only autoscale if the datum being edited is the scale defining datum (#22419) 2025-07-18 09:58:30 -05:00
Florian Foinant-Willig
311108a3ab Sketcher: manage legacy negative circle-line distance (#22203) 
* manage legacy negative circle-line distance

* Add test for legacy negative circle-line distance
 2025-07-17 23:00:38 -05:00
matthiasdanner
870f1266f9 Sketcher: Fix Constraint Filter Handling (#22072) 
* Fix SpecialFilter Handling for selected and associated constraints
Fix show constraints in 3d view if no constraints in list and filter to only show selected is disabled

---------

Co-authored-by: Matthias Danner <28687794+matthiasdanner@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org>
 2025-07-17 07:51:44 +00:00
PaddleStroke
905d73b00d Sketcher: add ConstraintLineByAngle helper. (#22273) 
* Sketcher: add ConstraintLineByAngle helper.

* Update src/Mod/Sketcher/Gui/Utils.cpp

* Update src/Mod/Sketcher/Gui/Utils.cpp

---------

Co-authored-by: Kacper Donat <kadet1090@gmail.com>
 2025-07-14 19:44:32 +00:00
Florian Foinant-Willig
0ad55281ad Sketcher: clean planegcs/Geo (#22378) 
* Sketcher: clean planegcs/Geo
 2025-07-14 10:56:25 -05:00