Gabriel Wicke
4a87209cb5
Path: Safer step over optimization
...
- Only apply aggressive optimizations to short horizontal moves within
cutter diameter. The safe model STL does not accurately reflect stock
state, so using it for determining long distance move safe heights is
not safe. There would be a high chance of hitting the stock at rapid
speeds.
Thankfully, the vast majority of step-overs tend to be short, so are
still optimized.
- For short moves, only allow completely lift-free transitions when
there is (almost) no Z change, and the min safe travel height does not
rise above the same level.
Otherwise, lift to the max of end points and min safe travel height
first, then move horizontally. A future optimization would be to
directly use the drop scan for transition path generation.
2020-05-23 20:18:37 -07:00
Daniel Wood
cd97f871a7
Enable the selection of circles, arcs and faces to set the job origin
2020-05-23 16:30:55 +01:00
Russell Johnson
786d96ae60
Path: Expose property creation process to user access; Code cleanup
...
Path: EOL syncs with source
PathSurface and PathWaterline modules have incorrect, Windows, line endings and need to be converted to Unix style.
2020-05-21 23:24:17 -05:00
Russell Johnson
8f9cae4a77
Path: Update for inter-panel visibility updates
...
Also, clear`singleStep` and `value` properties for `StepOver` spinBox in UI panel.
2020-05-21 23:24:17 -05:00
Russell Johnson
88661c1b92
Path: Add ProfileEdges and AvoidLastX_Faces inputs to GUI
...
Path: Set min & max values for `StepOver`
2020-05-21 23:24:17 -05:00
Russell Johnson
49853d5484
Path: LGTM cleanup and PEP8
2020-05-21 23:24:17 -05:00
Russell Johnson
562b834f54
Path: Relocate common 3D Surface and Waterline methods to support module
2020-05-21 23:24:17 -05:00
Russell Johnson
090fe69627
Path: Use lazyloader for importing some modules
2020-05-21 23:24:17 -05:00
Russell Johnson
a9ee9af710
Path: Improvements to user messages
...
Remove some messages.
Implement FreeCAD.Console.Print___() in place of PathLog.___().
Path: fixes
2020-05-21 23:24:17 -05:00
Russell Johnson
d4fafcc34c
Path: new FindUnifiedRegions class
...
Improve `HandleMultipleFeatures` processing when set to `Collectively` by implementing new class to refine the processing area, attempting to remove common edges between connected face regions.
2020-05-21 23:24:17 -05:00
Russell Johnson
29a1ba60f6
Path: Improve open-edges, messaging, Final Depth initial guess and more
...
Open-edges will now work in simple cases where user selects bottom edge, without requiring adjustment to Final Depth. This will speed up procedural usage of the operation for open edges by re-enabling the `select-edge_create_OK` work flow.
The guessing procedure for Final Depth based on Base Geometry selected is fixed in `UpdateDepths()` method.
Improvements to user messages.
Remove unnecessary code and comments.
Improve debugging feedback.
2020-05-21 22:44:50 -05:00
sliptonic
517ae79341
Merge pull request #3477 from gwicke/pathops_ui_fix
...
[path] Small fix in PathOpGui
2020-05-18 09:44:21 -05:00
Russell Johnson
94cff2135e
Extend fix to updateVisibility() call
...
Call originates in PathOpGui module.
2020-05-17 21:20:04 -05:00
Gabriel Wicke
a17645aa05
[path] Small fix in PathOpGui
...
Fix a bad call to page.updateVisibility
2020-05-17 17:11:14 -07:00
Gabriel Wicke
6e90d8e10f
Path: LinuxCNC postprocessor scalability
...
- Do not show editor when gcode size exceeds 100kb. The poor editor
widget cannot handle that much output, and will hang FreeCAD.
- Avoid quadratic behavior in output accumulator. While Python greater
than 2.7 avoids quadratic behavior in string accumulators, this optimization
is defeated when the string is forced to be materialized to contiguous
memory, as was done by the `.trim()`. As a result, we got quadratic complexity,
ensuring that large jobs would never successfully be post-processed.
2020-05-17 13:31:44 -07:00
Russell Johnson
ffc353f294
Path: Fix for .extrude() vector roughly zero
2020-05-13 21:55:06 -05:00
Russell Johnson
a679356b48
Path: Add if edge: test clause
...
`If edge:` handles 'NoneType' edges returned from `PathGeom.edgeForCmd()`.
Includes some PEP8 formatting.
2020-05-13 21:55:06 -05:00
Russell Johnson
58ba0e1c39
Path: Fix related to linkStockAndModel checkbox.
...
The StockEdit class is reused by BoundaryDressup, and this checkbox does not exist in its UI panel.
2020-05-13 16:34:06 -05:00
sliptonic
9c27f1078e
Merge pull request #3443 from Russ4262/UnifiedProfile
...
Path: Combine Contour, Profile Faces and Profile Edges into unified Profile operation
2020-05-12 12:06:36 -05:00
luz.paz
6df8201186
Fix typos [skip-ci]
...
Found via codespell v1.17.0.dev0
```
codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,ba,beginn,behaviour,bloaded,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,orgin,orginx,orginy,ot,pard,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml
```
2020-05-12 10:04:29 +02:00
Russell Johnson
a17c3e97c6
Path: Update selection gates pertaining to unified Profile operation
2020-05-10 23:07:53 -05:00
Russell Johnson
dcd6f0ee97
Path: Improve geometry selection and Cancel operation error messages
2020-05-10 23:07:53 -05:00
Russell Johnson
0e48eb1e85
Path: PEP8 and LGTM cleanup; Remove extra addProperty() statement
...
Removed 'EnableRotation' property addition because it is done in PathAreaOp module upon creation and document restore.
2020-05-10 23:07:53 -05:00
Russell Johnson
edbe6c4f2f
Path: Additional fixes and improvements to unified Profile operation
2020-05-10 23:07:53 -05:00
Russell Johnson
00226b6654
Path: Implement backwards compatibility
...
Source modules are replaced with pass-through code to send pre-existing profile-based operations to new unified `Profile` operation.
Path: Set line endings to Unix style
2020-05-10 18:19:42 -05:00
Russell Johnson
2309343b29
Path: Integrate unified Profile operation into PathWB
...
Remove Contour, Profile Faces, and Profile Edges icons from PathWB GUI. Files are still fully in tact and available.
2020-05-10 18:19:42 -05:00
Russell Johnson
5d91213292
Path: Consolidate Contour, ProfileFaces, and ProfileEdges
...
No geometry selection defaults to Contour operation.
Path: Add new unified `Profile` operation modules
2020-05-10 18:19:42 -05:00
Russell Johnson
de666296f9
Path: Update 'Operation' panel visibility when 'Base Geometry' changes
2020-05-10 18:19:42 -05:00
Russell Johnson
ece3d797aa
Path: Add method, 'updatePanelVisibility()'
...
New method allows one panel to update visibility on another panel.
2020-05-10 18:19:42 -05:00
Russell Johnson
e1322b9cf1
Path: Add reference to parent class within child class
2020-05-10 18:19:42 -05:00
Russell Johnson
39636cac21
Path: Initiate unification of ProfileFaces and ProfileEdges operations
...
ProfileFaces now accepts and processes faces and edges.
Full functionality is maintained (so far as tested) with respect to original operations.
2020-05-10 18:19:42 -05:00
Daniel Wood
45d9c23c27
Translate user messages
2020-05-09 10:39:48 +01:00
Daniel Wood
c9dc4963d9
Use PathLog for user notices
2020-05-09 10:35:55 +01:00
Daniel Wood
38a47daca7
PathOp PEP8 Formatting Fixes
2020-05-09 09:02:16 +01:00
Daniel Wood
0f1bdd30ed
PathJob PEP8 Formatting Fixes
2020-05-09 08:51:36 +01:00
Daniel Wood
e906192d20
Clean up unused code and comments
2020-05-09 08:41:48 +01:00
Daniel Wood
1d9c1f89bd
reword feedrate error when no tool controller is selected
2020-05-09 08:34:55 +01:00
Daniel Wood
526328dca5
Change feedrate error to warning.
2020-05-09 08:34:10 +01:00
Daniel Wood
9a43391b32
remove job level warning for cycle time error
2020-05-09 08:22:26 +01:00
Daniel Wood
88fe95201c
Reword property description to reflect job rather than op
2020-05-09 08:12:17 +01:00
sliptonic
1b7edf4020
Merge pull request #3444 from dubstar-04/fixes/simulation-active-ops
...
[Path] - fixes/simulation
2020-05-08 21:50:00 -05:00
Zibibbo84
b4b16fef40
Adding HEIDENHAIN CNC Mill post-processor for PathScript
2020-05-08 21:50:23 +02:00
Daniel Wood
35b50ba4a4
PEP8 formatting fixes
2020-05-08 07:41:37 +01:00
Daniel Wood
cdb3b669c6
clean up comments and unused code
2020-05-08 07:30:53 +01:00
Daniel Wood
95fb174386
Simulation - only load active operations
2020-05-08 07:16:57 +01:00
sliptonic
da7a5e74c1
Merge pull request #3433 from dubstar-04/fixes/toolbit-simulation
...
[Path] - Fixes/toolbit simulation
2020-05-06 13:56:45 -05:00
sliptonic
a1f0de32ed
Merge pull request #3430 from Russ4262/ProfileEdges_Fix
...
Path: Fix `extrude()` fails with zero vector
2020-05-06 13:56:10 -05:00
luz.paz
ceb23799c7
Fix various typos
...
Found via codespell v1.17.0.dev0
```
codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,ba,beginn,behaviour,bloaded,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,orgin,orginx,orginy,ot,pard,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml
```
2020-05-05 09:49:08 +02:00
Daniel Wood
65dcdf1515
Try and catch errors when getting the tool profile
2020-05-04 20:53:36 +01:00
Daniel Wood
15a1d34b69
Clean up debug prints
2020-05-04 20:53:36 +01:00