Commit Graph

31869 Commits

Author SHA1 Message Date
0penBrain
304b88b84e CI: fix typo in runTests action name 2023-02-13 11:27:26 +01:00
0penBrain
590e7a84d3 CI: spell checker silently fails 2023-02-13 11:27:26 +01:00
0penBrain
3a7f8c70ca CI: deleting used artifacts in wrapup is allowed to silently fail 2023-02-13 11:27:26 +01:00
0penBrain
1b2795cd2a CI: rename Ubuntu jobs in master workflow to clarify 2023-02-13 11:27:26 +01:00
Uwe
3c30c389bb [FEM] register new result values to DataAtPoint filter
- also sorting to keep the overview
2023-02-13 02:50:34 +01:00
Jonas Bähr
dc1130bf28 PD: Improve InvoluteGear's fillet generatrion
Previously, the fillet started at a fixed value, tailored at 20° pressure
angle, a fillet radius of 0.375 and a dedendum of 1.25. With PR #8184
those values became user-adjustable and thus the assumptions of the
original code are not fullfilled any more. This resulted in significant
artefacts, especially for higher pressure angles or smaller dedendums as
commonly found in splines.

This commit actually calculates the junction between fillet and involute
so that the tangents of the both curves match.
The mathematical approach is described in source code comments.

The change in the fillet calculation also affects compatibility with
files generated by earlier versions of FreeCAD. Those changes are way
below 0.1% per tooth, however the earlier test required absolute equality
down to the micron. This was relaxed and also changed to a relative, per
tooth, tolerance.

There is one particular case where the new algorithm performs slightly
worse, though. That is when the fillet radius is too large to the
dedendum, i.e. resulting in a single arc instead of two fillets, and
effectively cannibalizes some of the clearance. This happens with internal
gears having less than 25 teeth. At about 15 teeth it becomes visible
that the fillet is not 100% tanget any more. However, as such a low
number of teeth is highly unusual for internal gears and the effect,
although noticeable, is minor, the overall benefits of the new algorithm
outweighs the drawbacks. And now with the fillet radius being adjustable
it is easy to fix, too.
The technical reason is that the tangency is calculated correctly, but
the fillet circle is displaced aferwards to avoid an overlap of the two
fillets. For the new fillet position, the tangents do not align any more.
2023-02-13 02:31:28 +01:00
Jonas Bähr
b053c58308 PD: Expose new gear properties to the SVG generator
This little script has proven to be a vauable debugging aid, so it got
some love. All the new properties from #8184 can now be set, together
with the option to generate internal gears.
2023-02-13 02:31:28 +01:00
Uwe
f7df219b7b [Part] extend SectionCutting feature for intersecting objects
- it is a well-known and often feed-backed missing feature that SectionCuttings fails for intersecting objects.
To resolve this, the objects must be put int a BooleanFragments object.
- this PR adds this functionality as option.
- since a BooleanFragments objects has a specific color, the different colors of the objects cannot be preserved. Because of this disadvantage, the BooleanFragments option will not be the default.

- this PR also modernize all for loops
2023-02-13 00:46:37 +01:00
Uwe
a4b4bc99e0 [App] License.cpp: add missing include
- does otherwise not compile on Windows
2023-02-12 21:25:08 +01:00
wmayer
3abeb547b9 App: support of method unsetupObject in Python feature classes 2023-02-12 20:01:09 +01:00
wmayer
19420ed747 tests: add unit tests for License 2023-02-12 19:57:41 +01:00
wmayer
1a1f814a71 App: refactor license handling to reduce code duplication 2023-02-12 19:57:41 +01:00
wmayer
d6208d9b9a Part: fixes to create a NURBS for the arc of a conic
See forum: https://forum.freecad.org/viewtopic.php?t=75846
2023-02-12 19:45:00 +01:00
0penBrain
ebc5cb16a9 [Core] Add possibility to set color with tuple of integers, fixes #8344 2023-02-12 18:16:59 +01:00
wandererfan
e9e68c5bf3 [TD]fix face hatch location inSvg export 2023-02-12 11:50:20 -05:00
Roy-043
d4e76f9c07 [Draft] fix #8433 regression (#8452) 2023-02-12 14:22:52 +01:00
Adrien GUICHARD
5cb420048b Add TaackPLM_workbench_icon.svg in resources 2023-02-12 10:38:47 +01:00
alexneufeld
e9d4583f7c Gui: Add CERN OHL to default licenses list 2023-02-12 10:31:59 +01:00
ieternalleo
f5c2149fe8 Mesh: Update error message to inform of missing mesh file format upon export 2023-02-12 10:29:35 +01:00
marioalexis
7e0d84ff0b App: Fix warnings -Wignored-qualifiers 2023-02-11 14:16:46 -08:00
luzpaz
5f487cadce Draft: [skip ci] fix typo in source comment (#8434)
Fixed typo in `draftutils/gui_utils.py`
2023-02-11 21:02:27 +01:00
paul
646ceaede2 [Arch Component] Fix placement multiplication problem (re-PR) (#6617)
* [Arch Component] Fix placement multiplication problem (re-PR)

- see forum discussion : https://forum.freecadweb.org/viewtopic.php?f=23&t=67008

* Update ArchComponent.py

Manual edit to avoid merge conflicts.

---------

Co-authored-by: Roy-043 <70520633+Roy-043@users.noreply.github.com>
2023-02-11 20:43:28 +01:00
wandererfan
76ffee77bc [TD]fix validation of hybrid dimension 2023-02-11 13:30:15 -05:00
wandererfan
25e6f33725 [TD]centralize balloon prefs 2023-02-11 13:30:15 -05:00
Roy-043
9c44d85161 [Draft] fix diffuse color issue when creating arrays (#8436) 2023-02-11 18:57:28 +01:00
wmayer
a8a6a7ac25 Fixes #8206: FreeCAD segfaults being run with parameters (e.g .desktop file has /usr/bin/freecad --single-instance) 2023-02-11 17:49:52 +01:00
Roy-043
84e609b469 [Draft] some arrays did not have a Count property (#8433) 2023-02-11 17:09:02 +01:00
Roy-043
4337885383 [Draft] update of Draft_Clone related to gui_utils.get_diffuse_color (#8430) 2023-02-11 16:21:18 +01:00
Roy-043
9224946bec [Draft] fix Draft_Mirror diffuse color issue. (#8427) 2023-02-11 11:18:00 +01:00
Uwe
f984c46d39 [FEM] fix bug in potential constraint task panel
- fix logic of a checkbox
2023-02-11 04:41:15 +01:00
berniev
3496858451 Still more improvements to Report Summary
Final Report doesn't distinguish system settings

Added ability to have 'sections' to group stuff
Added value function to display options as ON / OFF / value / -undefined-
Added sections System, Config, Libraries
Added a bunch of data to System and Config. Moved some out of Libraries as appropriate.
2023-02-10 20:29:16 -07:00
Uwe
b104dba959 [Material] editor: improve float input
- it is very annoying to get a dozen decimals on editing floats. 6 do the job for all cases and a spinBox is preferred.
2023-02-11 04:14:30 +01:00
Chris Hennes
2cef6d6cf4 Addon Manager: Add data for integration tests 2023-02-10 16:19:17 -07:00
Chris Hennes
64c03a0603 Addon Manager: Prep Addon for refactoring 2023-02-10 15:31:06 -07:00
Chris Hennes
2aba1be25e Addon Manager: Add more unit test mocks 2023-02-10 14:37:16 -07:00
wmayer
b3322a4556 FEM: raise an exception if no valid object is selected 2023-02-10 21:10:25 +01:00
Chris Hennes
51d42630ac App: Add basic test for new Metadata code 2023-02-10 12:40:55 -07:00
Chris Hennes
8fdc780133 App: Cleanup Metadata 2023-02-10 12:40:55 -07:00
Chris Hennes
766923a3da App: Add support for in-memory Metadata creation 2023-02-10 12:40:55 -07:00
Chris Hennes
a637937cac Addon Manager: Reload page when following links
Partially addresses #8361 by ensuring that when an external link is followed, the internal page gets reloaded instead of showing an error page.
2023-02-10 12:19:44 -07:00
Uwe
3b653b78f9 [FEM] Elmer: add support for 3D magnetodynamics
- adds the corresponding Elmer equation (it is now possible to do Elmer's tutorial example no. 14)
2023-02-10 19:48:31 +01:00
Uwe
5a39a9b4b1 [FEM] change hiding logic on calling task panels
- the typical workflow is to change e.g. a constraint setting or material property and to check how and if this change changes the simulation result. it is therefore very annoying that on every call of a task panel the results are hidden.
This PR changes this to hide only meshes and the filter functions but to keep the results. If a user don't like to see results for example to select faces, he hides results anyway.
2023-02-10 16:47:52 +01:00
Uwe
72969d5931 [FEM] ViewProviderFemPostObject: fix a typo 2023-02-10 16:08:03 +01:00
wmayer
0780409fcc Spreadsheet: fix some warnings and issues reported by GH actions 2023-02-10 16:06:46 +01:00
wmayer
0b064b6f44 smesh: std::iterator<> is deprecated in C++17 2023-02-10 14:18:01 +01:00
Uwe
a14efad44c [FEM] Elmer: fixes for Magneto2D writer
- assure a 2D coordinate system is used
- get rid of annoying numerical artifacts
2023-02-10 02:21:21 +01:00
Chris Hennes
8e9f9bba53 cMake: Clean up old Mac Python search 2023-02-09 17:57:47 -07:00
Uwe
2cc8c49d49 [FEM] use extended current density constraint for 2D
-also a fix bug that for 2D there is no z-component of magnetization
2023-02-10 01:30:14 +01:00
Uwe
850f392a7c [FEM] extend current density to 3D
- to be used for magnetodynamic 3D equation
2023-02-10 01:30:14 +01:00
sliptonic
5c2955cb42 Merge pull request #8307 from LarryWoestman/staging
Path:  Refactored the add_parameters function into individual functions.
2023-02-10 00:37:09 +01:00