kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
39,474 Commits 41 Branches 6 Tags
3164ee18499732d926027b2b52fb31a8c8a48576
Commit Graph

3357 Commits

Author SHA1 Message Date
Jiří Pinkava
3164ee1849 [PartDesign]: Sort sketches in Attach sketch tool alphabetically 
The order of sketches in sketch attaching tool is now determined
by the order in which they were added to document.
Sorting them alphabetically makes IMHO much easier to find a sketch
by user, compared to current state, especially in large and complex
projects with lot of sketches. Of cuser thix expects the user
use sensible names for the sketches.
 2024-12-06 11:52:59 -05:00
PaddleStroke
760091bc8a Sketcher: Fix first external geo deletion failure. 2024-12-05 15:23:25 +01:00
luzpaz
96c838f3b9 Fix various typos 
Found with codespell
 2024-12-04 23:18:00 -05:00
wmayer
c1a75bbafc Fix compiler warnings 2024-12-04 09:50:09 -05:00
Ajinkya Dahale
6c3d2eff64 [Sketcher] Use variable for frequently used static cast in trim 2024-12-04 00:57:41 +05:30
Ajinkya Dahale
b2c806d227 [Sketcher] Remove some commented code from SketchObject::trim() 
...and replace with a TODO
 2024-12-04 00:57:41 +05:30
Ajinkya Dahale
d8a86e4e9d [Sketcher] Remove some unneeded comments 2024-12-04 00:57:41 +05:30
Ajinkya Dahale
0b32db53ed [Sketcher] Use switch-case in getPointForGeometry() 
Minor readability improvement.
 2024-12-04 00:57:41 +05:30
Ajinkya Dahale
5262482bc4 [Sketcher] Refactor SketchObject::trim() 
1. Use `Part::GeomCurve::createArc()`
2. Refactor constraint logic in `trim`
 2024-12-04 00:57:40 +05:30
Ajinkya Dahale
1cee07cb26 [Sketcher] Add some utility functions to Sketcher::Constraint 
`involvesGeoId`, `invovesGeoIdAndPosId`, `substituteIndexAndPos`
 2024-12-04 00:57:40 +05:30
Ajinkya Dahale
0d27efbc2f [Sketcher] Some trivial for loop changes in SketchObject 2024-12-04 00:57:40 +05:30
Ajinkya Dahale
7d8a8b7cc8 [Sketcher] Attempt to fix toponaming issue on trim refactor 
TNP fix algorithm doesn't seem to like when edge with geoId 0 is deleted/made
construction after new geometry is added. Instead, we just ensure that one of
the newly added geometries becomes geoId 0 instead.

Making a `generateId(const Part::Geometry*)` was part of earlier attempts, but
still appears to remain relevant. This part can be reverted if necessary.
 2024-12-04 00:57:40 +05:30
Ajinkya Dahale
263331f6fb [Sketcher] Refactor SketchObject::trim() 
DO NOT MERGE because not complete: not all constraints are not transferred.

Includes:

* Adjust `deriveConstraintsForPieces` for trim
* Make sure new points are constrained on the cutting edges
* Add constraints at trim end(s) dependent on pre-exisiting ones with cutting curve(s). Also change tests to reflect that auto-coincidence can now be applied to non-periodic curves as well.

Known issue(s):
* Some redundant constraints may be added under certain circumstances (e.g. in
presence of perpendicular-via-point)
 2024-12-04 00:57:40 +05:30
Ajinkya Dahale
c823a6b270 [Sketcher] Refactor SketchObject::split() 2024-12-04 00:57:40 +05:30
Ajinkya Dahale
b991c2fbc2 [Sketcher] Add tests for split and trim 
Includes:
* Tests for splitting and trimming of various types of curves
* Assertions on constraints expected to be added on these curves
 2024-12-04 00:57:40 +05:30
Ajinkya Dahale
423fb77e1f [Sketcher] Refactor SketchObject::AutoLockTangencyAndPerpty() 2024-12-04 00:57:40 +05:30
Ajinkya Dahale
4cc21e26e1 [Sketcher] Refactor SketchObject::delGeometry() 
Just dropped cognitive complexity to 25.
 2024-12-04 00:57:40 +05:30
Ajinkya Dahale
5f86d7f5a8 [Sketcher] Refactor SketchObject::getPoint() 
...to reduce cognitive complexity.

Use templates to break longer functions. Also makes it possible to avoid
repetition of type-checking logic.
 2024-12-04 00:57:39 +05:30
Ladislav Michl
0ee3c9f8e6 Base: Drop QString-std::string conversion functions from Tools 
Convenience helpers function Tools::toStdString and Tools::fromStdString
were implemented for Qt4 or older to perform utf8 aware conversion as
QString::toStdString/QString::fromStdString were using toAscii/fromAscii
internally (see https://dreamswork.github.io/qt4/classQString.html).

Since Qt5 QString uses toUtf8/fromUTf8, which makes the helper functions
obsolete (see https://doc.qt.io/qt-5/qstring.html#fromStdString).
 2024-12-02 23:30:53 -05:00
Vincent Belpois
f9d1391588 Sketcher: remove auto-generated 'enum value' comments 2024-12-02 23:27:26 -05:00
wmayer
d010645d23 Fix compiler warnings 2024-11-30 00:46:05 +01:00
Max Wilfinger
f0ba161bdf Update Sketcher external icons and cursors 2024-11-29 20:31:39 +01:00
PaddleStroke
7c15b3d240 Sketcher: OVP were drawn at wrong position when editing a sketch from link (#18060) 
* Sketcher: OVP were drawn at wrong position when editing a sketch from a link.

* Update src/Mod/Sketcher/Gui/DrawSketchController.h

Co-authored-by: Adrián Insaurralde Avalos <36372335+adrianinsaval@users.noreply.github.com>

---------

Co-authored-by: Adrián Insaurralde Avalos <36372335+adrianinsaval@users.noreply.github.com>
 2024-11-29 12:12:48 -05:00
PaddleStroke
e2f998f301 Sketcher: External: Change style to : defining are solid lines. Non-defining dashed. Both use external color. 2024-11-29 11:36:55 -05:00
PaddleStroke
63414bf06b Sketcher: Hide External BSpline overlay informations. 2024-11-29 11:36:55 -05:00
PaddleStroke
ac788df608 Sketcher: Rename External to Projection 2024-11-29 11:36:55 -05:00
PaddleStroke
0e5e071d72 Sketcher: Intersection externals 2024-11-29 11:36:55 -05:00
PaddleStroke
f3c79302c4 Sketcher: Defining External geos. 2024-11-29 11:36:55 -05:00
PaddleStroke
1c514f5a15 External geos : Enable face selection 2024-11-29 11:36:55 -05:00
Florian Foinant-Willig
5969df37f4 Sketcher infinite axes 2024-11-25 18:27:10 +01:00
PaddleStroke
fbd7f7090c Sketcher: ViewProviderSketch remove unecessary updateColor and applyCursor. 2024-11-25 12:25:58 -05:00
PaddleStroke
89fcfe95ee Sketcher: Offset & tranforms: enable external geos input. (#17615) 
* Sketcher: Offset & tranforms: enable external geos input.
* Sketcher: enable delGeometries to handle external geos.
 2024-11-25 10:57:16 -06:00
Chris Hennes
64f63ae97e Merge pull request #15528 from ppphp/move_some_inventor 
refactor: move some nodes to Inventor folder
 2024-11-22 12:20:50 -05:00
wmayer
aea09d4a45 MSVC: Fix compiler warnings 2024-11-22 16:53:00 +01:00
Jiří Pinkava
f9ba94c70b Sketcher: refactor, drop return in void returning functions 2024-11-18 12:21:25 -05:00
Max Wilfinger
616028efe5 Merge pull request #15957 from hasecilu/fix/capitalization 
TechDraw: Fix capitalization of 2D and 3D
 2024-11-15 18:37:47 +01:00
Syres916
08b9411e15 [Sketcher] Assist user in finding the sketch with the error 2024-11-15 12:15:59 -05:00
wmayer
ee1af2748a Coverity scan: Uninitialized scalar variable 
* CID 350633
* CID 512344
* CID 514343
 2024-11-13 18:58:16 -05:00
Yorik van Havre
a9b4cb5611 Translations (#17725) 
* Translations: updated ts files

* Translations: merged crowdin translations

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
 2024-11-11 17:01:52 +01:00
mwganson
93173ba797 [Sketcher] Address issue #17629, where Attach sketch command allows sketch to be attached to itself 2024-11-05 14:41:00 +01:00
PaddleStroke
4f323f9580 Core: Enable TaskDialogs to associate view (#17373) 
* Core: Add possibility for task dialogs to associate a view and be able to close when associated view is closed.

* TaskImage: Use task dialog view association.

* Sketcher: Use task dialog view association. Preventing crash (https://github.com/FreeCAD/FreeCAD/issues/16702)

* EditableDatumLabel: Use QPointer to prevent crash
 2024-10-29 09:58:11 -05:00
PaddleStroke
0a06ceff4d Sketcher: Dimension: Handle case of vertical/horizontal lines 2024-10-28 17:29:40 +01:00
wmayer
e44c59d2a8 Sketch: Make sure that variable 'ActiveSketch' is defined in macro 
Fixes #17502
 2024-10-28 17:23:50 +01:00
Yorik van Havre
86a229128c Merge pull request #17448 from Ondsel-Development/sk_rotate_arc_issue 
Sketcher: Rotate : Fix exploding sketches when rotating.
 2024-10-28 17:05:46 +01:00
wmayer
837d088f3e Fix compiler warnings 2024-10-26 00:48:04 +02:00
PaddleStroke
ed45e20768 Fix circle tangent issue 2024-10-25 10:03:47 -05:00
PaddleStroke
336dda316d Sketcher: Symmetric: Do not copy names of constraints (#17433) 
* Sketcher: Symmetric: Do not copy names of constraints

* Sketcher: Symmetric : Fix https://github.com/FreeCAD/FreeCAD/issues/17442
 2024-10-24 22:58:51 -05:00
PaddleStroke
982ffeac08 Sketcher: DrawSketchHandlerRotate : Fix unwanted copy of DistanceX/Y constraints 2024-10-24 11:33:28 +02:00
PaddleStroke
c098d9b312 Formating PythonConverter.cpp 2024-10-24 11:32:20 +02:00
PaddleStroke
d03441fca0 Sketcher: PythonConverter: use getRange to handle bad arcs. 2024-10-24 11:00:46 +02:00