Commit Graph

29630 Commits

Author SHA1 Message Date
Uwe
316a869b26 [Gui] remove superfluous nullptr checks 2022-07-18 03:17:42 +02:00
Uwe
53571f7196 [Base] remove superfluous nullptr checks 2022-07-18 03:16:22 +02:00
Uwe
fa36a57724 [App] remove superfluous nullptr checks 2022-07-18 03:12:01 +02:00
Uwe
615b1b9b00 [libE57] remove superfluous nullptr checks 2022-07-18 02:59:14 +02:00
Uwe
1823439195 [Robot etc.] remove superfluous nullptr checks 2022-07-18 02:54:09 +02:00
Uwe
c35579227b [Path] remove superfluous nullptr checks 2022-07-18 02:52:48 +02:00
Uwe
16c86a6d08 [Sketch] remove superfluous nullptr checks 2022-07-18 02:51:49 +02:00
Uwe
2d2ad11e14 [Mesh] remove superfluous nullptr checks 2022-07-18 02:37:33 +02:00
Uwe
48af573746 [FEM] remove more superfluous nullptr checks 2022-07-18 02:34:57 +02:00
Uwe
5d76afe0a5 re-add some nullptr
to be safe since their removal within assert() or bools might have some impact I don't know
2022-07-18 02:32:36 +02:00
Uwe
1f04880da9 [Image] [Inspection] remove superfluous nullptr checks 2022-07-18 01:54:09 +02:00
Uwe
ce86b03e0a [Spreadsheet] remove superfluous nullptr checks 2022-07-18 01:49:41 +02:00
Uwe
fc548a4b34 [FEM] remove superfluous nullptr checks 2022-07-18 01:45:19 +02:00
Uwe
5f8e0c46ee [Part] remove more superfluous nullptr checks 2022-07-18 01:36:27 +02:00
Uwe
697e88aed6 [PD] remove more superfluous nullptr checks 2022-07-18 01:33:28 +02:00
Uwe
5048f14d60 .clang-format: change a style
as discussed here: https://github.com/FreeCAD/FreeCAD/pull/6918#issuecomment-1186529217
2022-07-18 00:48:46 +02:00
Uwe
a8d01fa6c6 [PD] add parameter enabling logic for pad/pocket
- currently all parameters are always enabled and thus can lead to errors like the one reported here:
https://forum.freecadweb.org/viewtopic.php?f=3&t=70266
2022-07-18 00:26:15 +02:00
Uwe
e4dfc42f33 [PD] improve face selection for Pad/Pocket
- this PR extends PR #7191 as described in this forum thread: https://forum.freecadweb.org/viewtopic.php?f=3&t=70327
2022-07-17 18:35:34 +02:00
Uwe
35f75064a0 [PD] remove superfluous nullptr checks 2022-07-17 18:12:41 +02:00
Uwe
07ddfc88de [PD] App: remove superfluous nullptr checks
- also Body: get rid of some nasty single-letter variables
2022-07-17 18:07:00 +02:00
Uwe
e491ba8d12 [Part] remove superfluous nullptr checks 2022-07-17 18:06:21 +02:00
sliptonic
ef04487cd1 Merge pull request #7168 from sliptonic/feature/camoticstooltable
[Path] export a camotics tooltable
2022-07-17 08:42:43 -05:00
wmayer
5820618091 Import: do not export the entire class but only its public methods.
This fixes the warning C4251 for the template classes std::string or std::vector
Forum thread: https://forum.freecadweb.org/viewtopic.php?f=10&t=70317
2022-07-17 13:49:27 +02:00
wmayer
b548d3b1ef Partially revert "Remove unused code into GUI" 2022-07-17 12:32:03 +02:00
andrea
3018985f80 Remove unused code into GUI 2022-07-17 03:53:11 +02:00
Uwe
094ae93678 [PD] fix Pad/Pocket logic issue
- fixes the bug reported in https://forum.freecadweb.org/viewtopic.php?f=3&t=70266
  as Method #2
  -> When switching to two dimensions, symmetric must be unchecked if it is checked
2022-07-17 02:03:35 +02:00
Uwe
faa1f96f08 [FEM] check if Gmsh, CCX and Mystran solver binaries exist
- adds the check like we have already for Z88 and Elmer
- also remove an unnecessary return statement
2022-07-17 01:43:58 +02:00
Uwe
da104f63b7 [FEM] fix CCX (new framework) binary handling
- when the binary was not found, the function called the non-existing binary
- also push error message to the status info so that user gets feedback also when report view console is not shown
2022-07-17 01:28:54 +02:00
Uwe
3a993abfb4 [FEM] fix Z88 binary handling
- when the binary was not found, the function called the non-existing binary
- also push error message for Elmer and Z88 to the status info so that user gets feedback also when report view console is not shown
- uniform wording to 'binary'
- avoid unnecessary console output
2022-07-17 01:18:21 +02:00
Uwe
a4ec6d4f83 [TD] fix compilation on MSVC
- CLMODE was used before its declaration, therefore it did not compile
forum thread: https://forum.freecadweb.org/viewtopic.php?f=10&t=70316
2022-07-17 00:26:13 +02:00
Benjamin Bræstrup Sayoc
e80e8bf731 [TechDraw] Improve readability of DrawUtil.cpp 2022-07-16 16:00:43 -04:00
Benjamin Bræstrup Sayoc
0421d7cc5d [TechDraw] Gather rotation calculations in a single function 2022-07-16 16:00:10 -04:00
Benjamin Bræstrup Sayoc
137a4e0ee6 [TechDraw] Improve readability of Cosmetic.cpp 2022-07-16 16:00:10 -04:00
Benjamin Bræstrup Sayoc
568cc79186 [TechDraw] Refactor CosmeticEdge constructors
Use constructor delegation and default parameters for CosmeticEdge
2022-07-16 16:00:10 -04:00
Benjamin Bræstrup Sayoc
fac4e72ea4 [TechDraw] Use constructor delegation for CosmeticEdge 2022-07-16 16:00:10 -04:00
Benjamin Bræstrup Sayoc
eb3a04f30e [TechDraw] Use default parameters for LineFormat constructor 2022-07-16 16:00:10 -04:00
Uwe
4a5bf895ed [FEM] [skip CI] inform user about used CPU cores for Elmer
Since the number of used cores can for Elmer have the impact that a solver run converges or not, output this info prominently
2022-07-16 19:46:46 +02:00
Uwe
3542c73966 [FEM] [skip CI] tell user when Elmer write succeeded
At the moment the user gets no feedback, while for Z88 and CCX he gets a result
2022-07-16 19:41:43 +02:00
Uwe
146e5508aa [FEM] [skip CI] fix wording
Calculix will not be broken, but stopped. After clicking the button your will also get a message that it has been 'stopped'
2022-07-16 19:33:02 +02:00
wmayer
2a41f359f7 Gui: implement mechanism to set a custom icon name or tooltip of a preferences group 2022-07-16 19:27:22 +02:00
Uwe
2782d09dee [FEM] [skip CI] fix a typo 2022-07-16 19:21:25 +02:00
sliptonic
fa49c07840 Update src/Mod/Path/PathScripts/PathToolBitLibraryGui.py
Co-authored-by: Benjamin Bræstrup Sayoc <benj5378@outlook.com>
2022-07-16 12:16:14 -05:00
sliptonic
1a8a7959e5 Merge pull request #7127 from sliptonic/feature/chipbreak
[Path] Feature/chipbreak
2022-07-16 12:02:38 -05:00
Uwe
32ac6fa9fd [FEM] [skip CI] fix a string 2022-07-16 18:54:11 +02:00
sliptonic
9f7c699fb8 GUI panel for chipbreaking 2022-07-16 11:30:16 -05:00
sliptonic
6d81f31f11 Additional changes to support G73 2022-07-16 11:30:16 -05:00
sliptonic
ff1e995f30 Generator can produce G73 (chipbreak) commands instead of G83.
Add tests
2022-07-16 11:30:16 -05:00
wmayer
2dd9d69112 Gui: fix crash in ExpressionCompleter::slotUpdate
Forum thread: https://forum.freecadweb.org/viewtopic.php?f=3&t=69931
2022-07-16 18:23:42 +02:00
Wanderer Fan
3137a81604 [TD]check for spline on linear Dims 2022-07-16 11:28:38 -04:00
Wanderer Fan
5d93fbe0bb [TD]fix ext line gap preference 2022-07-16 11:28:38 -04:00