Commit Graph

3200 Commits

Author SHA1 Message Date
Yorik van Havre
3645d8be3b Merge pull request #10556 from Roy-043/Draft-arcTracker-did-not-take-Working-Plane-rotation-into-account
Draft: arcTracker did not take Working Plane rotation into account
2023-09-08 11:36:25 +02:00
luzpaz
6810c5703d Fix various typos 2023-09-07 20:34:49 +02:00
kaktus Jacek
65f3355a78 Removing unnecessary strings from Crowdin + improving typos
patches for #10459 and #10426...
a few small details escaped attention need to be fixed
😉
Removing unnecessary strings from Crowdin and improving typos.
2023-09-05 15:38:58 -05:00
Roy-043
1c39dabdb6 Draft: arcTracker did not take Working Plane rotation into account
Steps to verify the issue:
1. Open FreeCAD.
2. Switch to Std_ViewTop.
3. Click one of the curved arrows of the Navigation Cube.
4. Switch to the Draft WB.
5. Make sure Draft_SelectPlane is set to "Auto".
6. Start Draft_Arc and click 2 points (for the radius and the start angle).
7. Result: The displayed arc does not match the start angle or the current point.

Additonally:
* Removed the normal argument from `__init__`. The tracker does not work properly with just a normal. AFAICT there is no code that specifies this normal.
* Minor improvement to `getAngle`: Switched the vectors.
2023-09-05 15:39:17 +02:00
Yorik van Havre
50513232ac Merge pull request #10505 from Roy-043/Draft-Fix-angle-range-issue-of-make_circle
Draft: Fix angle range issue of make_circle
2023-09-04 11:29:13 +02:00
Yorik van Havre
5c806d707c Merge pull request #10464 from Ondsel-Development/bug/remove_gui_dependency
Bug fix: Allow Draft WB to import in FreeCAD headless docker container
2023-09-04 11:22:53 +02:00
Yorik van Havre
2556801938 Draft: Workaround failing multifuse in shape2Dview (#10478) 2023-09-04 10:45:56 +02:00
Roy-043
a8e4b3a18f Ammended files based on review 2023-09-03 12:43:34 +02:00
Amritpal Singh
fc973de1d9 Bug fix: Allow Draft WB to import in FreeCAD headless docker container 2023-09-03 12:24:22 +05:30
Roy-043
341649e1d1 Draft: Correct mistake in PR10160 (#10506)
`self.gui_tools_repository` is an instance of a class that manages a dictionary, it is not a dictionary itself.
2023-09-02 23:37:16 +02:00
Roy-043
5cc0cc22db Typo... 2023-09-02 23:04:41 +02:00
Roy-043
0d2b3f566a Draft: Fix angle range issue of make_circle 2023-09-02 20:48:40 +02:00
Yorik van Havre
62b7de348d Merge pull request #10425 from Roy-043/Draft-FixDraft_Mirror-preview
Draft: Fix Draft_Mirror preview
2023-09-01 12:48:16 +02:00
Roy-043
426e98a7a9 Draft: importDWG.py wrongly assumed that opt directory always exists on Linux (#10447)
Forum topic:
https://forum.freecad.org/viewtopic.php?p=703063#p703061
2023-08-30 18:10:13 +02:00
kaktus Jacek
ddc6c2a1a0 Cleaning code from unnecessary strings generated to Crowdin 4 (#10426)
Cleaning Crowdin of "garbage". Second approach.
https://github.com/FreeCAD/FreeCAD-translations/issues/270
2023-08-29 12:57:26 -05:00
Roy-043
08c8f1d0da Draft: Remove unused import WorkingPlane 2023-08-29 18:59:40 +02:00
Roy-043
9fde9f53fa Draft: Fix Draft_Mirror preview 2023-08-29 16:25:42 +02:00
Chris Hennes
40f130643a Update translations 2023-08-29 07:38:09 -05:00
Roy-043
c2a843a5dd Draft: Reduce occurrences of App.DraftWorkingPlane 2 (#10390) 2023-08-28 10:17:58 +02:00
Roy-043
af87661093 Draft: Reduce occurrences of App.DraftWorkingPlane (#10388) 2023-08-28 10:16:36 +02:00
Roy-043
32c47e64a3 Draft: Make gui_tool_utils.get_support nesting aware (#10373)
The get_support function did not work for objects nested in, for example, Std_Parts.

Additionally improved and cleaned up the code, and reduced the docstrings.
2023-08-27 12:41:25 +02:00
Roy-043
15e5f60d00 Draft: remove superfluous code from gui_points.py (#10379) 2023-08-27 12:41:01 +02:00
Roy-043
29eb25e8aa Draft: Add wp attribute to DraftTool class (#10386)
It makes sense to have this attribute. It will also facilitate the coming work related to the Plane class.

Additionally: Removed the `not self.doc` check from `Activated` as `IsActive` already handles this.
2023-08-27 12:40:30 +02:00
Roy-043
ac7fba867c Draft: Remove unused arguments from gui_tool_utils.get_point (#10347) 2023-08-25 03:49:06 +02:00
Roy-043
979d83a22b Draft: Housekeeping and minor improvements for some draftguitools (#10339) 2023-08-25 03:47:39 +02:00
Roy-043
1ed3782d4b Draft: Fix placement_from_face if vec_z matches normal of face (#10333) 2023-08-24 09:53:13 +02:00
Roy-043
292fadfb1c Draft: Fix error in PR10327 (#10329) 2023-08-23 13:32:37 +02:00
Roy-043
bfa8d79afb Draft: Add placement_from_face to geometry.py (#10327)
Changed getPlacementFromFace function in WorkingPlane.py to a compatibility function that calls placement_from_face.
2023-08-23 12:05:34 +02:00
Roy-043
649dde9808 Draft: Add placement_from_points to geometry.py
Changed getPlacementFromPoints function in WorkingPlane.py to a compatibility function that calls placement_from_points.
2023-08-23 11:17:17 +02:00
wmayer
142b86fde2 Mod: modernize C++: use equals default 2023-08-21 20:21:30 +02:00
sliptonic
9f49202dc3 Merge pull request #10230 from chennes/draftTranslateDraftAxisLabels
Draft: translate draft axis labels
2023-08-21 11:10:25 -05:00
Chris Hennes
bac14e81f7 Merge pull request #10258 from chennes/translations20230814
Update translations
2023-08-18 08:52:13 -05:00
Chris Hennes
f6b85d3721 Draft: Translate task titles for draft tools (#10227) 2023-08-17 16:01:15 +02:00
Chris Hennes
fcd622393a Draft: Translate label type combobox (#10228) 2023-08-17 15:36:37 +02:00
Chris Hennes
58cf9f3212 Update translations
Adds the ten units strings from Base as well.
2023-08-16 22:50:39 -05:00
Roy-043
fff0ca7217 Draft: Add Justification option to ShapeString (#10233) 2023-08-16 17:08:49 +02:00
Chris Hennes
ddaa34f0fc Draft: Translate Dimension and axis labels 2023-08-14 08:14:32 -07:00
Roy-043
b83e401836 Draft: Avoid dictionary.keys() where possible (#10160) 2023-08-13 11:46:25 +02:00
Roy-043
a32ed5c315 Draft: make_sketch should not change Autoconstraints of sketch (#10181) 2023-08-13 11:16:22 +02:00
Roy-043
7d15cee092 Draft: Fix SVG "Edges not ordered" issue (#10116) 2023-08-12 15:30:54 +02:00
Chris Hennes
3bad74fe7d Update translations 2023-08-08 17:52:59 -06:00
luzpaz
a6202bc3ce Fix various typos 2023-08-08 14:25:00 +02:00
Yorik van Havre
51d8f94f10 Merged crowdin translations 2023-07-26 11:05:11 +02:00
Yorik van Havre
4501cf479c Update ts files 2023-07-26 11:04:24 +02:00
Chris Hennes
dd40387478 Update translations 2023-07-24 13:37:52 +00:00
wmayer
fe9e54d7d8 Draft: add unit test for issue #9912 2023-07-24 13:55:28 +02:00
Roy-043
e008a3afe8 Draft: Auto workingplane ignored rotation around axis (#9955) 2023-07-20 18:46:10 +02:00
Roy-043
dc7b018e75 Draft: Improve downgrading of PD bodies (#9934) 2023-07-18 10:46:10 +02:00
Roy-043
419bc52f10 Draft: Fix get_diffuse_color function (#9932) 2023-07-18 10:45:38 +02:00
luzpaz
3110980e6e Fix various typos 2023-07-15 11:17:45 +02:00