Commit Graph

28039 Commits

Author SHA1 Message Date
Uwe
3e156aa5eb [3rdParty] SalomeMesh: fix comment typos found by the spellchecker CI 2022-03-12 18:38:53 +01:00
Uwe
bd3f45a208 [CXX] uniform inconsistent line endings 2022-03-12 18:29:51 +01:00
Uwe
426fdbd502 [CXX] fix typos found the spell CI 2022-03-12 18:25:35 +01:00
Uwe
a9b510f640 [Assembly] fix typos found by the spellchecker CI 2022-03-12 17:52:33 +01:00
Uwe
eb8636bb4e [3rdParty] fix typos found by the spellchecker CI 2022-03-12 17:49:37 +01:00
Uwe
06c9907982 [Robot] fix some typos found by the spellchecker CI 2022-03-12 17:46:48 +01:00
Abdullah Tahiri
a6e67dafa2 Sketcher: BSpline code review and fix
=====================================

- Avoid using EditCurve for the double use of storing the pole positions and the last mouse position. Split into individual vector for poles and previous cursor position (with appropriate names).
- Store all pole geoids to better show the intend of the code.
- Avoid indexing when referring the last inserted value of a std::vector, use back() instead.
- Encapsulate code to draw the bspline polygon and the cursor text to the given position. This allow to select the right function for every case, while avoiding unclear names, such as "mousemove()".
- Refactor code to finish command, to avoid calling unclear names such as "releasebutton" to better show the intend of the function call.
- Ensure deleted pole does not appear anymore in the scenograph.
2022-03-12 15:47:50 +01:00
Uwe
1e852e6d6b [Part] remove unused variable
MSVC complained about it
2022-03-12 15:44:27 +01:00
Wanderer Fan
12f0736189 [TD]fix 2 edge angle Dim special case 2022-03-12 08:55:35 -05:00
Chris Hennes
84bc5ea5d1 Test: Add first tests for Metadata 2022-03-11 20:15:44 -06:00
Chris Hennes
633449f8f7 Addon Manager: Fix window focus issues 2022-03-11 20:07:20 -06:00
mwganson
72e06ae529 Part: 2doffset fix crash by chacking for null shape before adding with builder.Add() 2022-03-12 02:48:22 +01:00
Zheng, Lei
b47e6723dc PD: add SubShapeBinder 'Refine' property
Respect setting in BaseApp/Preferences/Mod/PartDesign/RefineModel
2022-03-12 02:45:13 +01:00
Zheng, Lei
e56bcbc924 PD: fix SubShapeBinder 'Fuse' function 2022-03-12 02:45:13 +01:00
Uwe
48b2c3da12 [Path] fix a typo 2022-03-12 02:24:44 +01:00
Uwe
0777b23055 [CXX] fix typos found by the spellchecker CI 2022-03-12 02:19:48 +01:00
Uwe
4087dd6a92 [CXX] fix typos reported by the spellchecker CI 2022-03-12 02:07:38 +01:00
Uwe
bc09020e8b [Path] 2nd part of the Git fix attempt
renaming it back
2022-03-12 02:01:29 +01:00
Uwe
6901b9cf63 [Path] next attempt to fix Git error by renaming
use lowercase letters fro file ending like it is also in the CMake file
2022-03-12 02:00:40 +01:00
Uwe
b6f3295201 [Path] try to silence a git error with a file
Git has issues with this file telling me it is corrupted and its file ending is wrong (in Git lowercase, in the file uppercase).

The attempt is to just to save save it with FC 0.20.
2022-03-12 01:55:37 +01:00
wmayer
c3828d6225 Part: refactor PropertyPartShape::SaveDocFile and PropertyPartShape::RestoreDocFile
Set exception mask of std::istream::failbit | std::istream::badbit to istream to make sure it raises an exception for corrupted input files.
See: https://forum.freecadweb.org/viewtopic.php?p=536747
2022-03-11 22:06:38 +01:00
Wanderer Fan
ed82b361bf [TD]fix getScale should be Scale.getValue 2022-03-11 11:59:31 -05:00
sliptonic
e1ce0c7695 Merge pull request #6552 from Russ4262/fix/leadin_leadout_simulation
Path: Fix Leadin-Leadout dressup simulation related to arcs [Bug]
2022-03-11 10:06:42 -06:00
sliptonic
0bc9edeb50 Merge pull request #6541 from Russ4262/fix/ramp_entry_dressup
Path: Fix enumeration dictionary error [Bug]
2022-03-11 10:04:53 -06:00
sliptonic
182cabcfbb Merge pull request #6530 from sliptonic/bug/6114
[Path] Fix minor non-modal bug.  Fixes 6114
2022-03-11 10:03:53 -06:00
sliptonic
5eb170df1a Merge pull request #6536 from J-Dunn/master
PATH: Fix tool shapes for zero dimension bugs
2022-03-11 09:56:52 -06:00
Wanderer Fan
0676c27443 [TD]fix Dim text on wrong side 2022-03-11 08:10:58 -05:00
wmayer
92ec0d2334 Test: fix unit test 'Menu' 2022-03-11 13:57:56 +01:00
Civil Guy
6a00ef0ed1 Minor spelling fixes 2022-03-11 13:57:03 +01:00
Yorik van Havre
ffbbb4ec9f Arch: Fixed auto-height of child walls & structures - fixes #5732 2022-03-11 11:52:33 +01:00
wmayer
87f848a2c1 zipios++: Apply patch from https://sourceforge.net/p/zipios/news/2019/07/version-017-cve-/ (fixes #6453) 2022-03-11 08:10:26 +01:00
Chris Hennes
248946009c Addon Manager: Fix bug in macro button
Don't offer to install a toolbar button if it already exists.
2022-03-10 21:50:34 -06:00
Russell Johnson
48e4622193 Path: Fix Leadin-Leadout dressup simulation related to arcs
Add missing "Z" and "K" parameters for arc commands to appease Path simulator.
2022-03-10 20:05:52 -06:00
luz paz
8204fc84bf AddonManager: fix typos
Fixed via `codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,anormal,apoints,ba,beginn,behaviour,bloaded,bottome,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childrens,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,inout,ist,itsel,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oce,oder,ontop,orgin,orginx,orginy,ot,pard,parm,parms,pres,programm,que,rady,recurrance,ro,rougly,seperator,serie,sinc,strack,substraction,te,technic,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml,./src/Base/StackWalker.cpp,./build/doc/SourceDocu`
2022-03-10 18:28:10 -05:00
Zheng, Lei
c5a0db5e47 Gui: fix crash on editing PropertyVectorList in property view 2022-03-10 15:31:45 +01:00
Wanderer Fan
3b4b5a4e7c [TD]add missing ScaleType to Section dlg 2022-03-10 09:25:52 -05:00
Wanderer Fan
bbffb3f413 [TD]handle ScaleType in old documents 2022-03-10 09:25:52 -05:00
Yorik van Havre
dd1b0e0a3d Draft: Fixed error in SVG rendering of LinkedArrays - fixes #6516 2022-03-10 13:34:18 +01:00
wmayer
2a73ac7cb1 App: add convenience method DocumentObject::clearExpression() 2022-03-10 12:09:57 +01:00
Chris Hennes
c2055689a5 Addon Manager: Refactor to improve testability 2022-03-09 23:14:59 -06:00
Russell Johnson
6b8b870e21 Path: Fix enumeration dictionary error
This commit corrects an incorrect dictionary key in the enumeration dictionary updated with recent translation fixes.
2022-03-09 21:03:34 -06:00
marioalexis
b9028eb8a9 Part: Some updates in CompoundFilter.py 2022-03-10 03:07:07 +01:00
wmayer
fa0e6dfa9e App: correctly handle int as argument for ocumentPy::getObject
Add a unit test to confirm correct behaviour
2022-03-09 23:02:22 +01:00
wmayer
ae94c8489c App: [skip ci] fix bug in Metadata::supportsCurrentFreeCAD()
clang prints the warning: operator '?:' has lower precedence than '<<'; '<<' will be evaluated first [-Wparentheses]
2022-03-09 22:05:14 +01:00
wmayer
8d3c66cf18 Core/Mod: modernize C++11
* use nullptr
2022-03-09 21:55:31 +01:00
Chris Hennes
56a04dbbc0 Addon Manager: Begin Macro unit tests 2022-03-09 12:14:57 -06:00
Ajinkya Dahale
c596c2fe3d [Sketcher] Constrain first pole when created
By doing this, duplicate radius constraints are not made when deleting and
redefining second pole.
2022-03-09 16:43:47 +01:00
Ajinkya Dahale
0f093f4221 [Sketcher] Safeguard against spurious pre-selection
Preselection is sometimes not updated under some circumstances
1. when deleting an object through python;
2. before autoconstraint when deleting previous pole in bspline creation mode.

When the preselected curve is the deleted object, segfault/crash can happen.
2022-03-09 16:43:47 +01:00
Ajinkya Dahale
1d9dd035e7 [Sketcher] Redraw correctly on pole delete in "create b-spline"
This ensures that the last preview line drawn is always at the cursor and that
the coordinates are always w.r.t. the last defined pole.
2022-03-09 16:43:47 +01:00
marioalexis
8723f0b96d Part: Check geometry in Part_ExplodeCompound command 2022-03-09 15:41:30 +01:00