Commit Graph

15 Commits

Author SHA1 Message Date
Lorenz Hüdepohl
e38d0ada6c PathHelix: Fix locale issue for Gui::InputField setText() method 2017-02-17 20:55:37 +01:00
Lorenz Hüdepohl
837f2eabb8 PathHelix: Be more liberal in what constitues a straight cylinder 2017-02-17 20:55:17 +01:00
Lorenz Hüdepohl
f2faa50802 PathHelix: Switch to QToolBox based task panel
This makes it more consistent with the other Path operations
2017-01-14 17:04:36 +01:00
Lorenz Hüdepohl
0de0d8f930 PathHelix: fix most of the PEP8 issues
Dealt with most issues expect for overly long lines
2017-01-06 15:50:21 +01:00
Lorenz Hüdepohl
ec5faafd86 PathHelix: typo in error path 2017-01-06 15:14:04 +01:00
Lorenz Hüdepohl
1edc151c5d PathHelix: Drop requirement of scipy.spatial
It was deemed that scipy is too heavy a requirement for FreeCAD just for
this little feature. Fortunately it was possible to extract the k-d tree
module from scipy with just minor modifications - it is quite
self-contained.

Now, only numpy is required.
2017-01-06 13:20:18 +01:00
Lorenz Hüdepohl
cd3c1d574e Path: Helix taskpanel shows interdependencies of holes
Instead of a flat list of holes now a tree is shown, with the various
machining operations for the individual holes grouped together.
2017-01-04 20:11:49 +01:00
Lorenz Hüdepohl
72f9ec67e7 Path: Fix GUI race condition in helix task panel checkboxes 2016-12-31 00:02:22 +01:00
Lorenz Hüdepohl
32bcc0a579 Rebase onto current master 2016-12-30 22:47:47 +01:00
Lorenz Hüdepohl
2d6ea99035 PathHelix: Add GUI list with selected features 2016-12-30 22:47:47 +01:00
Lorenz Hüdepohl
6ad0a1f64b PathHelix: "Cancel" and some logic in task panel
- "Cancel" now restores the original values as it should.
- The various mutually exclusive uses of UseStartDepth, UseFinalDepth
  and ThroughDepth are now reflected in the GUI by grayed-out components
2016-12-30 22:47:47 +01:00
Lorenz Hüdepohl
00226a9c47 PathHelix: Fixes for clearance, non-aligned centers
The safe Z value was calculated with respect to the current hole, but
the tool should better be always retracted to the safe Z value with
respect to the first hole of a series of holes.

Another fix concerns the detection of holes-within-holes, previously it
was assumed that there the centers must align perfectly, this seems to
be the case only up to some numerical precision. Fixed by just allowing
any hole that is wholly contained in the first hole, even it is not
centered.
2016-12-30 22:47:47 +01:00
Lorenz Hüdepohl
20af62cb9e PathHelix: Fix StartDepth and FinalDepth for recursive holes
These were previously only applied for the first and last operation,
respectively. Now whole operations can be skipped if they are completely
outside the specified range.
2016-12-30 22:47:47 +01:00
Lorenz Hüdepohl
cd651d1a42 A TaskPanel for PathHelix 2016-12-30 22:47:46 +01:00
Lorenz Hüdepohl
f025636a9c HelixCut: A new Path command to make circular holes 2016-12-30 22:47:46 +01:00