Commit Graph

29417 Commits

Author SHA1 Message Date
WandererFan
42a61ca889 [TD]Fix bad circles (fix #16980) (#17182)
* [TD]fix spurious messages in GeometryMatcher

* [TD]fix closed circle test (fix #16980)
2024-10-14 17:47:04 +02:00
wandererfan
9f7e50e4ce [TD]throttle over aggressive dimension autocorrect 2024-10-14 17:45:53 +02:00
Furgo
df639075b1 Assembly: make "Solve failed" error more verbose (#17117)
* Add FC_ERR macro for the 'Solve failed' Assembly error

* Handle standard exceptions during assembly solve

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2024-10-14 10:43:15 -05:00
Yorik van Havre
0b4510c977 BIM: Fixed missing object creation in IFC document conversion (#17093)
* BIM: Fixed missing object creation in IFC document conversion - fixes #17031

* BIM: fixed deleting of non-existing objects - fixes #17032
2024-10-14 17:37:31 +02:00
Florian Foinant-Willig
0c59bfc718 Disable closed Loft for less than 3 profiles 2024-10-14 17:35:54 +02:00
Jiří Pinkava
cdb1a4f8ef Gui: Workaround for crash on close of MDI window
The Qt6 (up to Qt 6.7.3 now) contains bug, which can lead, under
specific circumstances, to crash of the application, when the
MDI window is closed. The circumstances are:

* at least 2 MDI windows needs to be open
* stylesheet muset set different size (border, margin) for activated and un-activated tabBar tab
* the closed window must be inactive, but created before the window now active and open
* race condition must occur betwee the closing and resize event handlers for the tabBar
  (see qt bug for details)

So this bug only occures with Qt6 with the Dark or Light styles selected (no classic) and only if
specific sequence of steps is followed during opening and closing the MDI windows.

The bug is in Qt code path executed when QMdiArea::ActivationHistoryOrder is set.

The other possible workaround might be to change all the affected stylesheets, but this seems to me
impractical and also fragile, because the affected code path will be still active.

https://bugreports.qt.io/browse/QTBUG-129596
2024-10-14 10:32:53 -05:00
wmayer
8711ae90c6 Part: Fix XML output of PropertyGeometryList::Save
Write all XML attributes of the Geometry element into a single line.

Currently the XML output looks:
                        <Geometry type="Part::GeomLineSegment"
 id="-1" migrated="1">

With the fix it will be:
                        <Geometry type="Part::GeomLineSegment" id="-1" migrated="1">
2024-10-14 09:07:46 -05:00
PaddleStroke
28b1112451 AssemblyObject.cpp : add failsafe checks 2024-10-14 08:58:35 -05:00
PaddleStroke
8b1baaef8f AssemblyObjectPyImp.cpp : make sure PyObjects are valid 2024-10-14 08:58:35 -05:00
PaddleStroke
876389af23 JointObject: fix flip one part 2024-10-14 08:58:35 -05:00
marioalexis
06f2ea4ee9 Fem: Fix examples affected by Part workbench preference parameter 2024-10-14 08:51:50 -05:00
Shai Seger
b54bbddc4e Fix shader compilation error on linux. (#17236) 2024-10-14 08:51:11 -05:00
marioalexis84
1f2cdbc046 Fem: Remove highlighted nodes if ccx finish without error - fixes #14855 (#17203) 2024-10-14 08:50:46 -05:00
PaddleStroke
ad6d148935 Assembly: Fix context menu 'Activate object' not working and causing crash (#17092)
* Assembly: Add setupContextMenu to ViewProviderAssembly.h

* Assembly: Fix right click 'activate object' menu not setting edit

* add QMenu header

* Add NOLINT

* Add one more space before //NOLINT or clang cries...

* Fix isInEditMode

* add isInEditMode to ViewProviderAssemblyPy.xml

* add isInEditMode to ViewProviderAssemblyPyImp.cpp

* update activeAssembly() in Utils to make sure isInEditMode
2024-10-14 08:29:49 -05:00
PaddleStroke
eab65cc42c Assembly: Remove JointObject camera callbacks. And fix lock highlight. 2024-10-14 08:27:36 -05:00
Roy-043
d71fcf7593 Draft: Fix upgrade function: delete argument was ignored in case of draftify
Forum topic:
https://forum.freecad.org/viewtopic.php?t=91357
2024-10-14 08:19:03 -05:00
wmayer
f9547e8231 PD: Fix crash when clicking on invalid edge in task panel
Fixes #10843
2024-10-13 13:34:14 -05:00
PaddleStroke
82a98d6e31 Assembly: Joint: add support to non ascii characters. 2024-10-10 20:36:54 -05:00
PaddleStroke
a445b01869 Assembly: Fix joint labels bad auto-rename issue. 2024-10-10 20:36:54 -05:00
wmayer
9bfa461520 Core: Check returned pointer of convertSWIGPointerObj 2024-10-10 20:36:03 -05:00
marioalexis
baee132f76 Fem: Remove reduntant info from geometry selector widget title 2024-10-10 20:33:54 -05:00
marioalexis
89286f47c4 Fem: Enable expression for the mesh Netgen task panel 2024-10-10 20:33:54 -05:00
marioalexis
9ad96c89bb Fem: Enable expression for the mesh region task panel 2024-10-10 20:33:54 -05:00
marioalexis
9bd0bf38d6 Fem: Enable expression for the mesh boundary layer task panel 2024-10-10 20:33:54 -05:00
marioalexis
cb7b90fb88 Fem: Enable expression for the element geometry 2D task panel 2024-10-10 20:33:54 -05:00
marioalexis
7100d06e76 Fem: Enable expression for the element geometry 1D task panel 2024-10-10 20:33:54 -05:00
marioalexis
a5720ec496 Fem: Enable expression for the centrif constraint task panel 2024-10-10 20:33:54 -05:00
marioalexis
d94c65ba3f Fem: Enable expression for the spring constraint task panel 2024-10-10 20:33:54 -05:00
marioalexis
40531158f2 Fem: Enable expression for the heat flux constraint task panel 2024-10-10 20:33:54 -05:00
PaddleStroke
736f03caf2 Assembly: Fix gear/belt switch on checkbox toggle 2024-10-10 20:26:18 -05:00
Syres916
8b53daf263 [Gui] Disable the ability to change themes and preference packs... 2024-10-10 20:25:30 -05:00
marioalexis
5aebe6d751 Fem: Fix gap in constraint fixed symbol 2024-10-10 20:22:50 -05:00
Roy-043
c366ec1baa BIM: Remove calls to end_all_events to avoid Linux crash
Fixes #15723.
2024-10-10 13:47:09 +02:00
Paul Lee
d535e46b5a [Arch] Bug: ArchRemove Creates Cyclic Dependency and TNP
FreeCAD Discussion Forum -
https://forum.freecad.org/viewtopic.php?t=91180&start=30#p786308
2024-10-10 10:06:09 +02:00
PaddleStroke
a9bff78974 Sketcher: Fix double click of wire and remove selection that was not working 2024-10-08 10:53:00 -05:00
PaddleStroke
12c6fc2920 Core: Fix #7580 (#17013)
Fixes several undo/redo issues with the attachment dialog
2024-10-08 10:21:08 +02:00
PaddleStroke
13eeb7b8c2 Assembly: Fix migrationScript2 error with bad joints (#17010)
* Fix migrationScript2 to handle bad joints
2024-10-07 18:48:38 -05:00
marioalexis
8078e77169 Fem: Add option to use old Netgen mesher implementation 2024-10-07 18:11:11 +02:00
marioalexis
00cf6437af Fem: Use default size for mesh task panel quantity spin boxes 2024-10-07 17:55:39 +02:00
mwganson
a836e0d656 [Part Workbench] Fix issue with Sketcher_NewSketch icon moving on changing back to workbench 2024-10-07 10:52:48 -05:00
Furgo
be5255e9bf Create the assembly object inside the list of commands 2024-10-07 17:48:00 +02:00
Florian Foinant-Willig
c1c9cb63e0 Fix duplicate calculation at Task validation 2024-10-07 17:46:21 +02:00
marcuspollio
91a68b1b58 Start: little layout tweak to First Start Region 2024-10-07 17:41:42 +02:00
wmayer
4fe1513365 TD: Fix compiler warnings
This fixes the compiler warning: unused parameter 'mode' [-Wunused-parameter]

It's a regression of #16889 to not initialize the class member m_createMode any more that causes UB,
i.e. whenever m_createMode is accessed it may return an unexpected value.
2024-10-07 17:40:32 +02:00
Yorik van Havre
6c3c559225 Merge pull request #16963 from FlachyJoe/fix_primitivePlacement
PartDesign: Fix primitive placement
2024-10-07 17:39:27 +02:00
Unl0gic
4a617bf326 Update SurfaceSupport.py
- Fixed mapping v_bit to ConeCutter
2024-10-07 17:35:02 +02:00
wandererfan
528c2a0a17 [TD]fix parallel edge test (fix #16851)
- missing normalization before test
2024-10-07 17:34:11 +02:00
Benjamin Bræstrup Sayoc
5ce6c7933a [Sketcher] If origin selected: don't do distance to origin
In auto constrainer. Fixes #12684
2024-10-07 09:02:43 -05:00
mwganson
dfafbfb040 [PartDesign AllowCompound] recompute all features when AllowCompound property is changed either from true to false or from false to true 2024-10-07 08:56:07 -05:00
shai
f43444c03e Fix issue #17035 2024-10-07 08:35:43 -05:00