Commit Graph

26993 Commits

Author SHA1 Message Date
wmayer
42d48103e8 Tools: lgtm: removes unused imports in Python scripts 2022-03-20 21:41:30 +01:00
Uwe
c9dee5e70a [Start] remove unused headers and Xerces 2022-03-20 21:36:16 +01:00
Uwe
ee6d631531 [Web] remove unused headers and Xerces 2022-03-20 21:16:27 +01:00
Uwe
66e8a2bef3 [Spreadsheet] remove Python.h and Xerces 2022-03-20 20:44:17 +01:00
Uwe
b037d8e240 [PD] remove unused Xerces 2022-03-20 20:43:02 +01:00
Uwe
fe213a48f0 [Part] remove unused Xerces 2022-03-20 19:37:20 +01:00
wmayer
21404f319b Path: fix assignment operator of CLine
* Assignment operator in class CLine should have return type CLine&. Otherwise a copy is created at each call.
2022-03-20 19:32:32 +01:00
wmayer
8b72d595d6 Mesh: [skip ci] remove superfluous semicolon 2022-03-20 19:31:35 +01:00
Uwe
ee0b9be87c [Measure] remove unused file 2022-03-20 19:26:22 +01:00
luz paz
1db77d367c AddonManager: remove superfluous 'pass' per LGTM
ref: https://lgtm.com/rules/910088/
2022-03-20 14:21:57 -04:00
Daniel Wood
deea933a23 [Material] evaluate the number of columns correctly when rebuilding the FCMats (#5910)
* evaluate the number of columns correctly.
* simplify awk command
2022-03-20 19:20:29 +01:00
Uwe
24176431fb [Inspection] remove Python.h from headers
is not necessary anymore
2022-03-20 18:09:46 +01:00
Uwe
ccc5198815 [Measure] remove unused includes 2022-03-20 17:56:00 +01:00
Uwe
00ffc38850 [Measure] remove Python.h from headers
is not necessary anymore
2022-03-20 17:41:04 +01:00
wmayer
c9a0fae9db lgtm: [skip ci] FIXME comment
Change FIXME or remove it
2022-03-20 16:51:23 +01:00
wmayer
702222b5a2 App: [skip ci] lgtm: Declaration hides parameter
Local variable 'obj' hides a parameter of the same name.
2022-03-20 16:46:16 +01:00
wmayer
32e9984751 App: [skip ci] lgtm: Large object passed by value
This parameter of type pair<const basic_string<char, char_traits<char>, allocator<char>>, Metadata> is 672 bytes - consider passing a const pointer/reference instead.
2022-03-20 16:42:48 +01:00
sliptonic
166e4a3e1e Merge pull request #6616 from FreeCAD/Path/LGTM-pas
Path: remove superfluous 'pass' per LGTM
2022-03-20 10:41:40 -05:00
wmayer
27a2646415 Base: [skip ci] lgtm: Inconsistent definition of copy constructor and assignment ('Rule of Two') 2022-03-20 16:30:14 +01:00
wmayer
cb81addfa1 Mesh: [skip ci] lgtm: Multiplication result converted to larger type
Multiplication result may overflow 'float' before it is converted to 'double'.
2022-03-20 15:53:04 +01:00
Uwe
8f894ebefe [Part] remove Python.h from headers
seems not to be necessary anymore
2022-03-20 14:16:55 +01:00
Uwe
d06dc1527c [PD] remove Python.h from headers
seems not to be necessary anymore
2022-03-20 14:16:41 +01:00
wmayer
c3aebfeb1e MeshPart: suppress incorrect warning with clang/MSYS 2022-03-20 13:45:43 +01:00
wmayer
fdf5df5645 Fem: [skip ci] change include order to fix compiler warning due to a re-defition of a macro in a Python header 2022-03-20 13:44:55 +01:00
wmayer
d396116d71 libE57Format: fix unknown-pragma warning with clang/MSYS 2022-03-20 13:43:22 +01:00
wmayer
a93cec09bc App: [skip ci] fix warning 2022-03-20 13:41:45 +01:00
wmayer
c8edbe0c30 Base: [skip ci] cleaning up modules is only needed for leak detectors 2022-03-20 13:39:22 +01:00
wmayer
be56aa082e Base: [skip ci] fix build failure if PCH is enabled 2022-03-20 13:34:32 +01:00
Uwe
d355b9d9e2 [Part] fix TaskFaceColors dialog
fixes these issues:
- the actual or chosen color is never displayed in the dialog's color button (it was there but with zero transparency)
- after a color has been set one does not see it (because the changed faces were still highlighted and got the highlight color)
2022-03-20 05:41:34 +01:00
luz paz
8939e3a2eb Path: remove superfluous 'pass' per LGTM
ref: https://lgtm.com/rules/910088/
2022-03-19 20:06:48 -04:00
wmayer
a999a249e3 Qt: remove some more leftovers of Qt4 2022-03-19 23:27:28 +01:00
andrea reale
13e09b36f8 remove QT4 references 2022-03-19 23:07:38 +01:00
sliptonic
06959ededb Merge pull request #6575 from Russ4262/fix/rebuild_empty_job_with_gui
Path: Extend Job integrity check to GUI side, issue #6207 [Bug]
2022-03-19 15:44:28 -05:00
Chris Hennes
21ac5f9a9c Addon Manager: Add py-slvs to allowed packages
Used by ASM3, and maintained by @realthunder.
2022-03-19 12:32:59 -05:00
Uwe
8ccc661379 [FEM] adapt a test to previous commit
(I run of course all tests using the Test Framework WB but did not get an error.)
2022-03-19 18:09:14 +01:00
Uwe
29f5e78583 [FEM] proper Elmer input file write solution
- assure that independent on the used unit scheme, SI units are written to the Elmer input file
- reverts commits https://github.com/FreeCAD/FreeCAD/commit/4a7f7a0faa and https://github.com/FreeCAD/FreeCAD/commit/28a4f6aef
2022-03-19 17:48:11 +01:00
wmayer
90d546d1e7 Fem: replace raw pointer with WeakPtrT to check if the object has been deleted, fix crash in destructor of TaskFemConstraintOnBoundary 2022-03-19 15:37:31 +01:00
wmayer
a60754ea93 App/Gui: make operator-> operator of WeakPtrT constant 2022-03-19 15:35:58 +01:00
Uwe
00ea879bfd [FEM] change example to fit with Elmer's tutorial
- this example is the Elmer tutorial number 13: https://www.nic.funet.fi/pub/sci/physics/elmer/doc/ElmerTutorials.pdf and they use a potential of 1.0, since Elmer uses SI units, it is 1.0 V
2022-03-19 15:29:55 +01:00
Uwe
e7f1fd5444 [Part] TaskFaceColors: remove unused includes
- also some code style fixes by MSVC and sorting
2022-03-19 15:16:09 +01:00
Uwe
c1ba1545a7 [Base] a compile for for MSVC 2022-03-19 15:02:19 +01:00
wmayer
b84e41bc89 App: make sure to create parent directories of a document's transient directory 2022-03-19 13:58:10 +01:00
wmayer
25bae6343b App: use static functions of FileInfo to convert between path and string 2022-03-19 13:57:24 +01:00
wmayer
a817a68c17 Base: add method FileInfo::createDirectories() to also create parent directories of a given path 2022-03-19 13:56:06 +01:00
wmayer
2ad512f14b Sketcher: [skip ci] close directory in unit test 2022-03-19 13:54:59 +01:00
Uwe
c360c6e5f5 [FEM] electrostatic dialog revision
- use a quantity spinbox and do simple signal/slot handling in the UI file
2022-03-19 05:01:23 +01:00
Uwe
aba3d40b2f [FEM] forgot this test case in previous commit 2022-03-19 03:51:06 +01:00
Uwe
258bce7261 [FEM] update test files to previous Elmer fixes 2022-03-19 03:34:18 +01:00
Uwe
28a4f6aefa [FEM] fix vacuum permittivity for the Elmer solver
also a missing fix for the density
2022-03-19 03:06:27 +01:00
Uwe
4a7f7a0faa [FEM] fix the Elmer solver writer
- fixes #6604
as it was, Elmer was almost unusable because most values were input with wrong units to Elmer.
Elmer uses pure SI units

ToDo: fix the still wrong Vacuum permittivity
2022-03-19 01:53:26 +01:00