lgtm: [skip ci] FIXME comment

Change FIXME or remove it
This commit is contained in:
wmayer
2022-03-20 16:51:23 +01:00
parent 702222b5a2
commit c9a0fae9db
7 changed files with 6 additions and 8 deletions

View File

@@ -108,7 +108,7 @@ public:
/// recalculate the Feature
virtual DocumentObjectExecReturn *execute(void);
/// returns the type name of the ViewProvider
//FIXME: Probably it makes sense to have a view provider for unittests (e.g. Gui::ViewProviderTest)
//Hint: Probably it makes sense to have a view provider for unittests (e.g. Gui::ViewProviderTest)
virtual const char* getViewProviderName(void) const {
return "Gui::ViewProviderFeature";
}

View File

@@ -347,7 +347,7 @@ int PyObjectBase::__setattro(PyObject *obj, PyObject *attro, PyObject *value)
const char *attr;
attr = PyUnicode_AsUTF8(attro);
//FIXME: In general we don't allow to delete attributes (i.e. value=0). However, if we want to allow
//Hint: In general we don't allow to delete attributes (i.e. value=0). However, if we want to allow
//we must check then in _setattr() of all subclasses whether value is 0.
if ( value==nullptr ) {
PyErr_Format(PyExc_AttributeError, "Cannot delete attribute: '%s'", attr);

View File

@@ -2137,7 +2137,7 @@ bool MeshOutput::SaveAny(const char* FileName, MeshIO::Format format) const
// Compressed VRML is nothing else than a GZIP'ped VRML ascii file
// str.close();
//Base::ogzstream gzip(FileName, std::ios::out | std::ios::binary);
//FIXME: The compression level seems to be higher than with ogzstream
//Hint: The compression level seems to be higher than with ogzstream
//which leads to problems to load the wrz file in debug mode, the
//application simply crashes.
zipios::GZIPOutputStream gzip(str);

View File

@@ -71,9 +71,7 @@
#include <string>
#include <vector>
// FIXME: Causes problem with boost/numeric/bindings/lapack/syev.hpp(117)
#ifdef FC_OS_WIN32
//# include <windows.h>
#include <io.h>
#endif

View File

@@ -138,7 +138,7 @@ void CrossSection::sliceSolid(double d, const TopoDS_Shape& shape, std::list<Top
void CrossSection::connectEdges (const std::list<TopoDS_Edge>& edges, std::list<TopoDS_Wire>& wires) const
{
// FIXME: Use ShapeAnalysis_FreeBounds::ConnectEdgesToWires() as an alternative
// Hint: Use ShapeAnalysis_FreeBounds::ConnectEdgesToWires() as an alternative
std::list<TopoDS_Edge> edge_list = edges;
while (edge_list.size() > 0) {
BRepBuilderAPI_MakeWire mkWire;

View File

@@ -1678,7 +1678,7 @@ App::DocumentObjectExecReturn* Hole::execute(void)
if (method == "Dimension")
length = Depth.getValue();
else if (method == "UpToFirst") {
/* FIXME */
/* TODO */
}
else if (method == "ThroughAll") {
length = getThroughAllLength();

View File

@@ -4176,7 +4176,7 @@ TopoShape Sketch::toShape(void) const
}
}
// FIXME: Use ShapeAnalysis_FreeBounds::ConnectEdgesToWires() as an alternative
// Hint: Use ShapeAnalysis_FreeBounds::ConnectEdgesToWires() as an alternative
//
// sort them together to wires
while (edge_list.size() > 0) {