Commit Graph

45 Commits

Author SHA1 Message Date
edi271
c46a4f776b [TD] Move Circulation method to DrawUtil 2022-01-21 11:22:40 -05:00
Wanderer Fan
e91cc8e329 [TD] avoid memory leaks by using shared_ptr
TD geometry objects are sometimes double deleted.  This
change uses shared_ptr instead of raw pointers to manage
deletions.
2022-01-07 13:34:20 -05:00
wmayer
c11d5df80a TD: replace usage of raw pointers of Vertex and Face with shared pointers.
This fixes issue 4741: Broken File After Using Landmark Dimension in TechDraw
2021-12-10 14:25:24 +01:00
wmayer
378dec720c Gui: fix -Winconsistent-missing-override, TD: fix -Wunused-parameter 2021-08-21 12:15:43 +02:00
Uwe
f5aea33548 Update src/Mod/TechDraw/App/Cosmetic.cpp
Co-authored-by: 0penBrain <48731257+0penBrain@users.noreply.github.com>
2021-08-03 13:23:14 +02:00
donovaly
b817ade2a8 [TD] comment the new centerline behavior
add missing info to understand the new centerline behavior as introduced with commit b981f905
2021-08-03 13:23:14 +02:00
donovaly
b981f9056c [TD] fix centerline crashes and bugs
the PR fixes the following things:
- change the way centerlines between 2 lines are calculated. The current implementation leads to many bugs and even crashes (e.g. when the 2 selected lines are parallel ones of a square). There are different forum threads from the last 1.5 years.
The new endpoint line sorting is the one described here: https://forum.freecadweb.org/viewtopic.php?f=35&start=20&t=44255&sid=989a668890f954c13ef81e4a04ee6912#p501179

- as consequence the erroneous and misleading line end flipping can go and is removed (only used internally)

- when creating a new centerline, you see it immediately

- when creating a new or editing an existing centerline and press Cancel, the creation/editing is aborted

- fix crash when the 2 selected lines are bot horizontal and one tries to create a vertical centerline

- fix crash when changing the orientation  of an existing centerline and the result would be invalid

- cleanup the code a bit
2021-05-15 05:21:29 +02:00
donovaly
a1915d313a [TD] make LineGroup selectable
At the moment one has to specify the LineGroup as string. But one doesn't know what groups exist. So one has to check the Wiki, learn there where the groups are defined and then open the definition file with a text editor.

This PR simplifies this by reading the existing groups out of the definition file and fill the combobox accordingly.
It also give the user info what the selected LineGroup defines via the tooltip.

A nice side effect is that no typos can occur since you don't have to enter the LineGroup name as text.
2020-12-03 17:24:49 +01:00
wandererfan
1cad17c5f5 [TD]draw line through 2 points 2020-08-19 09:02:25 -04:00
wmayer
cbb5f99ade PVS: V730 Not all members of a class are initialized inside the constructor 2020-07-18 10:59:27 +02:00
wandererfan
0ab224b46e [TD]makeCosmeticLine Y inversion 2020-07-12 09:04:59 -04:00
wandererfan
9bd95ed10f [TD]CosmeticVertex default size 2020-06-23 08:21:13 -04:00
wandererfan
dd0273ff4e [TD]Fix CosmeticVertex size 2020-06-09 16:12:14 -04:00
wandererfan
1533ea01ba [TD]Simplify Cosmetic List & PyObject handling 2020-05-16 07:42:45 -04:00
wandererfan
e80c576241 [TD]Centralize preference getters 2020-04-24 11:13:49 -04:00
wandererfan
30a0047cd4 [TD]Fix handling of CL flip parameter 2020-03-21 09:40:22 -04:00
wandererfan
96e8f752be [TD]Landmark Dims initial impl 2020-02-25 17:21:00 -05:00
wmayer
b33e1687b4 TechDraw: [skip ci] fix 'copy-constructor' of CenterLine 2019-12-17 12:41:14 +01:00
wandererfan
a04d0f2574 [TD]Py routines for CenterLines 2019-12-16 20:36:10 -05:00
wandererfan
1ad2d35bce [TD]Python routines and extension for line formating 2019-12-16 20:36:10 -05:00
wandererfan
d9e0c2e452 [TD]Python routines & extension for CosmeticVertex 2019-12-16 20:36:10 -05:00
wandererfan
a7ad04ba4a [TD]const-ness for dump function parameter 2019-11-10 15:58:45 -05:00
wandererfan
aab61f3e15 [TD]Fix wrong default for parameter 2019-11-07 16:59:10 -05:00
wandererfan
805d701aa7 [TD]Allow skip restore cosmetics
- temporary work around due to format changes during v019
  devl
2019-11-06 20:31:02 -05:00
wandererfan
fcf5435b43 [TD]Save geometry and tag with centerline 2019-11-06 20:31:02 -05:00
wandererfan
900a7c6bdd [TD]use UUID for CosmeticEdges instead of indices 2019-11-06 20:31:02 -05:00
wandererfan
5cab111a65 [TD]Implement unique tags for Cosmetic Vertex 2019-11-02 14:59:32 -04:00
wandererfan
a7d9661b1d [TD]Extent Dimensions 2019-11-02 14:59:32 -04:00
wandererfan
b5464ccf4d [TD]Add uuid tags for cosmetics 2019-08-22 17:11:55 -04:00
wmayer
5095703776 add missing std:: namespace to build on Debian 10 2019-08-21 23:56:46 +02:00
wandererfan
517b11ee3b [TD]Fix crash on same end points 2019-07-19 20:17:20 -04:00
wandererfan
3aa6fa19c6 [TD]Py functions for CenterLines and formatting 2019-07-19 20:17:20 -04:00
wandererfan
941968b37c [TD]Edge and Vertex center lines 2019-07-15 12:36:48 -04:00
wandererfan
3583141230 [TD] Fix Centerline position 2019-07-15 12:36:48 -04:00
wandererfan
621b66be17 [TD]Add Properties for Cosmetic persistence 2019-07-15 12:36:48 -04:00
wandererfan
3d2edd0f7e [TD]Add line appearance editor 2019-07-15 12:36:48 -04:00
wandererfan
11d8aaed61 [TD]Add CenterLine edit function 2019-07-15 12:36:48 -04:00
wandererfan
5970e91ef2 [TD]Py Cosmetic Vertex, Line, Circle Arc 2019-07-15 12:36:48 -04:00
wandererfan
3e0452417b Cosmetic CL for Section and Detail 2019-06-06 19:58:15 -04:00
wandererfan
93431edfba Initial version of Cosmetic Eraser 2019-06-06 19:58:15 -04:00
wandererfan
656e1654ff Initial working version Face Centerline 2019-06-06 19:58:15 -04:00
wmayer
d5c52d285c fix warning C4930: prototyped function not called 2019-05-25 13:07:33 +02:00
wmayer
4072b2c9d7 move includes to repsect PCH option 2019-05-25 13:04:57 +02:00
wandererfan
94b167f3a2 Add Midpoint and Quadrant Cosmetic Vertex 2019-05-24 19:38:02 -04:00
wandererfan
59e47de506 Initial version addCosmeticVertex 2019-05-24 19:38:02 -04:00